[PATCH v2 0/2] sched/topology: Fix sched_is_eas_possible() prints

[PATCH v2 0/2] sched/topology: Fix sched_is_eas_possible() prints

[Christian Loehle]

Fix two EAS abort condition prints by adding the missing newline

v2:
Split series for backports, Cc stable and add fixes tags.

Christian Loehle (2):
  sched/topology: Fix EAS cpufreq check print
  sched/topology: Fix EAS freq-invariance print

 kernel/sched/topology.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

--
2.34.1

[PATCH v2 1/2] sched/topology: Fix EAS cpufreq check print

[Christian Loehle]

Add the missing newline on cpufreq check to ensure the EAS abort
reason doesn't go missing.

Fixes: 8f833c82cdab ("sched/topology: Change behaviour of the 'sched_energy_aware' sysctl, based on the platform")
Cc: stable@vger.kernel.org
Signed-off-by: Christian Loehle <christian.loehle@arm.com>
Reviewed-by: Vincent Guittot <vincent.guittot@linaro.org>
---
 kernel/sched/topology.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kernel/sched/topology.c b/kernel/sched/topology.c
index c49aea8c1025..27f14a775004 100644
--- a/kernel/sched/topology.c
+++ b/kernel/sched/topology.c
@@ -256,7 +256,7 @@ static bool sched_is_eas_possible(const struct cpumask *cpu_mask)
 		policy = cpufreq_cpu_get(i);
 		if (!policy) {
 			if (sched_debug()) {
-				pr_info("rd %*pbl: Checking EAS, cpufreq policy not set for CPU: %d",
+				pr_info("rd %*pbl: Checking EAS, cpufreq policy not set for CPU: %d\n",
 					cpumask_pr_args(cpu_mask), i);
 			}
 			return false;
-- 
2.34.1

[PATCH v2 2/2] sched/topology: Fix EAS freq-invariance print

[Christian Loehle]

Add the missing newline on frequency invariance check to ensure the EAS
abort reason doesn't go missing.

Fixes: fa50e2b452c6 ("sched/topology: Condition EAS enablement on FIE support")
Cc: stable@vger.kernel.org
Signed-off-by: Christian Loehle <christian.loehle@arm.com>
Reviewed-by: Vincent Guittot <vincent.guittot@linaro.org>
---
 kernel/sched/topology.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/kernel/sched/topology.c b/kernel/sched/topology.c
index 27f14a775004..18e804b416f5 100644
--- a/kernel/sched/topology.c
+++ b/kernel/sched/topology.c
@@ -245,7 +245,7 @@ static bool sched_is_eas_possible(const struct cpumask *cpu_mask)
 
 	if (!arch_scale_freq_invariant()) {
 		if (sched_debug()) {
-			pr_info("rd %*pbl: Checking EAS: frequency-invariant load tracking not yet supported",
+			pr_info("rd %*pbl: Checking EAS: frequency-invariant load tracking not yet supported\n",
 				cpumask_pr_args(cpu_mask));
 		}
 		return false;
-- 
2.34.1

Re: [PATCH v2 0/2] sched/topology: Fix sched_is_eas_possible() prints

[Christian Loehle]

On 3/19/25 13:13, Christian Loehle wrote:
> Fix two EAS abort condition prints by adding the missing newline
> 
> v2:
> Split series for backports, Cc stable and add fixes tags.
> 
> Christian Loehle (2):
>   sched/topology: Fix EAS cpufreq check print
>   sched/topology: Fix EAS freq-invariance print
> 
>  kernel/sched/topology.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> --
> 2.34.1
> 

Peter, Ingo,
Could someone pick these up pretty please?