From: "Rafael J. Wysocki" <rjw@rjwysocki.net>
To: Kees Cook <keescook@chromium.org>
Cc: Len Brown <lenb@kernel.org>,
linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] acpi: avoid leaking format string into kobject name
Date: Fri, 08 Jan 2016 01:44:33 +0100 [thread overview]
Message-ID: <24226423.iyzeMndoHV@vostro.rjw.lan> (raw)
In-Reply-To: <20160107192429.GA5113@www.outflux.net>
On Thursday, January 07, 2016 11:24:29 AM Kees Cook wrote:
> The dn->name is expected to be used as a literal, so add the missing
> "%s".
>
> Signed-off-by: Kees Cook <keescook@chromium.org>
Applied, thanks!
> ---
> drivers/acpi/device_sysfs.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/acpi/device_sysfs.c b/drivers/acpi/device_sysfs.c
> index 707cf6213bc2..b9afb47db7ed 100644
> --- a/drivers/acpi/device_sysfs.c
> +++ b/drivers/acpi/device_sysfs.c
> @@ -104,7 +104,7 @@ static void acpi_expose_nondev_subnodes(struct kobject *kobj,
>
> init_completion(&dn->kobj_done);
> ret = kobject_init_and_add(&dn->kobj, &acpi_data_node_ktype,
> - kobj, dn->name);
> + kobj, "%s", dn->name);
> if (ret)
> acpi_handle_err(dn->handle, "Failed to expose (%d)\n", ret);
> else
>
--
I speak only for myself.
Rafael J. Wysocki, Intel Open Source Technology Center.
prev parent reply other threads:[~2016-01-08 0:13 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-07 19:24 Kees Cook
2016-01-08 0:44 ` Rafael J. Wysocki [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=24226423.iyzeMndoHV@vostro.rjw.lan \
--to=rjw@rjwysocki.net \
--cc=keescook@chromium.org \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®