mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Rafael J. Wysocki" <rjw@rjwysocki.net>
To: Hoan Tran <hotran@apm.com>
Cc: Len Brown <lenb@kernel.org>,
	pprakash@codeaurora.org,
	Ashwin Chaugule <ashwin.chaugule@linaro.org>,
	linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org,
	lho@apm.com, Duc Dang <dhdang@apm.com>
Subject: Re: [RESEND PATCH] ACPI: CPPC: Support PCC with interrupt flag
Date: Mon, 26 Sep 2016 14:56:02 +0200	[thread overview]
Message-ID: <2457650.luWgNvV3g9@vostro.rjw.lan> (raw)
In-Reply-To: <1473875698-12402-1-git-send-email-hotran@apm.com>

On Wednesday, September 14, 2016 10:54:58 AM Hoan Tran wrote:
> For PCC mailbox with interrupt flag, CPPC should call mbox_chan_txdone()
> function to notify the mailbox framework about TX completion.
> 
> Signed-off-by: Hoan Tran <hotran@apm.com>
> Reviewed-by: Prashanth Prakash <pprakash@codeaurora.org>
> ---
>  drivers/acpi/cppc_acpi.c | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/acpi/cppc_acpi.c b/drivers/acpi/cppc_acpi.c
> index 3d1ae6d..d0d0504 100644
> --- a/drivers/acpi/cppc_acpi.c
> +++ b/drivers/acpi/cppc_acpi.c
> @@ -311,7 +311,10 @@ static int send_pcc_cmd(u16 cmd)
>  	if (pcc_data.pcc_mrtt)
>  		last_cmd_cmpl_time = ktime_get();
>  
> -	mbox_client_txdone(pcc_data.pcc_channel, ret);
> +	if (pcc_data.pcc_channel->mbox->txdone_irq)
> +		mbox_chan_txdone(pcc_data.pcc_channel, ret);
> +	else
> +		mbox_client_txdone(pcc_data.pcc_channel, ret);
>  
>  end:
>  	if (cmd == CMD_WRITE) {
> 

Applied.

Thanks,
Rafael

      reply	other threads:[~2016-09-26 12:49 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-14 17:54 Hoan Tran
2016-09-26 12:56 ` Rafael J. Wysocki [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2457650.luWgNvV3g9@vostro.rjw.lan \
    --to=rjw@rjwysocki.net \
    --cc=ashwin.chaugule@linaro.org \
    --cc=dhdang@apm.com \
    --cc=hotran@apm.com \
    --cc=lenb@kernel.org \
    --cc=lho@apm.com \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=pprakash@codeaurora.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®