* [PATCH] cpufreq: fix speedstep_detect_processor()'s return type
@ 2018-04-24 13:14 Luc Van Oostenryck
2018-04-25 2:46 ` Viresh Kumar
0 siblings, 1 reply; 3+ messages in thread
From: Luc Van Oostenryck @ 2018-04-24 13:14 UTC (permalink / raw)
To: linux-kernel
Cc: Luc Van Oostenryck, Rafael J. Wysocki, Viresh Kumar, linux-pm
speedstep_detect_processor() is declared as returing an
'enum speedstep_processor' but use an 'int' in its definition.
Fix this by using 'enum speedstep_processor' in its definition too.
Signed-off-by: Luc Van Oostenryck <luc.vanoostenryck@gmail.com>
---
drivers/cpufreq/speedstep-lib.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/cpufreq/speedstep-lib.c b/drivers/cpufreq/speedstep-lib.c
index e3a9962ee..cabb6f48e 100644
--- a/drivers/cpufreq/speedstep-lib.c
+++ b/drivers/cpufreq/speedstep-lib.c
@@ -252,7 +252,7 @@ EXPORT_SYMBOL_GPL(speedstep_get_frequency);
*********************************************************************/
/* Keep in sync with the x86_cpu_id tables in the different modules */
-unsigned int speedstep_detect_processor(void)
+enum speedstep_processor speedstep_detect_processor(void)
{
struct cpuinfo_x86 *c = &cpu_data(0);
u32 ebx, msr_lo, msr_hi;
--
2.17.0
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] cpufreq: fix speedstep_detect_processor()'s return type
2018-04-24 13:14 [PATCH] cpufreq: fix speedstep_detect_processor()'s return type Luc Van Oostenryck
@ 2018-04-25 2:46 ` Viresh Kumar
2018-05-13 8:49 ` Rafael J. Wysocki
0 siblings, 1 reply; 3+ messages in thread
From: Viresh Kumar @ 2018-04-25 2:46 UTC (permalink / raw)
To: Luc Van Oostenryck; +Cc: linux-kernel, Rafael J. Wysocki, linux-pm
On 24-04-18, 15:14, Luc Van Oostenryck wrote:
> speedstep_detect_processor() is declared as returing an
> 'enum speedstep_processor' but use an 'int' in its definition.
>
> Fix this by using 'enum speedstep_processor' in its definition too.
>
> Signed-off-by: Luc Van Oostenryck <luc.vanoostenryck@gmail.com>
> ---
> drivers/cpufreq/speedstep-lib.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/cpufreq/speedstep-lib.c b/drivers/cpufreq/speedstep-lib.c
> index e3a9962ee..cabb6f48e 100644
> --- a/drivers/cpufreq/speedstep-lib.c
> +++ b/drivers/cpufreq/speedstep-lib.c
> @@ -252,7 +252,7 @@ EXPORT_SYMBOL_GPL(speedstep_get_frequency);
> *********************************************************************/
>
> /* Keep in sync with the x86_cpu_id tables in the different modules */
> -unsigned int speedstep_detect_processor(void)
> +enum speedstep_processor speedstep_detect_processor(void)
> {
> struct cpuinfo_x86 *c = &cpu_data(0);
> u32 ebx, msr_lo, msr_hi;
Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
--
viresh
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] cpufreq: fix speedstep_detect_processor()'s return type
2018-04-25 2:46 ` Viresh Kumar
@ 2018-05-13 8:49 ` Rafael J. Wysocki
0 siblings, 0 replies; 3+ messages in thread
From: Rafael J. Wysocki @ 2018-05-13 8:49 UTC (permalink / raw)
To: Viresh Kumar, Luc Van Oostenryck; +Cc: linux-kernel, linux-pm
On Wednesday, April 25, 2018 4:46:47 AM CEST Viresh Kumar wrote:
> On 24-04-18, 15:14, Luc Van Oostenryck wrote:
> > speedstep_detect_processor() is declared as returing an
> > 'enum speedstep_processor' but use an 'int' in its definition.
> >
> > Fix this by using 'enum speedstep_processor' in its definition too.
> >
> > Signed-off-by: Luc Van Oostenryck <luc.vanoostenryck@gmail.com>
> > ---
> > drivers/cpufreq/speedstep-lib.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/drivers/cpufreq/speedstep-lib.c b/drivers/cpufreq/speedstep-lib.c
> > index e3a9962ee..cabb6f48e 100644
> > --- a/drivers/cpufreq/speedstep-lib.c
> > +++ b/drivers/cpufreq/speedstep-lib.c
> > @@ -252,7 +252,7 @@ EXPORT_SYMBOL_GPL(speedstep_get_frequency);
> > *********************************************************************/
> >
> > /* Keep in sync with the x86_cpu_id tables in the different modules */
> > -unsigned int speedstep_detect_processor(void)
> > +enum speedstep_processor speedstep_detect_processor(void)
> > {
> > struct cpuinfo_x86 *c = &cpu_data(0);
> > u32 ebx, msr_lo, msr_hi;
>
> Acked-by: Viresh Kumar <viresh.kumar@linaro.org>
>
>
Applied, thanks!
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-05-13 8:49 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-04-24 13:14 [PATCH] cpufreq: fix speedstep_detect_processor()'s return type Luc Van Oostenryck
2018-04-25 2:46 ` Viresh Kumar
2018-05-13 8:49 ` Rafael J. Wysocki
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®