* [PATCH] KVM: x86: Remove unnecessary export of kvm_cpu_has_pending_timer()
@ 2022-11-10 1:03 Sean Christopherson
2022-11-14 6:50 ` Like Xu
0 siblings, 1 reply; 2+ messages in thread
From: Sean Christopherson @ 2022-11-10 1:03 UTC (permalink / raw)
To: Sean Christopherson, Paolo Bonzini; +Cc: kvm, linux-kernel
Don't export x86's kvm_cpu_has_pending_timer(), the helper isn't used by
KVM x86's vendor modules.
No functional change intended.
Signed-off-by: Sean Christopherson <seanjc@google.com>
---
arch/x86/kvm/irq.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/arch/x86/kvm/irq.c b/arch/x86/kvm/irq.c
index d8d50558f165..04a009fbdf8a 100644
--- a/arch/x86/kvm/irq.c
+++ b/arch/x86/kvm/irq.c
@@ -31,7 +31,6 @@ int kvm_cpu_has_pending_timer(struct kvm_vcpu *vcpu)
return r;
}
-EXPORT_SYMBOL(kvm_cpu_has_pending_timer);
/*
* check if there is a pending userspace external interrupt
base-commit: d663b8a285986072428a6a145e5994bc275df994
--
2.38.1.431.g37b22c650d-goog
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] KVM: x86: Remove unnecessary export of kvm_cpu_has_pending_timer()
2022-11-10 1:03 [PATCH] KVM: x86: Remove unnecessary export of kvm_cpu_has_pending_timer() Sean Christopherson
@ 2022-11-14 6:50 ` Like Xu
0 siblings, 0 replies; 2+ messages in thread
From: Like Xu @ 2022-11-14 6:50 UTC (permalink / raw)
To: Sean Christopherson; +Cc: kvm, linux-kernel, Paolo Bonzini
On 10/11/2022 9:03 am, Sean Christopherson wrote:
> Don't export x86's kvm_cpu_has_pending_timer(), the helper isn't used by
> KVM x86's vendor modules.
>
> No functional change intended.
The callers of EXPORT_SYMBOL (considering that this line of code has been around
for a long time) will not be public like the callers of EXPORT_SYMBOL_GPL.
Whether we close this door in the future or not, this description is inappropriate.
>
> Signed-off-by: Sean Christopherson <seanjc@google.com>
> ---
> arch/x86/kvm/irq.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/arch/x86/kvm/irq.c b/arch/x86/kvm/irq.c
> index d8d50558f165..04a009fbdf8a 100644
> --- a/arch/x86/kvm/irq.c
> +++ b/arch/x86/kvm/irq.c
> @@ -31,7 +31,6 @@ int kvm_cpu_has_pending_timer(struct kvm_vcpu *vcpu)
>
> return r;
> }
> -EXPORT_SYMBOL(kvm_cpu_has_pending_timer);
Not sure if the kernel's symbol or kbuild sub-system has tools to
automatically warn or turn off similar interface exposures.
>
> /*
> * check if there is a pending userspace external interrupt
>
> base-commit: d663b8a285986072428a6a145e5994bc275df994
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-11-14 6:50 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-11-10 1:03 [PATCH] KVM: x86: Remove unnecessary export of kvm_cpu_has_pending_timer() Sean Christopherson
2022-11-14 6:50 ` Like Xu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®