mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Keith Owens <kaos@ocs.com.au>
To: Alexander Viro <viro@math.psu.edu>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] binfmt_misc.c, kernel-2.4.12
Date: Mon, 22 Oct 2001 19:19:55 +1000	[thread overview]
Message-ID: <24947.1003742395@ocs3.intra.ocs.com.au> (raw)
In-Reply-To: Your message of "Mon, 22 Oct 2001 04:33:27 -0400." <Pine.GSO.4.21.0110220423230.2294-100000@weyl.math.psu.edu>

On Mon, 22 Oct 2001 04:33:27 -0400 (EDT), 
Alexander Viro <viro@math.psu.edu> wrote:
>On Mon, 22 Oct 2001, Keith Owens wrote:
>> If I can get an iron clad guarantee that binfmt_misc will never, ever
>> change again then I might consider hard coding the entries in modprobe.
>> BTW, I will need a signature in blood that says I can kill you if
>> binfmt_misc is ever changed :).
>
>Wait a second.  Who says anything about hardcoding that into modprobe?
>There is such thing as skeleton stuff for modules.conf, right?

Same thing.  The preset entries in modutils util/alias.h are added to
whatever the user has in modules.conf.  In some cases the preset
entries cannot be removed, they are cumulative so the hard coded entry
cannot be removed.

The preset entries already causes problems, why should modutils insist
on options sb io=0x220 irq=7 dma=1 dma16=5 mpu_io=0x330?

>Erm... Keith, I might be misreading the source, but... Shouldn't the
>information like "block major $FOO is in module $BAR" live in
>/lib/modules/*/* ?

Historically the mapping of device majors to module or binary format
type to module was coded into modutils, via util/alias.h.  That was a
mistake, it should have used the same technique as pci, isapnp, parport
etc., each module has a table that defines what it handles and modutils
extracts the data directly from the modules.  Developers have changed
the names of their modules and now we have hard coded module names in
modutils that do not match the names used by some kernels.  Hindsight
is wonderful!

In modutils 2.5 I will get rid of all the hard coded entries in
util/alias.h.  Instead each module will define what it supports,
including any special commands to be run when the module is loaded or
unloaded.  Much easier for everyone and far more flexible.


  reply	other threads:[~2001-10-22  9:23 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2001-10-19 11:54 Albert Bartoszko
2001-10-19 12:54 ` Alexander Viro
2001-10-19 13:32   ` Richard Guenther
2001-10-19 18:48     ` Alexander Viro
2001-10-19 21:35       ` Richard Guenther
2001-10-19 22:00         ` Alexander Viro
2001-10-22  6:00   ` Albert Bartoszko
2001-10-22  6:47     ` Alexander Viro
2001-10-22  7:42       ` Keith Owens
2001-10-22  8:05         ` Alexander Viro
2001-10-22  8:21           ` Keith Owens
2001-10-22  8:33             ` Alexander Viro
2001-10-22  9:19               ` Keith Owens [this message]
2001-10-22  9:34                 ` Alexander Viro
2001-10-22  9:55                   ` Alexander Viro
2001-10-22 11:17                   ` Keith Owens
2001-10-22 11:33                     ` Alexander Viro
2001-10-22 11:52                       ` Keith Owens
2001-10-22 12:15                         ` Alexander Viro
2001-10-22 12:37                           ` Keith Owens
2001-10-22 15:56                 ` bill davidsen
2001-10-22 15:47             ` bill davidsen
2001-10-22 17:24       ` Andrew Morton
2001-10-22 17:50         ` Alexander Viro
2001-10-23  9:28       ` Albert Bartoszko
2001-10-21 15:26 ` Alan Cox

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=24947.1003742395@ocs3.intra.ocs.com.au \
    --to=kaos@ocs.com.au \
    --cc=linux-kernel@vger.kernel.org \
    --cc=viro@math.psu.edu \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®