mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] ACPI: NFIT: limit string attribute write
@ 2023-07-04  8:17 Ben Dooks
  2023-07-05 18:34 ` Dave Jiang
  0 siblings, 1 reply; 5+ messages in thread
From: Ben Dooks @ 2023-07-04  8:17 UTC (permalink / raw)
  To: linux-kernel, linux-acpi; +Cc: nvdimm, lenb, Ben Dooks

If we're writing what could be an arbitrary sized string into an attribute
we should probably use snprintf() just to be safe. Most of the other
attriubtes are some sort of integer so unlikely to be an issue so not
altered at this time.

Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>
---
 drivers/acpi/nfit/core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/acpi/nfit/core.c b/drivers/acpi/nfit/core.c
index 9213b426b125..d7e9d9cd16d2 100644
--- a/drivers/acpi/nfit/core.c
+++ b/drivers/acpi/nfit/core.c
@@ -1579,7 +1579,7 @@ static ssize_t id_show(struct device *dev,
 {
 	struct nfit_mem *nfit_mem = to_nfit_mem(dev);
 
-	return sprintf(buf, "%s\n", nfit_mem->id);
+	return snprintf(buf, PAGE_SIZE, "%s\n", nfit_mem->id);
 }
 static DEVICE_ATTR_RO(id);
 
-- 
2.40.1


^ permalink raw reply	[flat|nested] 5+ messages in thread
* Re: [PATCH] ACPI: NFIT: limit string attribute write
  2023-07-04  8:17 [PATCH] ACPI: NFIT: limit string attribute write Ben Dooks
@ 2023-07-05 18:34 ` Dave Jiang
  2023-07-11  8:36   ` Ben Dooks
  0 siblings, 1 reply; 5+ messages in thread
From: Dave Jiang @ 2023-07-05 18:34 UTC (permalink / raw)
  To: Ben Dooks, linux-kernel, linux-acpi; +Cc: nvdimm, lenb



On 7/4/23 01:17, Ben Dooks wrote:
> If we're writing what could be an arbitrary sized string into an attribute
> we should probably use snprintf() just to be safe. Most of the other
> attriubtes are some sort of integer so unlikely to be an issue so not
> altered at this time.
> 
> Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>
> ---
>   drivers/acpi/nfit/core.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/acpi/nfit/core.c b/drivers/acpi/nfit/core.c
> index 9213b426b125..d7e9d9cd16d2 100644
> --- a/drivers/acpi/nfit/core.c
> +++ b/drivers/acpi/nfit/core.c
> @@ -1579,7 +1579,7 @@ static ssize_t id_show(struct device *dev,
>   {
>   	struct nfit_mem *nfit_mem = to_nfit_mem(dev);
>   
> -	return sprintf(buf, "%s\n", nfit_mem->id);
> +	return snprintf(buf, PAGE_SIZE, "%s\n", nfit_mem->id);

Why not just convert it to sysfs_emit()?

>   }
>   static DEVICE_ATTR_RO(id);
>   

^ permalink raw reply	[flat|nested] 5+ messages in thread
* Re: [PATCH] ACPI: NFIT: limit string attribute write
  2023-07-05 18:34 ` Dave Jiang
@ 2023-07-11  8:36   ` Ben Dooks
  0 siblings, 0 replies; 5+ messages in thread
From: Ben Dooks @ 2023-07-11  8:36 UTC (permalink / raw)
  To: Dave Jiang, linux-kernel, linux-acpi; +Cc: nvdimm, lenb

On 05/07/2023 19:34, Dave Jiang wrote:
> 
> 
> On 7/4/23 01:17, Ben Dooks wrote:
>> If we're writing what could be an arbitrary sized string into an 
>> attribute
>> we should probably use snprintf() just to be safe. Most of the other
>> attriubtes are some sort of integer so unlikely to be an issue so not
>> altered at this time.
>>
>> Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>
>> ---
>>   drivers/acpi/nfit/core.c | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/acpi/nfit/core.c b/drivers/acpi/nfit/core.c
>> index 9213b426b125..d7e9d9cd16d2 100644
>> --- a/drivers/acpi/nfit/core.c
>> +++ b/drivers/acpi/nfit/core.c
>> @@ -1579,7 +1579,7 @@ static ssize_t id_show(struct device *dev,
>>   {
>>       struct nfit_mem *nfit_mem = to_nfit_mem(dev);
>> -    return sprintf(buf, "%s\n", nfit_mem->id);
>> +    return snprintf(buf, PAGE_SIZE, "%s\n", nfit_mem->id);
> 
> Why not just convert it to sysfs_emit()?

I'll look into that.

-- 
Ben Dooks				http://www.codethink.co.uk/
Senior Engineer				Codethink - Providing Genius

https://www.codethink.co.uk/privacy.html


^ permalink raw reply	[flat|nested] 5+ messages in thread
* Re: [PATCH] ACPI: NFIT: limit string attribute write
  2023-07-11  9:22 Ben Dooks
@ 2023-07-11  9:36 ` Ben Dooks
  0 siblings, 0 replies; 5+ messages in thread
From: Ben Dooks @ 2023-07-11  9:36 UTC (permalink / raw)
  To: nvdimm; +Cc: linux-acpi, linux-kernel, lenb

On 11/07/2023 10:22, Ben Dooks wrote:
> If we're writing what could be an arbitrary sized string into an attribute
> we should probably use sysfs_emit() just to be safe. Most of the other
> attriubtes are some sort of integer so unlikely to be an issue so not
> altered at this time.
> 
> Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>
> ---
> v2:
>    - use sysfs_emit() instead of snprintf.
> ---
>   drivers/acpi/nfit/core.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/acpi/nfit/core.c b/drivers/acpi/nfit/core.c
> index 9213b426b125..d7e9d9cd16d2 100644
> --- a/drivers/acpi/nfit/core.c
> +++ b/drivers/acpi/nfit/core.c
> @@ -1579,7 +1579,7 @@ static ssize_t id_show(struct device *dev,
>   {
>   	struct nfit_mem *nfit_mem = to_nfit_mem(dev);
>   
> -	return sprintf(buf, "%s\n", nfit_mem->id);
> +	return snprintf(buf, PAGE_SIZE, "%s\n", nfit_mem->id);
>   }
>   static DEVICE_ATTR_RO(id);
>   

whoops, forgot to add before hitting ammend...

-- 
Ben Dooks				http://www.codethink.co.uk/
Senior Engineer				Codethink - Providing Genius

https://www.codethink.co.uk/privacy.html


^ permalink raw reply	[flat|nested] 5+ messages in thread
* [PATCH] ACPI: NFIT: limit string attribute write
@ 2023-07-11  9:22 Ben Dooks
  2023-07-11  9:36 ` Ben Dooks
  0 siblings, 1 reply; 5+ messages in thread
From: Ben Dooks @ 2023-07-11  9:22 UTC (permalink / raw)
  To: nvdimm; +Cc: linux-acpi, linux-kernel, lenb, Ben Dooks

If we're writing what could be an arbitrary sized string into an attribute
we should probably use sysfs_emit() just to be safe. Most of the other
attriubtes are some sort of integer so unlikely to be an issue so not
altered at this time.

Signed-off-by: Ben Dooks <ben.dooks@codethink.co.uk>
---
v2:
  - use sysfs_emit() instead of snprintf.
---
 drivers/acpi/nfit/core.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/acpi/nfit/core.c b/drivers/acpi/nfit/core.c
index 9213b426b125..d7e9d9cd16d2 100644
--- a/drivers/acpi/nfit/core.c
+++ b/drivers/acpi/nfit/core.c
@@ -1579,7 +1579,7 @@ static ssize_t id_show(struct device *dev,
 {
 	struct nfit_mem *nfit_mem = to_nfit_mem(dev);
 
-	return sprintf(buf, "%s\n", nfit_mem->id);
+	return snprintf(buf, PAGE_SIZE, "%s\n", nfit_mem->id);
 }
 static DEVICE_ATTR_RO(id);
 
-- 
2.40.1


^ permalink raw reply	[flat|nested] 5+ messages in thread
end of thread, other threads:[~2023-07-11  9:37 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2023-07-04  8:17 [PATCH] ACPI: NFIT: limit string attribute write Ben Dooks
2023-07-05 18:34 ` Dave Jiang
2023-07-11  8:36   ` Ben Dooks
2023-07-11  9:22 Ben Dooks
2023-07-11  9:36 ` Ben Dooks

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®