From: Jacob Keller <jacob.e.keller@intel.com>
To: Andrew Lunn <andrew@lunn.ch>,
Alexander Shalimov <alex-shalimov@yandex-team.ru>
Cc: <netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<willemdebruijn.kernel@gmail.com>, <jasowang@redhat.com>,
<davem@davemloft.net>, <edumazet@google.com>, <kuba@kernel.org>,
<pabeni@redhat.com>
Subject: Re: [PATCH] net/tun: expose queue utilization stats via ethtool
Date: Tue, 6 May 2025 12:00:12 -0700 [thread overview]
Message-ID: <24a121fd-aa4d-43db-8c8c-477bca99a7ae@intel.com> (raw)
In-Reply-To: <c02e519b-8b7d-414c-b602-5575c9382101@lunn.ch>
On 5/6/2025 9:07 AM, Andrew Lunn wrote:
> On Tue, May 06, 2025 at 06:41:17PM +0300, Alexander Shalimov wrote:
>> This patch exposes per-queue utilization statistics via ethtool -S,
>> allowing on-demand inspection of queue fill levels. Utilization metrics are
>> captured at the time of the ethtool invocation, providing a snapshot useful
>> for correlation with guest and host behavior.
>
> This does not fit the usual statistics pattern, which are simple
> incremental counters. Are there any other drivers doing anything like
> this?
I don't recall ever seeing anything like this. If there are, I feel it
is a mistake regardless, and we shouldn't repeat it without good reason.
+1 to looking at another option for reporting.
next prev parent reply other threads:[~2025-05-06 19:01 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-05-06 15:41 Alexander Shalimov
2025-05-06 16:07 ` Andrew Lunn
2025-05-06 19:00 ` Jacob Keller [this message]
2025-05-06 19:32 ` Willem de Bruijn
2025-05-14 23:39 ` Alexander Shalimov
2025-05-15 14:12 ` Willem de Bruijn
2025-05-16 1:56 ` Daniel Xu
2025-05-16 17:22 ` Willem de Bruijn
2025-05-16 20:21 ` Daniel Xu
2025-05-22 14:26 ` Alexander Shalimov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=24a121fd-aa4d-43db-8c8c-477bca99a7ae@intel.com \
--to=jacob.e.keller@intel.com \
--cc=alex-shalimov@yandex-team.ru \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=jasowang@redhat.com \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=willemdebruijn.kernel@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®