From: Andrew Jeffery <andrew@codeconstruct.com.au>
To: Chanh Nguyen <chanh@os.amperecomputing.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Joel Stanley <joel@jms.id.au>, Andrew Jeffery <andrew@aj.id.au>,
devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-aspeed@lists.ozlabs.org, linux-kernel@vger.kernel.org,
OpenBMC Maillist <openbmc@lists.ozlabs.org>,
Open Source Submission <patches@amperecomputing.com>
Cc: Thang Nguyen <thang@os.amperecomputing.com>,
Phong Vo <phong@os.amperecomputing.com>,
Khanh Pham <khpham@amperecomputing.com>,
Quan Nguyen <quan@os.amperecomputing.com>
Subject: Re: [PATCH 1/2] ARM: dts: aspeed: mtmitchell: Add I2C FAN controllers
Date: Thu, 12 Sep 2024 14:04:37 +0930 [thread overview]
Message-ID: <24ab22b5403adb379f942b3dadb8f49b54f28bb0.camel@codeconstruct.com.au> (raw)
In-Reply-To: <20240905063521.319416-2-chanh@os.amperecomputing.com>
On Thu, 2024-09-05 at 06:35 +0000, Chanh Nguyen wrote:
> Add the MAX31790 nodes as i2c fan controllers.
>
> Signed-off-by: Chanh Nguyen <chanh@os.amperecomputing.com>
> ---
> .../boot/dts/aspeed/aspeed-bmc-ampere-mtmitchell.dts | 10 ++++++++++
> 1 file changed, 10 insertions(+)
>
> diff --git a/arch/arm/boot/dts/aspeed/aspeed-bmc-ampere-mtmitchell.dts b/arch/arm/boot/dts/aspeed/aspeed-bmc-ampere-mtmitchell.dts
> index 0295f5adcfbc..da181f9ae820 100644
> --- a/arch/arm/boot/dts/aspeed/aspeed-bmc-ampere-mtmitchell.dts
> +++ b/arch/arm/boot/dts/aspeed/aspeed-bmc-ampere-mtmitchell.dts
> @@ -684,6 +684,16 @@ bmc-ocp0-en-hog {
> line-name = "bmc-ocp0-en-n";
> };
> };
> +
> + fan-controller0@20 {
> + compatible = "maxim,max31790";
> + reg = <0x20>;
> + };
> +
> + fan-controller1@2f {
> + compatible = "maxim,max31790";
> + reg = <0x2f>;
> + };
> };
This generates some warnings based on v6.11-rc1:
Executing: ./scripts/checkpatch.pl --strict -g HEAD
WARNING: DT compatible string "maxim,max31790" appears un-documented -- check ./Documentation/devicetree/bindings/
#25: FILE: arch/arm/boot/dts/aspeed/aspeed-bmc-ampere-mtmitchell.dts:689:
+ compatible = "maxim,max31790";
WARNING: DT compatible string "maxim,max31790" appears un-documented -- check ./Documentation/devicetree/bindings/
#30: FILE: arch/arm/boot/dts/aspeed/aspeed-bmc-ampere-mtmitchell.dts:694:
+ compatible = "maxim,max31790";
total: 0 errors, 2 warnings, 0 checks, 16 lines checked
However, Guenter's applied the binding here:
https://lore.kernel.org/all/3382f952-daae-43ff-bb85-fa4820ecbc5f@roeck-us.net/
`make CHECK_DTBS=y aspeed/aspeed-bmc-ampere-mtmitchell.dtb` didn't turn
up anything interesting after merging in hwmon-next, so I've applied
these to be integrated via the BMC tree.
Andrew
next prev parent reply other threads:[~2024-09-12 4:34 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-09-05 6:35 [PATCH 0/2] Update the device tree for Mt.Mitchell's BMC platform Chanh Nguyen
2024-09-05 6:35 ` [PATCH 1/2] ARM: dts: aspeed: mtmitchell: Add I2C FAN controllers Chanh Nguyen
2024-09-12 4:34 ` Andrew Jeffery [this message]
2024-09-05 6:35 ` [PATCH 2/2] ARM: dts: aspeed: mtmitchell: Add gpio line names for io expanders Chanh Nguyen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=24ab22b5403adb379f942b3dadb8f49b54f28bb0.camel@codeconstruct.com.au \
--to=andrew@codeconstruct.com.au \
--cc=andrew@aj.id.au \
--cc=chanh@os.amperecomputing.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=joel@jms.id.au \
--cc=khpham@amperecomputing.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-aspeed@lists.ozlabs.org \
--cc=linux-kernel@vger.kernel.org \
--cc=openbmc@lists.ozlabs.org \
--cc=patches@amperecomputing.com \
--cc=phong@os.amperecomputing.com \
--cc=quan@os.amperecomputing.com \
--cc=robh+dt@kernel.org \
--cc=thang@os.amperecomputing.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®