[PATCH 0/2] Update the device tree for Mt.Mitchell's BMC platform

[PATCH 0/2] Update the device tree for Mt.Mitchell's BMC platform

[Chanh Nguyen]

Updates the device tree to support some features on Ampere's
Mt.Mitchell BMC.

Chanh Nguyen (2):
  ARM: dts: aspeed: mtmitchell: Add I2C FAN controllers
  ARM: dts: aspeed: mtmitchell: Add gpio line names for io expanders

 .../aspeed/aspeed-bmc-ampere-mtmitchell.dts    | 18 +++++++++++++++++-
 1 file changed, 17 insertions(+), 1 deletion(-)

-- 
2.43.0

[PATCH 1/2] ARM: dts: aspeed: mtmitchell: Add I2C FAN controllers

[Chanh Nguyen]

Add the MAX31790 nodes as i2c fan controllers.

Signed-off-by: Chanh Nguyen <chanh@os.amperecomputing.com>
---
 .../boot/dts/aspeed/aspeed-bmc-ampere-mtmitchell.dts   | 10 ++++++++++
 1 file changed, 10 insertions(+)

diff --git a/arch/arm/boot/dts/aspeed/aspeed-bmc-ampere-mtmitchell.dts b/arch/arm/boot/dts/aspeed/aspeed-bmc-ampere-mtmitchell.dts
index 0295f5adcfbc..da181f9ae820 100644
--- a/arch/arm/boot/dts/aspeed/aspeed-bmc-ampere-mtmitchell.dts
+++ b/arch/arm/boot/dts/aspeed/aspeed-bmc-ampere-mtmitchell.dts
@@ -684,6 +684,16 @@ bmc-ocp0-en-hog {
 			line-name = "bmc-ocp0-en-n";
 		};
 	};
+
+	fan-controller0@20 {
+		compatible = "maxim,max31790";
+		reg = <0x20>;
+	};
+
+	fan-controller1@2f {
+		compatible = "maxim,max31790";
+		reg = <0x2f>;
+	};
 };
 
 &i2c9 {
-- 
2.43.0

Re: [PATCH 1/2] ARM: dts: aspeed: mtmitchell: Add I2C FAN controllers

[Andrew Jeffery]

On Thu, 2024-09-05 at 06:35 +0000, Chanh Nguyen wrote:
> Add the MAX31790 nodes as i2c fan controllers.
> 
> Signed-off-by: Chanh Nguyen <chanh@os.amperecomputing.com>
> ---
>  .../boot/dts/aspeed/aspeed-bmc-ampere-mtmitchell.dts   | 10 ++++++++++
>  1 file changed, 10 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/aspeed/aspeed-bmc-ampere-mtmitchell.dts b/arch/arm/boot/dts/aspeed/aspeed-bmc-ampere-mtmitchell.dts
> index 0295f5adcfbc..da181f9ae820 100644
> --- a/arch/arm/boot/dts/aspeed/aspeed-bmc-ampere-mtmitchell.dts
> +++ b/arch/arm/boot/dts/aspeed/aspeed-bmc-ampere-mtmitchell.dts
> @@ -684,6 +684,16 @@ bmc-ocp0-en-hog {
>  			line-name = "bmc-ocp0-en-n";
>  		};
>  	};
> +
> +	fan-controller0@20 {
> +		compatible = "maxim,max31790";
> +		reg = <0x20>;
> +	};
> +
> +	fan-controller1@2f {
> +		compatible = "maxim,max31790";
> +		reg = <0x2f>;
> +	};
>  };

This generates some warnings based on v6.11-rc1:

Executing: ./scripts/checkpatch.pl --strict -g HEAD                                                                                                            
WARNING: DT compatible string "maxim,max31790" appears un-documented -- check ./Documentation/devicetree/bindings/                                             
#25: FILE: arch/arm/boot/dts/aspeed/aspeed-bmc-ampere-mtmitchell.dts:689:                                                                                      
+               compatible = "maxim,max31790";                                                                                                                 
                                                                                                                                                               
WARNING: DT compatible string "maxim,max31790" appears un-documented -- check ./Documentation/devicetree/bindings/                                             
#30: FILE: arch/arm/boot/dts/aspeed/aspeed-bmc-ampere-mtmitchell.dts:694:                                                                                      
+               compatible = "maxim,max31790";                                                                                                                 
                                                                                                                                                               
total: 0 errors, 2 warnings, 0 checks, 16 lines checked

However, Guenter's applied the binding here:

https://lore.kernel.org/all/3382f952-daae-43ff-bb85-fa4820ecbc5f@roeck-us.net/

`make CHECK_DTBS=y aspeed/aspeed-bmc-ampere-mtmitchell.dtb` didn't turn
up anything interesting after merging in hwmon-next, so I've applied
these to be integrated via the BMC tree.

Andrew

[PATCH 2/2] ARM: dts: aspeed: mtmitchell: Add gpio line names for io expanders

[Chanh Nguyen]

Add below gpio line names to io expanders for more platform features.

- ext-vref-sel
- presence-hdd-bp5-n
- presence-hdd-bp6-n
- bmc-ocp0-en-n
- bmc-ocp1-en-n
- bmc-riser-en-n
- gpi0, gpi1

Signed-off-by: Chanh Nguyen <chanh@os.amperecomputing.com>
---
 arch/arm/boot/dts/aspeed/aspeed-bmc-ampere-mtmitchell.dts | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/aspeed/aspeed-bmc-ampere-mtmitchell.dts b/arch/arm/boot/dts/aspeed/aspeed-bmc-ampere-mtmitchell.dts
index da181f9ae820..2b336aa0146d 100644
--- a/arch/arm/boot/dts/aspeed/aspeed-bmc-ampere-mtmitchell.dts
+++ b/arch/arm/boot/dts/aspeed/aspeed-bmc-ampere-mtmitchell.dts
@@ -677,6 +677,12 @@ gpio@77 {
 		#size-cells = <0>;
 		#gpio-cells = <2>;
 
+		gpio-line-names =
+		"ext-vref-sel","","presence-hdd-bp5-n","presence-hdd-bp6-n",
+		"","bmc-riser-en-n","bmc-ocp1-en-n","bmc-ocp0-en-n",
+		"","","","",
+		"","","","";
+
 		bmc-ocp0-en-hog {
 			gpio-hog;
 			gpios = <7 GPIO_ACTIVE_LOW>;
@@ -968,7 +974,7 @@ gpio_expander1: gpio-expander@22 {
 			"fan-fault","psu-fault",
 			"","",
 			"","",
-			"","",
+			"gpi0","gpi1",
 			"","",
 			"","",
 			"","",
-- 
2.43.0