From: David Ahern <dsahern@gmail.com>
To: Roman Gushchin <guro@fb.com>, netdev@vger.kernel.org
Cc: linux-kernel@vger.kernel.org, kernel-team@fb.com, ast@kernel.org,
daniel@iogearbox.net, jakub.kicinski@netronome.com, kafai@fb.com
Subject: Re: [PATCH net-next 3/5] bpftool: implement cgattach command
Date: Thu, 30 Nov 2017 09:17:17 -0700 [thread overview]
Message-ID: <24b1be13-0f42-7695-7b06-7236b2c0beeb@gmail.com> (raw)
In-Reply-To: <20171130134302.2840-4-guro@fb.com>
On 11/30/17 6:43 AM, Roman Gushchin wrote:
> @@ -75,12 +80,13 @@ static int do_help(int argc, char **argv)
> fprintf(stderr,
> "Usage: %s [OPTIONS] OBJECT { COMMAND | help }\n"
> " %s batch file FILE\n"
> + " %s cgattach FILE CGROUP TYPE\n"
Can you change the order to:
+ " %s cgattach CGROUP TYPE FILE\n"
Makes for better consistency with the detach command in the next patch:
+ " %s cgdetach CGROUP TYPE ID\n"
next prev parent reply other threads:[~2017-11-30 16:17 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-30 13:42 [PATCH net-next 0/5] bpftool: cgroup bpf operations Roman Gushchin
2017-11-30 13:42 ` [PATCH net-next 1/5] libbpf: add ability to guess program type based on section name Roman Gushchin
2017-12-01 10:22 ` Quentin Monnet
2017-12-01 22:46 ` Jakub Kicinski
2017-12-04 12:34 ` Roman Gushchin
2017-12-04 13:12 ` Quentin Monnet
2017-12-04 13:22 ` Roman Gushchin
2017-11-30 13:42 ` [PATCH net-next 2/5] libbpf: prefer global symbols as bpf program name source Roman Gushchin
2017-11-30 13:43 ` [PATCH net-next 3/5] bpftool: implement cgattach command Roman Gushchin
2017-11-30 16:17 ` David Ahern [this message]
2017-11-30 16:44 ` Roman Gushchin
2017-11-30 16:24 ` David Ahern
2017-12-01 3:13 ` Jakub Kicinski
2017-11-30 13:43 ` [PATCH net-next 4/5] bpftool: implement cgdetach command Roman Gushchin
2017-12-01 10:26 ` Quentin Monnet
2017-11-30 13:43 ` [PATCH net-next 5/5] bpftool: implement cglist command Roman Gushchin
2017-12-01 3:04 ` [PATCH net-next 0/5] bpftool: cgroup bpf operations Jakub Kicinski
2017-12-01 17:06 ` Roman Gushchin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=24b1be13-0f42-7695-7b06-7236b2c0beeb@gmail.com \
--to=dsahern@gmail.com \
--cc=ast@kernel.org \
--cc=daniel@iogearbox.net \
--cc=guro@fb.com \
--cc=jakub.kicinski@netronome.com \
--cc=kafai@fb.com \
--cc=kernel-team@fb.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®