From: Joe Perches <joe@perches.com>
To: Lukas Bulwahn <lukas.bulwahn@gmail.com>,
Hamza Mahfooz <someguy@effective-light.com>
Cc: Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Andy Whitcroft <apw@canonical.com>,
Dwaipayan Ray <dwaipayanray1@gmail.com>
Subject: Re: [PATCH] checkpatch: fix an issue regarding the git commit description style test
Date: Sat, 14 Aug 2021 17:47:20 -0700 [thread overview]
Message-ID: <24b9996f43b0cb012022e8dacc6ab2902f7df981.camel@perches.com> (raw)
In-Reply-To: <CAKXUXMy2hutuTP1Z3+wt3AxKuSx1G=vEQb8V4cPeaaba+jBPfA@mail.gmail.com>
On Sat, 2021-08-14 at 10:43 +0200, Lukas Bulwahn wrote:
> On Wed, Jul 14, 2021 at 10:26 AM Hamza Mahfooz
> <someguy@effective-light.com> wrote:
> >
> > If we consider the output of the following command:
> >
> > $ git shortlog | grep '"' | wc -l
> > 14185
> >
> > It becomes apparent that quite a number of commits have titles that,
> > contain at least one quotation mark and if you attempt to refer to those
> > commits in a new patch, checkpatch throws a false positive. This is
> > because, checkpatch disallows the use of quotation marks in commit titles,
> > only when referring to those commits in commit descriptions.
> >
>
> Joe will certainly have the final say on this.
I did suggest a patch.
https://lore.kernel.org/lkml/7f55d9d0369f1ea840fab83eeb77f9f3601fee41.camel@perches.com/
prev parent reply other threads:[~2021-08-15 0:47 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-14 8:26 Hamza Mahfooz
2021-08-13 11:36 ` Hamza Mahfooz
2021-08-14 8:43 ` Lukas Bulwahn
2021-08-15 0:47 ` Joe Perches [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=24b9996f43b0cb012022e8dacc6ab2902f7df981.camel@perches.com \
--to=joe@perches.com \
--cc=apw@canonical.com \
--cc=dwaipayanray1@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lukas.bulwahn@gmail.com \
--cc=someguy@effective-light.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®