* [PATCH] selftests: futex: set DEFAULT_INSTALL_HDR_PATH
@ 2022-01-19 10:33 Muhammad Usama Anjum
2022-02-06 18:56 ` Muhammad Usama Anjum
2022-02-07 18:40 ` Shuah Khan
0 siblings, 2 replies; 5+ messages in thread
From: Muhammad Usama Anjum @ 2022-01-19 10:33 UTC (permalink / raw)
To: Thomas Gleixner, Ingo Molnar, Peter Zijlstra, Darren Hart,
Davidlohr Bueso, André Almeida, Shuah Khan
Cc: Muhammad Usama Anjum, kernel, linux-kernel, linux-kselftest
If only futex selftest is compiled, uapi header files are copied to the
selftests/futex/functional directory. This copy isn't needed. Set the
DEFAULT_INSTALL_HDR_PATH variable to 1 to use the default header install
path only. This removes extra copy of header file.
Signed-off-by: Muhammad Usama Anjum <usama.anjum@collabora.com>
---
tools/testing/selftests/futex/functional/Makefile | 1 +
1 file changed, 1 insertion(+)
diff --git a/tools/testing/selftests/futex/functional/Makefile b/tools/testing/selftests/futex/functional/Makefile
index 5cc38de9d8ea..9a8c3700d773 100644
--- a/tools/testing/selftests/futex/functional/Makefile
+++ b/tools/testing/selftests/futex/functional/Makefile
@@ -24,6 +24,7 @@ TEST_PROGS := run.sh
top_srcdir = ../../../../..
KSFT_KHDR_INSTALL := 1
+DEFAULT_INSTALL_HDR_PATH := 1
include ../../lib.mk
$(TEST_GEN_FILES): $(HEADERS)
--
2.30.2
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] selftests: futex: set DEFAULT_INSTALL_HDR_PATH
2022-01-19 10:33 [PATCH] selftests: futex: set DEFAULT_INSTALL_HDR_PATH Muhammad Usama Anjum
@ 2022-02-06 18:56 ` Muhammad Usama Anjum
2022-02-07 18:40 ` Shuah Khan
1 sibling, 0 replies; 5+ messages in thread
From: Muhammad Usama Anjum @ 2022-02-06 18:56 UTC (permalink / raw)
To: Thomas Gleixner, Ingo Molnar, Peter Zijlstra, Darren Hart,
Davidlohr Bueso, André Almeida, Shuah Khan
Cc: usama.anjum, kernel, linux-kernel, linux-kselftest
Thoughts?
On 1/19/22 3:33 PM, Muhammad Usama Anjum wrote:
> If only futex selftest is compiled, uapi header files are copied to the
> selftests/futex/functional directory. This copy isn't needed. Set the
> DEFAULT_INSTALL_HDR_PATH variable to 1 to use the default header install
> path only. This removes extra copy of header file.
>
> Signed-off-by: Muhammad Usama Anjum <usama.anjum@collabora.com>
> ---
> tools/testing/selftests/futex/functional/Makefile | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/tools/testing/selftests/futex/functional/Makefile b/tools/testing/selftests/futex/functional/Makefile
> index 5cc38de9d8ea..9a8c3700d773 100644
> --- a/tools/testing/selftests/futex/functional/Makefile
> +++ b/tools/testing/selftests/futex/functional/Makefile
> @@ -24,6 +24,7 @@ TEST_PROGS := run.sh
>
> top_srcdir = ../../../../..
> KSFT_KHDR_INSTALL := 1
> +DEFAULT_INSTALL_HDR_PATH := 1
> include ../../lib.mk
>
> $(TEST_GEN_FILES): $(HEADERS)
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] selftests: futex: set DEFAULT_INSTALL_HDR_PATH
2022-01-19 10:33 [PATCH] selftests: futex: set DEFAULT_INSTALL_HDR_PATH Muhammad Usama Anjum
2022-02-06 18:56 ` Muhammad Usama Anjum
@ 2022-02-07 18:40 ` Shuah Khan
2022-02-07 20:50 ` Muhammad Usama Anjum
1 sibling, 1 reply; 5+ messages in thread
From: Shuah Khan @ 2022-02-07 18:40 UTC (permalink / raw)
To: Muhammad Usama Anjum, Thomas Gleixner, Ingo Molnar,
Peter Zijlstra, Darren Hart, Davidlohr Bueso, André Almeida,
Shuah Khan
Cc: kernel, linux-kernel, linux-kselftest, Shuah Khan
On 1/19/22 3:33 AM, Muhammad Usama Anjum wrote:
> If only futex selftest is compiled, uapi header files are copied to the
> selftests/futex/functional directory. This copy isn't needed. Set the
> DEFAULT_INSTALL_HDR_PATH variable to 1 to use the default header install
> path only. This removes extra copy of header file.
>
> Signed-off-by: Muhammad Usama Anjum <usama.anjum@collabora.com>
> ---
> tools/testing/selftests/futex/functional/Makefile | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/tools/testing/selftests/futex/functional/Makefile b/tools/testing/selftests/futex/functional/Makefile
> index 5cc38de9d8ea..9a8c3700d773 100644
> --- a/tools/testing/selftests/futex/functional/Makefile
> +++ b/tools/testing/selftests/futex/functional/Makefile
> @@ -24,6 +24,7 @@ TEST_PROGS := run.sh
>
> top_srcdir = ../../../../..
> KSFT_KHDR_INSTALL := 1
> +DEFAULT_INSTALL_HDR_PATH := 1
> include ../../lib.mk
>
> $(TEST_GEN_FILES): $(HEADERS)
>
This will be a good cleanup. However, please make there is no dependencies
in the futex test sub-dirs on being able to find the headers under futex
I vaguely remember leaving this in place for reason.
thanks,
-- Shuah
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] selftests: futex: set DEFAULT_INSTALL_HDR_PATH
2022-02-07 18:40 ` Shuah Khan
@ 2022-02-07 20:50 ` Muhammad Usama Anjum
2022-02-07 21:31 ` Shuah Khan
0 siblings, 1 reply; 5+ messages in thread
From: Muhammad Usama Anjum @ 2022-02-07 20:50 UTC (permalink / raw)
To: Shuah Khan, Thomas Gleixner, Ingo Molnar, Peter Zijlstra,
Darren Hart, Davidlohr Bueso, André Almeida, Shuah Khan
Cc: usama.anjum, kernel, linux-kernel, linux-kselftest
On 2/7/22 11:40 PM, Shuah Khan wrote:
> On 1/19/22 3:33 AM, Muhammad Usama Anjum wrote:
>> If only futex selftest is compiled, uapi header files are copied to the
>> selftests/futex/functional directory. This copy isn't needed. Set the
>> DEFAULT_INSTALL_HDR_PATH variable to 1 to use the default header install
>> path only. This removes extra copy of header file.
>>
>> Signed-off-by: Muhammad Usama Anjum <usama.anjum@collabora.com>
>> ---
>> tools/testing/selftests/futex/functional/Makefile | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/tools/testing/selftests/futex/functional/Makefile
>> b/tools/testing/selftests/futex/functional/Makefile
>> index 5cc38de9d8ea..9a8c3700d773 100644
>> --- a/tools/testing/selftests/futex/functional/Makefile
>> +++ b/tools/testing/selftests/futex/functional/Makefile
>> @@ -24,6 +24,7 @@ TEST_PROGS := run.sh
>> top_srcdir = ../../../../..
>> KSFT_KHDR_INSTALL := 1
>> +DEFAULT_INSTALL_HDR_PATH := 1
>> include ../../lib.mk
>> $(TEST_GEN_FILES): $(HEADERS)
>>
>
> This will be a good cleanup. However, please make there is no dependencies
> in the futex test sub-dirs on being able to find the headers under futex
>
I've tried the following variations. The build is fine.
cd tools/testing/selftests/futex/functional
make
cd tools/testing/selftests/futex/
make
make -C tools/testing/selftests/
> I vaguely remember leaving this in place for reason.
>
This must have been fixed in previous changes made to the build system.
> thanks,
> -- Shuah
>
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] selftests: futex: set DEFAULT_INSTALL_HDR_PATH
2022-02-07 20:50 ` Muhammad Usama Anjum
@ 2022-02-07 21:31 ` Shuah Khan
0 siblings, 0 replies; 5+ messages in thread
From: Shuah Khan @ 2022-02-07 21:31 UTC (permalink / raw)
To: Muhammad Usama Anjum, Thomas Gleixner, Ingo Molnar,
Peter Zijlstra, Darren Hart, Davidlohr Bueso, André Almeida,
Shuah Khan, Shuah Khan
Cc: kernel, linux-kernel, linux-kselftest
On 2/7/22 1:50 PM, Muhammad Usama Anjum wrote:
> On 2/7/22 11:40 PM, Shuah Khan wrote:
>> On 1/19/22 3:33 AM, Muhammad Usama Anjum wrote:
>>> If only futex selftest is compiled, uapi header files are copied to the
>>> selftests/futex/functional directory. This copy isn't needed. Set the
>>> DEFAULT_INSTALL_HDR_PATH variable to 1 to use the default header install
>>> path only. This removes extra copy of header file.
>>>
>>> Signed-off-by: Muhammad Usama Anjum <usama.anjum@collabora.com>
>>> ---
>>> tools/testing/selftests/futex/functional/Makefile | 1 +
>>> 1 file changed, 1 insertion(+)
>>>
>>> diff --git a/tools/testing/selftests/futex/functional/Makefile
>>> b/tools/testing/selftests/futex/functional/Makefile
>>> index 5cc38de9d8ea..9a8c3700d773 100644
>>> --- a/tools/testing/selftests/futex/functional/Makefile
>>> +++ b/tools/testing/selftests/futex/functional/Makefile
>>> @@ -24,6 +24,7 @@ TEST_PROGS := run.sh
>>> top_srcdir = ../../../../..
>>> KSFT_KHDR_INSTALL := 1
>>> +DEFAULT_INSTALL_HDR_PATH := 1
>>> include ../../lib.mk
>>> $(TEST_GEN_FILES): $(HEADERS)
>>>
>>
>> This will be a good cleanup. However, please make there is no dependencies
>> in the futex test sub-dirs on being able to find the headers under futex
>>
> I've tried the following variations. The build is fine.
>
> cd tools/testing/selftests/futex/functional
> make
>
> cd tools/testing/selftests/futex/
> make
>
> make -C tools/testing/selftests/
>
>> I vaguely remember leaving this in place for reason.
>>
> This must have been fixed in previous changes made to the build system.
>
Thanks for checking. I will apply this in for Linux 5.18-rc1
thanks,
-- Shuah
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2022-02-07 21:31 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-01-19 10:33 [PATCH] selftests: futex: set DEFAULT_INSTALL_HDR_PATH Muhammad Usama Anjum
2022-02-06 18:56 ` Muhammad Usama Anjum
2022-02-07 18:40 ` Shuah Khan
2022-02-07 20:50 ` Muhammad Usama Anjum
2022-02-07 21:31 ` Shuah Khan
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®