* [PATCH] arm64: dts: ti: k3-j722s-evm: Mark eMMC as non removable
@ 2024-05-22 8:36 Bhavya Kapoor
2024-05-23 9:54 ` Vignesh Raghavendra
0 siblings, 1 reply; 3+ messages in thread
From: Bhavya Kapoor @ 2024-05-22 8:36 UTC (permalink / raw)
To: linux-kernel, devicetree
Cc: linux-arm-kernel, conor+dt, krzk+dt, robh, kristo, b-kapoor, jm,
vigneshr, nm
Mark the eMMC module on J722S as non removable since it
is always present on the evm.
Signed-off-by: Bhavya Kapoor <b-kapoor@ti.com>
---
arch/arm64/boot/dts/ti/k3-j722s-evm.dts | 1 +
1 file changed, 1 insertion(+)
diff --git a/arch/arm64/boot/dts/ti/k3-j722s-evm.dts b/arch/arm64/boot/dts/ti/k3-j722s-evm.dts
index bf3c246d13d1..fe810e32cb7a 100644
--- a/arch/arm64/boot/dts/ti/k3-j722s-evm.dts
+++ b/arch/arm64/boot/dts/ti/k3-j722s-evm.dts
@@ -369,6 +369,7 @@ partition@3fc0000 {
&sdhci0 {
disable-wp;
bootph-all;
+ non-removable;
ti,driver-strength-ohm = <50>;
status = "okay";
};
--
2.34.1
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] arm64: dts: ti: k3-j722s-evm: Mark eMMC as non removable
2024-05-22 8:36 [PATCH] arm64: dts: ti: k3-j722s-evm: Mark eMMC as non removable Bhavya Kapoor
@ 2024-05-23 9:54 ` Vignesh Raghavendra
2024-05-24 7:18 ` Bhavya Kapoor
0 siblings, 1 reply; 3+ messages in thread
From: Vignesh Raghavendra @ 2024-05-23 9:54 UTC (permalink / raw)
To: Bhavya Kapoor, linux-kernel, devicetree
Cc: linux-arm-kernel, conor+dt, krzk+dt, robh, kristo, jm, nm
On 22/05/24 14:06, Bhavya Kapoor wrote:
> Mark the eMMC module on J722S as non removable since it
> is always present on the evm.
Nit s/evm/EVM
>
> Signed-off-by: Bhavya Kapoor <b-kapoor@ti.com>
> ---
This needs a Fixes tag?
> arch/arm64/boot/dts/ti/k3-j722s-evm.dts | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm64/boot/dts/ti/k3-j722s-evm.dts b/arch/arm64/boot/dts/ti/k3-j722s-evm.dts
> index bf3c246d13d1..fe810e32cb7a 100644
> --- a/arch/arm64/boot/dts/ti/k3-j722s-evm.dts
> +++ b/arch/arm64/boot/dts/ti/k3-j722s-evm.dts
> @@ -369,6 +369,7 @@ partition@3fc0000 {
> &sdhci0 {
> disable-wp;
> bootph-all;
> + non-removable;
> ti,driver-strength-ohm = <50>;
> status = "okay";
> };
--
Regards
Vignesh
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] arm64: dts: ti: k3-j722s-evm: Mark eMMC as non removable
2024-05-23 9:54 ` Vignesh Raghavendra
@ 2024-05-24 7:18 ` Bhavya Kapoor
0 siblings, 0 replies; 3+ messages in thread
From: Bhavya Kapoor @ 2024-05-24 7:18 UTC (permalink / raw)
To: Vignesh Raghavendra, linux-kernel, devicetree
Cc: linux-arm-kernel, conor+dt, krzk+dt, robh, kristo, jm, nm
On 23/05/24 3:24 pm, Vignesh Raghavendra wrote:
>
> On 22/05/24 14:06, Bhavya Kapoor wrote:
>> Mark the eMMC module on J722S as non removable since it
>> is always present on the evm.
> Nit s/evm/EVM
This definately demands a v2
>
>> Signed-off-by: Bhavya Kapoor <b-kapoor@ti.com>
>> ---
> This needs a Fixes tag?
Hi Vignesh, we are just adding up a property so i assume we should not
need a fixes tag.
We can take reference from how its done in this patch:
https://patchwork.kernel.org/project/linux-samsung-soc/patch/1444927873-15140-7-git-send-email-javier@osg.samsung.com/
>
>> arch/arm64/boot/dts/ti/k3-j722s-evm.dts | 1 +
>> 1 file changed, 1 insertion(+)
>>
>> diff --git a/arch/arm64/boot/dts/ti/k3-j722s-evm.dts b/arch/arm64/boot/dts/ti/k3-j722s-evm.dts
>> index bf3c246d13d1..fe810e32cb7a 100644
>> --- a/arch/arm64/boot/dts/ti/k3-j722s-evm.dts
>> +++ b/arch/arm64/boot/dts/ti/k3-j722s-evm.dts
>> @@ -369,6 +369,7 @@ partition@3fc0000 {
>> &sdhci0 {
>> disable-wp;
>> bootph-all;
>> + non-removable;
>> ti,driver-strength-ohm = <50>;
>> status = "okay";
>> };
>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-05-24 7:19 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-05-22 8:36 [PATCH] arm64: dts: ti: k3-j722s-evm: Mark eMMC as non removable Bhavya Kapoor
2024-05-23 9:54 ` Vignesh Raghavendra
2024-05-24 7:18 ` Bhavya Kapoor
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®