Re: [PATCH] drm/amd/display: Don't warn about vendor infoframe for non-infoframe sinks

[Mario Limonciello <mario.limonciello@amd.com>]

On 10/27/26 16:32, Paul Menzel wrote:
> Dear Mario,
> 
> 
> Thank you for you reply.
> 
> Am 27.10.26 um 21:48 schrieb Mario Limonciello:
>>
>>
>> On 10/27/26 13:54, Paul Menzel wrote:
>>> With an EIZO EV2781 connected over HDMI to an AMD Ryzen 3 2200G (Raven)
>>> on an MSI B350M MORTAR (MS-7A37), Linux logs at every boot since v6.16:
>>>
>>>      amdgpu 0000:30:00.0: [drm] Failed to setup vendor infoframe on 
>>> connector HDMI-A-1: -22
>>>
>>> Commit 6027cbee1900 ("drm/amd/display: Add error check for avi and
>>> vendor infoframe setup function") started to log the return value of
>>> drm_hdmi_vendor_infoframe_from_display_mode(). With `frame` and `mode`
>>> being non-NULL, the helper only fails with -EINVAL, if the sink does
>>> not support HDMI infoframes, that means, if
>>> `connector->display_info.has_hdmi_infoframe` is false, and its
>>> kernel-doc says, that this error can be safely ignored.
>>> drm_parse_hdmi_vsdb_video() only sets `has_hdmi_infoframe`, if the HDMI
>>> VSDB has HDMI_Video_present set, and drm_parse_hdmi_forum_scds() sets
>>> it for sinks with an HF-SCDB. So an HDMI sink, whose VSDB lacks
>>> HDMI_Video_present, triggers the warning, although nothing failed.
>>>
>>> The EIZO EV2781 is such a sink. Its HDMI VSDB has a payload of only
>>> seven bytes (source physical address, Supports_AI, and a maximum TMDS
>>> clock of 250 MHz), so the byte with HDMI_Video_present is absent, and
>>> the EDID has no HF-SCDB:
>>>
>>>      67 03 0c 00 10 00 80 32
>>>
>>> Only warn, if the sink supports HDMI infoframes. The infoframe setup
>>> itself is unchanged.
>>>
>>> Fixes: 6027cbee1900 ("drm/amd/display: Add error check for avi and 
>>> vendor infoframe setup function")
>>> Closes: https://gitlab.freedesktop.org/drm/amd/-/work_items/5025
>>> ---
>>>
>>> Notes:
>>>
>>> claude-opus-5-5 (Claude Code) assisted in analysis, code change and
>>> commit message.
>>>
>>>   drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_connector.c | 3 ++-
>>>   1 file changed, 2 insertions(+), 1 deletion(-)
> 
> […]
> 
>> The actual change looks reasonable to me.  But a few things about your 
>> commit message you'll need to change.
>>
>> 1) You are missing a S-o-b [1]
> 
> Sorry, overlooked.
> 
>> 2) Disclosing LLM should currently be done by
>> "Assisted-by: LLM" [2]
> 
> Since commit 1e035297ffdadf (docs: remove Assisted-by references) it 
> seems to be deprecated:
> 
> $ scripts/checkpatch.pl 0001-drm-amd-display-Don-t-warn-about-vendor- 
> infoframe-fo.patch
> […]
> WARNING: Non-standard signature: Assisted-by:
> #35:
> Assisted-by: LLM
> 
> ERROR: Unrecognized email address: 'LLM'
> #35:
> Assisted-by: LLM
> 
> I wanted to send v3 with the tag added, but would refrain from it now, 
> if that’s alright with you.
> 
> 
Yeah; just send an updated version with your own SoB then.