mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH] drm/amd/display: Don't warn about vendor infoframe for non-infoframe sinks
@ 2026-10-27 18:54 Paul Menzel
  2026-10-27 20:48 ` Mario Limonciello
  2026-10-27 20:49 ` Deucher, Alexander
  0 siblings, 2 replies; 5+ messages in thread
From: Paul Menzel @ 2026-10-27 18:54 UTC (permalink / raw)
  To: Harry Wentland, Leo Li, Rodrigo Siqueira, Alex Deucher,
	Christian König, David Airlie, Simona Vetter, Wentao Liang,
	Alex Hung
  Cc: Paul Menzel, amd-gfx, dri-devel, linux-kernel

With an EIZO EV2781 connected over HDMI to an AMD Ryzen 3 2200G (Raven)
on an MSI B350M MORTAR (MS-7A37), Linux logs at every boot since v6.16:

    amdgpu 0000:30:00.0: [drm] Failed to setup vendor infoframe on connector HDMI-A-1: -22

Commit 6027cbee1900 ("drm/amd/display: Add error check for avi and
vendor infoframe setup function") started to log the return value of
drm_hdmi_vendor_infoframe_from_display_mode(). With `frame` and `mode`
being non-NULL, the helper only fails with -EINVAL, if the sink does
not support HDMI infoframes, that means, if
`connector->display_info.has_hdmi_infoframe` is false, and its
kernel-doc says, that this error can be safely ignored.
drm_parse_hdmi_vsdb_video() only sets `has_hdmi_infoframe`, if the HDMI
VSDB has HDMI_Video_present set, and drm_parse_hdmi_forum_scds() sets
it for sinks with an HF-SCDB. So an HDMI sink, whose VSDB lacks
HDMI_Video_present, triggers the warning, although nothing failed.

The EIZO EV2781 is such a sink. Its HDMI VSDB has a payload of only
seven bytes (source physical address, Supports_AI, and a maximum TMDS
clock of 250 MHz), so the byte with HDMI_Video_present is absent, and
the EDID has no HF-SCDB:

    67 03 0c 00 10 00 80 32

Only warn, if the sink supports HDMI infoframes. The infoframe setup
itself is unchanged.

Fixes: 6027cbee1900 ("drm/amd/display: Add error check for avi and vendor infoframe setup function")
Closes: https://gitlab.freedesktop.org/drm/amd/-/work_items/5025
---

Notes:

claude-opus-5-5 (Claude Code) assisted in analysis, code change and
commit message.

 drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_connector.c | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_connector.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_connector.c
index ded8e21897f1c..636dd2dedd73d 100644
--- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_connector.c
+++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_connector.c
@@ -941,7 +941,8 @@ STATIC_IFN_KUNIT void fill_stream_properties_from_drm_display_mode(
 		err = drm_hdmi_vendor_infoframe_from_display_mode(&hv_frame,
 								  (struct drm_connector *)connector,
 								  mode_in);
-		if (err < 0)
+		/* Sinks without HDMI infoframe support make it fail with -EINVAL. */
+		if (err < 0 && info->has_hdmi_infoframe)
 			drm_warn_once(connector->dev, "Failed to setup vendor infoframe on connector %s: %zd\n",
 				      connector->name, err);
 		timing_out->hdmi_vic = hv_frame.vic;

base-commit: 77f548b127c6de34ce271fa09ba270cb1ef9f2da
-- 
2.54.0


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] drm/amd/display: Don't warn about vendor infoframe for non-infoframe sinks
  2026-10-27 18:54 [PATCH] drm/amd/display: Don't warn about vendor infoframe for non-infoframe sinks Paul Menzel
@ 2026-10-27 20:48 ` Mario Limonciello
  2026-10-27 21:32   ` Paul Menzel
  2026-10-27 20:49 ` Deucher, Alexander
  1 sibling, 1 reply; 5+ messages in thread
From: Mario Limonciello @ 2026-10-27 20:48 UTC (permalink / raw)
  To: Paul Menzel, Harry Wentland, Leo Li, Rodrigo Siqueira,
	Alex Deucher, Christian König, David Airlie, Simona Vetter,
	Wentao Liang, Alex Hung
  Cc: amd-gfx, dri-devel, linux-kernel



On 10/27/26 13:54, Paul Menzel wrote:
> With an EIZO EV2781 connected over HDMI to an AMD Ryzen 3 2200G (Raven)
> on an MSI B350M MORTAR (MS-7A37), Linux logs at every boot since v6.16:
> 
>      amdgpu 0000:30:00.0: [drm] Failed to setup vendor infoframe on connector HDMI-A-1: -22
> 
> Commit 6027cbee1900 ("drm/amd/display: Add error check for avi and
> vendor infoframe setup function") started to log the return value of
> drm_hdmi_vendor_infoframe_from_display_mode(). With `frame` and `mode`
> being non-NULL, the helper only fails with -EINVAL, if the sink does
> not support HDMI infoframes, that means, if
> `connector->display_info.has_hdmi_infoframe` is false, and its
> kernel-doc says, that this error can be safely ignored.
> drm_parse_hdmi_vsdb_video() only sets `has_hdmi_infoframe`, if the HDMI
> VSDB has HDMI_Video_present set, and drm_parse_hdmi_forum_scds() sets
> it for sinks with an HF-SCDB. So an HDMI sink, whose VSDB lacks
> HDMI_Video_present, triggers the warning, although nothing failed.
> 
> The EIZO EV2781 is such a sink. Its HDMI VSDB has a payload of only
> seven bytes (source physical address, Supports_AI, and a maximum TMDS
> clock of 250 MHz), so the byte with HDMI_Video_present is absent, and
> the EDID has no HF-SCDB:
> 
>      67 03 0c 00 10 00 80 32
> 
> Only warn, if the sink supports HDMI infoframes. The infoframe setup
> itself is unchanged.
> 
> Fixes: 6027cbee1900 ("drm/amd/display: Add error check for avi and vendor infoframe setup function")
> Closes: https://gitlab.freedesktop.org/drm/amd/-/work_items/5025
> ---
> 
> Notes:
> 
> claude-opus-5-5 (Claude Code) assisted in analysis, code change and
> commit message.
> 
>   drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_connector.c | 3 ++-
>   1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_connector.c b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_connector.c
> index ded8e21897f1c..636dd2dedd73d 100644
> --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_connector.c
> +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_connector.c
> @@ -941,7 +941,8 @@ STATIC_IFN_KUNIT void fill_stream_properties_from_drm_display_mode(
>   		err = drm_hdmi_vendor_infoframe_from_display_mode(&hv_frame,
>   								  (struct drm_connector *)connector,
>   								  mode_in);
> -		if (err < 0)
> +		/* Sinks without HDMI infoframe support make it fail with -EINVAL. */
> +		if (err < 0 && info->has_hdmi_infoframe)
>   			drm_warn_once(connector->dev, "Failed to setup vendor infoframe on connector %s: %zd\n",
>   				      connector->name, err);
>   		timing_out->hdmi_vic = hv_frame.vic;
> 
> base-commit: 77f548b127c6de34ce271fa09ba270cb1ef9f2da

The actual change looks reasonable to me.  But a few things about your 
commit message you'll need to change.

1) You are missing a S-o-b [1]
2) Disclosing LLM should currently be done by
"Assisted-by: LLM" [2]

https://docs.kernel.org/process/coding-assistants.html#signed-off-by-and-developer-certificate-of-origin 
[1]
https://docs.kernel.org/process/coding-assistants.html#attribution [2]


^ permalink raw reply	[flat|nested] 5+ messages in thread

* RE: [PATCH] drm/amd/display: Don't warn about vendor infoframe for non-infoframe sinks
  2026-10-27 18:54 [PATCH] drm/amd/display: Don't warn about vendor infoframe for non-infoframe sinks Paul Menzel
  2026-10-27 20:48 ` Mario Limonciello
@ 2026-10-27 20:49 ` Deucher, Alexander
  1 sibling, 0 replies; 5+ messages in thread
From: Deucher, Alexander @ 2026-10-27 20:49 UTC (permalink / raw)
  To: Paul Menzel, Wentland, Harry, Li, Sun peng (Leo),
	Rodrigo Siqueira, Koenig, Christian, David Airlie, Simona Vetter,
	Wentao Liang, Hung, Alex
  Cc: amd-gfx, dri-devel, linux-kernel

Public

> -----Original Message-----
> From: Paul Menzel <pmenzel@molgen.mpg.de>
> Sent: Tuesday, October 27, 2026 2:54 PM
> To: Wentland, Harry <Harry.Wentland@amd.com>; Li, Sun peng (Leo)
> <Sunpeng.Li@amd.com>; Rodrigo Siqueira <siqueira@igalia.com>; Deucher,
> Alexander <Alexander.Deucher@amd.com>; Koenig, Christian
> <Christian.Koenig@amd.com>; David Airlie <airlied@gmail.com>; Simona
> Vetter <simona@ffwll.ch>; Wentao Liang <vulab@iscas.ac.cn>; Hung, Alex
> <Alex.Hung@amd.com>
> Cc: Paul Menzel <pmenzel@molgen.mpg.de>; amd-gfx@lists.freedesktop.org;
> dri-devel@lists.freedesktop.org; linux-kernel@vger.kernel.org
> Subject: [PATCH] drm/amd/display: Don't warn about vendor infoframe for non-
> infoframe sinks
>
> With an EIZO EV2781 connected over HDMI to an AMD Ryzen 3 2200G (Raven)
> on an MSI B350M MORTAR (MS-7A37), Linux logs at every boot since v6.16:
>
>     amdgpu 0000:30:00.0: [drm] Failed to setup vendor infoframe on connector
> HDMI-A-1: -22
>
> Commit 6027cbee1900 ("drm/amd/display: Add error check for avi and vendor
> infoframe setup function") started to log the return value of
> drm_hdmi_vendor_infoframe_from_display_mode(). With `frame` and `mode`
> being non-NULL, the helper only fails with -EINVAL, if the sink does not support
> HDMI infoframes, that means, if `connector->display_info.has_hdmi_infoframe`
> is false, and its kernel-doc says, that this error can be safely ignored.
> drm_parse_hdmi_vsdb_video() only sets `has_hdmi_infoframe`, if the HDMI
> VSDB has HDMI_Video_present set, and drm_parse_hdmi_forum_scds() sets it
> for sinks with an HF-SCDB. So an HDMI sink, whose VSDB lacks
> HDMI_Video_present, triggers the warning, although nothing failed.
>
> The EIZO EV2781 is such a sink. Its HDMI VSDB has a payload of only seven
> bytes (source physical address, Supports_AI, and a maximum TMDS clock of 250
> MHz), so the byte with HDMI_Video_present is absent, and the EDID has no HF-
> SCDB:
>
>     67 03 0c 00 10 00 80 32
>
> Only warn, if the sink supports HDMI infoframes. The infoframe setup itself is
> unchanged.
>
> Fixes: 6027cbee1900 ("drm/amd/display: Add error check for avi and vendor
> infoframe setup function")
> Closes: https://gitlab.freedesktop.org/drm/amd/-/work_items/5025

Missing your S-o-b.

Alex


> ---
>
> Notes:
>
> claude-opus-5-5 (Claude Code) assisted in analysis, code change and commit
> message.
>
>  drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_connector.c | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git
> a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_connector.c
> b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_connector.c
> index ded8e21897f1c..636dd2dedd73d 100644
> --- a/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_connector.c
> +++ b/drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_connector.c
> @@ -941,7 +941,8 @@ STATIC_IFN_KUNIT void
> fill_stream_properties_from_drm_display_mode(
>               err =
> drm_hdmi_vendor_infoframe_from_display_mode(&hv_frame,
>                                                                 (struct
> drm_connector *)connector,
>                                                                 mode_in);
> -             if (err < 0)
> +             /* Sinks without HDMI infoframe support make it fail with -
> EINVAL. */
> +             if (err < 0 && info->has_hdmi_infoframe)
>                       drm_warn_once(connector->dev, "Failed to setup
> vendor infoframe on connector %s: %zd\n",
>                                     connector->name, err);
>               timing_out->hdmi_vic = hv_frame.vic;
>
> base-commit: 77f548b127c6de34ce271fa09ba270cb1ef9f2da
> --
> 2.54.0


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] drm/amd/display: Don't warn about vendor infoframe for non-infoframe sinks
  2026-10-27 20:48 ` Mario Limonciello
@ 2026-10-27 21:32   ` Paul Menzel
  2026-10-27 21:39     ` Mario Limonciello
  0 siblings, 1 reply; 5+ messages in thread
From: Paul Menzel @ 2026-10-27 21:32 UTC (permalink / raw)
  To: Mario Limonciello
  Cc: Harry Wentland, Leo Li, Rodrigo Siqueira, Alex Deucher,
	Christian König, David Airlie, Simona Vetter, Wentao Liang,
	Alex Hung, amd-gfx, dri-devel, linux-kernel

Dear Mario,


Thank you for you reply.

Am 27.10.26 um 21:48 schrieb Mario Limonciello:
> 
> 
> On 10/27/26 13:54, Paul Menzel wrote:
>> With an EIZO EV2781 connected over HDMI to an AMD Ryzen 3 2200G (Raven)
>> on an MSI B350M MORTAR (MS-7A37), Linux logs at every boot since v6.16:
>>
>>      amdgpu 0000:30:00.0: [drm] Failed to setup vendor infoframe on 
>> connector HDMI-A-1: -22
>>
>> Commit 6027cbee1900 ("drm/amd/display: Add error check for avi and
>> vendor infoframe setup function") started to log the return value of
>> drm_hdmi_vendor_infoframe_from_display_mode(). With `frame` and `mode`
>> being non-NULL, the helper only fails with -EINVAL, if the sink does
>> not support HDMI infoframes, that means, if
>> `connector->display_info.has_hdmi_infoframe` is false, and its
>> kernel-doc says, that this error can be safely ignored.
>> drm_parse_hdmi_vsdb_video() only sets `has_hdmi_infoframe`, if the HDMI
>> VSDB has HDMI_Video_present set, and drm_parse_hdmi_forum_scds() sets
>> it for sinks with an HF-SCDB. So an HDMI sink, whose VSDB lacks
>> HDMI_Video_present, triggers the warning, although nothing failed.
>>
>> The EIZO EV2781 is such a sink. Its HDMI VSDB has a payload of only
>> seven bytes (source physical address, Supports_AI, and a maximum TMDS
>> clock of 250 MHz), so the byte with HDMI_Video_present is absent, and
>> the EDID has no HF-SCDB:
>>
>>      67 03 0c 00 10 00 80 32
>>
>> Only warn, if the sink supports HDMI infoframes. The infoframe setup
>> itself is unchanged.
>>
>> Fixes: 6027cbee1900 ("drm/amd/display: Add error check for avi and 
>> vendor infoframe setup function")
>> Closes: https://gitlab.freedesktop.org/drm/amd/-/work_items/5025
>> ---
>>
>> Notes:
>>
>> claude-opus-5-5 (Claude Code) assisted in analysis, code change and
>> commit message.
>>
>>   drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_connector.c | 3 ++-
>>   1 file changed, 2 insertions(+), 1 deletion(-)

[…]

> The actual change looks reasonable to me.  But a few things about your 
> commit message you'll need to change.
> 
> 1) You are missing a S-o-b [1]

Sorry, overlooked.

> 2) Disclosing LLM should currently be done by
> "Assisted-by: LLM" [2]

Since commit 1e035297ffdadf (docs: remove Assisted-by references) it 
seems to be deprecated:

$ scripts/checkpatch.pl 
0001-drm-amd-display-Don-t-warn-about-vendor-infoframe-fo.patch
[…]
WARNING: Non-standard signature: Assisted-by:
#35:
Assisted-by: LLM

ERROR: Unrecognized email address: 'LLM'
#35:
Assisted-by: LLM

I wanted to send v3 with the tag added, but would refrain from it now, 
if that’s alright with you.


Kind regards,

Paul


> https://docs.kernel.org/process/coding-assistants.html#signed-off-by- 
> and-developer-certificate-of-origin [1]
> https://docs.kernel.org/process/coding-assistants.html#attribution [2]

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH] drm/amd/display: Don't warn about vendor infoframe for non-infoframe sinks
  2026-10-27 21:32   ` Paul Menzel
@ 2026-10-27 21:39     ` Mario Limonciello
  0 siblings, 0 replies; 5+ messages in thread
From: Mario Limonciello @ 2026-10-27 21:39 UTC (permalink / raw)
  To: Paul Menzel
  Cc: Harry Wentland, Leo Li, Rodrigo Siqueira, Alex Deucher,
	Christian König, David Airlie, Simona Vetter, Wentao Liang,
	Alex Hung, amd-gfx, dri-devel, linux-kernel



On 10/27/26 16:32, Paul Menzel wrote:
> Dear Mario,
> 
> 
> Thank you for you reply.
> 
> Am 27.10.26 um 21:48 schrieb Mario Limonciello:
>>
>>
>> On 10/27/26 13:54, Paul Menzel wrote:
>>> With an EIZO EV2781 connected over HDMI to an AMD Ryzen 3 2200G (Raven)
>>> on an MSI B350M MORTAR (MS-7A37), Linux logs at every boot since v6.16:
>>>
>>>      amdgpu 0000:30:00.0: [drm] Failed to setup vendor infoframe on 
>>> connector HDMI-A-1: -22
>>>
>>> Commit 6027cbee1900 ("drm/amd/display: Add error check for avi and
>>> vendor infoframe setup function") started to log the return value of
>>> drm_hdmi_vendor_infoframe_from_display_mode(). With `frame` and `mode`
>>> being non-NULL, the helper only fails with -EINVAL, if the sink does
>>> not support HDMI infoframes, that means, if
>>> `connector->display_info.has_hdmi_infoframe` is false, and its
>>> kernel-doc says, that this error can be safely ignored.
>>> drm_parse_hdmi_vsdb_video() only sets `has_hdmi_infoframe`, if the HDMI
>>> VSDB has HDMI_Video_present set, and drm_parse_hdmi_forum_scds() sets
>>> it for sinks with an HF-SCDB. So an HDMI sink, whose VSDB lacks
>>> HDMI_Video_present, triggers the warning, although nothing failed.
>>>
>>> The EIZO EV2781 is such a sink. Its HDMI VSDB has a payload of only
>>> seven bytes (source physical address, Supports_AI, and a maximum TMDS
>>> clock of 250 MHz), so the byte with HDMI_Video_present is absent, and
>>> the EDID has no HF-SCDB:
>>>
>>>      67 03 0c 00 10 00 80 32
>>>
>>> Only warn, if the sink supports HDMI infoframes. The infoframe setup
>>> itself is unchanged.
>>>
>>> Fixes: 6027cbee1900 ("drm/amd/display: Add error check for avi and 
>>> vendor infoframe setup function")
>>> Closes: https://gitlab.freedesktop.org/drm/amd/-/work_items/5025
>>> ---
>>>
>>> Notes:
>>>
>>> claude-opus-5-5 (Claude Code) assisted in analysis, code change and
>>> commit message.
>>>
>>>   drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm_connector.c | 3 ++-
>>>   1 file changed, 2 insertions(+), 1 deletion(-)
> 
> […]
> 
>> The actual change looks reasonable to me.  But a few things about your 
>> commit message you'll need to change.
>>
>> 1) You are missing a S-o-b [1]
> 
> Sorry, overlooked.
> 
>> 2) Disclosing LLM should currently be done by
>> "Assisted-by: LLM" [2]
> 
> Since commit 1e035297ffdadf (docs: remove Assisted-by references) it 
> seems to be deprecated:
> 
> $ scripts/checkpatch.pl 0001-drm-amd-display-Don-t-warn-about-vendor- 
> infoframe-fo.patch
> […]
> WARNING: Non-standard signature: Assisted-by:
> #35:
> Assisted-by: LLM
> 
> ERROR: Unrecognized email address: 'LLM'
> #35:
> Assisted-by: LLM
> 
> I wanted to send v3 with the tag added, but would refrain from it now, 
> if that’s alright with you.
> 
> 
Yeah; just send an updated version with your own SoB then.

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2026-10-27 21:39 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-10-27 18:54 [PATCH] drm/amd/display: Don't warn about vendor infoframe for non-infoframe sinks Paul Menzel
2026-10-27 20:48 ` Mario Limonciello
2026-10-27 21:32   ` Paul Menzel
2026-10-27 21:39     ` Mario Limonciello
2026-10-27 20:49 ` Deucher, Alexander

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®