mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH v2] soc: qcom: geni-se: allow selection on 32-bit ARM Qualcomm SoCs
@ 2026-07-29  9:34 Hardeep Sharma
  2026-07-29 10:00 ` Krzysztof Kozlowski
  0 siblings, 1 reply; 5+ messages in thread
From: Hardeep Sharma @ 2026-07-29  9:34 UTC (permalink / raw)
  To: Bjorn Andersson, Konrad Dybcio, Krzysztof Kozlowski
  Cc: kernel, kernel, linux-arm-msm, linux-kernel, Hardeep Sharma

Commit e10b198a94c6 ("soc: qcom: Restrict drivers per ARM/ARM64")
tightened QCOM_GENI_SE's dependency to ARM64 || COMPILE_TEST on the
assumption that no ARMv7 Qualcomm SoC uses the GENI Serial Engine
hardware.

Kuno, a 32-bit ARM Cortex-A7 Qualcomm SoC, uses the GENI-based QUP
wrapper for its debug UART, so this assumption no longer holds.

Fixes: e10b198a94c6 ("soc: qcom: Restrict drivers per ARM/ARM64")
Signed-off-by: Hardeep Sharma <hardeep.sharma@oss.qualcomm.com>
---
Changes in v2:
- No functional changes; resend to correct the cover-letter changelog,
  which shipped as unedited placeholder text in v1.
- Link to v1: https://lore.kernel.org/all/20260729-qcom-geni-se-armv7-v1-1-cf90f050cf0c@oss.qualcomm.com/
---
 drivers/soc/qcom/Kconfig | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/soc/qcom/Kconfig b/drivers/soc/qcom/Kconfig
index fd4d4ecd2df0..5b3c9d31fd7f 100644
--- a/drivers/soc/qcom/Kconfig
+++ b/drivers/soc/qcom/Kconfig
@@ -39,7 +39,6 @@ config QCOM_COMMAND_DB
 
 config QCOM_GENI_SE
 	tristate "Qualcomm GENI Serial Engine Driver"
-	depends on ARM64 || COMPILE_TEST
 	default ARCH_QCOM
 	help
 	  This driver is used to manage Generic Interface (GENI) firmware based

---
base-commit: 9c6fc9be717cf3558710a958d0d16ab9c39314d8
change-id: 20260728-qcom-geni-se-armv7-f7b311ec9e63

Best regards,
--  
Hardeep Sharma <hardeep.sharma@oss.qualcomm.com>


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH v2] soc: qcom: geni-se: allow selection on 32-bit ARM Qualcomm SoCs
  2026-07-29  9:34 [PATCH v2] soc: qcom: geni-se: allow selection on 32-bit ARM Qualcomm SoCs Hardeep Sharma
@ 2026-07-29 10:00 ` Krzysztof Kozlowski
  2026-07-29 10:28   ` Hardeep Sharma
  0 siblings, 1 reply; 5+ messages in thread
From: Krzysztof Kozlowski @ 2026-07-29 10:00 UTC (permalink / raw)
  To: Hardeep Sharma, Bjorn Andersson, Konrad Dybcio
  Cc: kernel, kernel, linux-arm-msm, linux-kernel

On 29/07/2026 11:34, Hardeep Sharma wrote:
> Commit e10b198a94c6 ("soc: qcom: Restrict drivers per ARM/ARM64")
> tightened QCOM_GENI_SE's dependency to ARM64 || COMPILE_TEST on the
> assumption that no ARMv7 Qualcomm SoC uses the GENI Serial Engine
> hardware.
> 
> Kuno, a 32-bit ARM Cortex-A7 Qualcomm SoC, uses the GENI-based QUP
> wrapper for its debug UART, so this assumption no longer holds.

This gives me nothing:
$ git grep kuno

Are you sure you organized your patches correctly?

Best regards,
Krzysztof

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH v2] soc: qcom: geni-se: allow selection on 32-bit ARM Qualcomm SoCs
  2026-07-29 10:00 ` Krzysztof Kozlowski
@ 2026-07-29 10:28   ` Hardeep Sharma
  2026-07-29 10:45     ` Krzysztof Kozlowski
  0 siblings, 1 reply; 5+ messages in thread
From: Hardeep Sharma @ 2026-07-29 10:28 UTC (permalink / raw)
  To: Krzysztof Kozlowski, Bjorn Andersson, Konrad Dybcio
  Cc: kernel, kernel, linux-arm-msm, linux-kernel


On 7/29/2026 3:30 PM, Krzysztof Kozlowski wrote:
> This gives me nothing:
> $ git grep kuno
>
> Are you sure you organized your patches correctly?
>
> Best regards,
> Krzysztof
Hi Krzysztof,

You're right — the Kuno support series isn't upstream yet.

I'm planning to upstream the Kuno support series shortly, and this
Kconfig fix is a prerequisite for it (without it, QCOM_GENI_SE — and
therefore the debug UART — is unselectable on 32-bit ARM).

What would you suggest — should I fold this fix into the Kuno
series as patch 1, or keep it standalone and let the kuno series
depend on it?

Thanks,
Hardeep Sharma

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH v2] soc: qcom: geni-se: allow selection on 32-bit ARM Qualcomm SoCs
  2026-07-29 10:28   ` Hardeep Sharma
@ 2026-07-29 10:45     ` Krzysztof Kozlowski
  2026-07-29 10:48       ` Krzysztof Kozlowski
  0 siblings, 1 reply; 5+ messages in thread
From: Krzysztof Kozlowski @ 2026-07-29 10:45 UTC (permalink / raw)
  To: Hardeep Sharma, Bjorn Andersson, Konrad Dybcio
  Cc: kernel, kernel, linux-arm-msm, linux-kernel

On 29/07/2026 12:28, Hardeep Sharma wrote:
> 
> On 7/29/2026 3:30 PM, Krzysztof Kozlowski wrote:
>> This gives me nothing:
>> $ git grep kuno
>>
>> Are you sure you organized your patches correctly?
>>
>> Best regards,
>> Krzysztof
> Hi Krzysztof,
> 
> You're right — the Kuno support series isn't upstream yet.
> 
> I'm planning to upstream the Kuno support series shortly, and this
> Kconfig fix is a prerequisite for it (without it, QCOM_GENI_SE — and
> therefore the debug UART — is unselectable on 32-bit ARM).

It is not a prerequisite if there is no Kuno.

> 
> What would you suggest — should I fold this fix into the Kuno
> series as patch 1, or keep it standalone and let the kuno series
> depend on it?

Organize your work in logical chunks, please read submitting patches. We
also discussed this many times in internal forums/chats. Even discussing
EXACTLY now.

Best regards,
Krzysztof

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH v2] soc: qcom: geni-se: allow selection on 32-bit ARM Qualcomm SoCs
  2026-07-29 10:45     ` Krzysztof Kozlowski
@ 2026-07-29 10:48       ` Krzysztof Kozlowski
  0 siblings, 0 replies; 5+ messages in thread
From: Krzysztof Kozlowski @ 2026-07-29 10:48 UTC (permalink / raw)
  To: Hardeep Sharma, Bjorn Andersson, Konrad Dybcio
  Cc: kernel, kernel, linux-arm-msm, linux-kernel

On 29/07/2026 12:45, Krzysztof Kozlowski wrote:
> On 29/07/2026 12:28, Hardeep Sharma wrote:
>>
>> On 7/29/2026 3:30 PM, Krzysztof Kozlowski wrote:
>>> This gives me nothing:
>>> $ git grep kuno
>>>
>>> Are you sure you organized your patches correctly?
>>>
>>> Best regards,
>>> Krzysztof
>> Hi Krzysztof,
>>
>> You're right — the Kuno support series isn't upstream yet.
>>
>> I'm planning to upstream the Kuno support series shortly, and this


And why are you Cc-ing here kernel@quicinc.com and
kernel@oss.qualcomm.com? That's complete mixup of recipients.

Please use scripts/get_maintainers.pl to get a list of necessary people
and lists to CC (and consider --no-git-fallback argument, so you will
not CC people just because they made one commit years ago). It might
happen, that command when run on an older kernel, gives you outdated
entries. Therefore please be sure you base your patches on recent Linux
kernel.

Tools like b4 or scripts/get_maintainer.pl provide you proper list of
people, so fix your workflow. Tools might also fail if you work on some
ancient tree (don't, instead use mainline) or work on fork of kernel
(don't, instead use mainline). Just use b4 and everything should be
fine, although remember about `b4 prep --auto-to-cc` if you added new
patches to the patchset.

Best regards,
Krzysztof

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2026-07-29 10:48 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-07-29  9:34 [PATCH v2] soc: qcom: geni-se: allow selection on 32-bit ARM Qualcomm SoCs Hardeep Sharma
2026-07-29 10:00 ` Krzysztof Kozlowski
2026-07-29 10:28   ` Hardeep Sharma
2026-07-29 10:45     ` Krzysztof Kozlowski
2026-07-29 10:48       ` Krzysztof Kozlowski

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®