* Re: [PATCH v7 1/2] drm/mediatek: change mmsys compatible for mt8195 mediatek-drm
[not found] ` <20221227074759.5216-2-jason-jh.lin@mediatek.com>
@ 2023-02-22 10:44 ` AngeloGioacchino Del Regno
2023-03-06 9:33 ` Jason-JH Lin (林睿祥)
0 siblings, 1 reply; 2+ messages in thread
From: AngeloGioacchino Del Regno @ 2023-02-22 10:44 UTC (permalink / raw)
To: Jason-JH.Lin, Chun-Kuang Hu
Cc: Matthias Brugger, Rex-BC Chen, Singo Chang, Nancy Lin, Nathan Lu,
dri-devel, linux-mediatek, linux-arm-kernel, linux-kernel,
Project_Global_Chrome_Upstream_Group
Il 27/12/22 08:47, Jason-JH.Lin ha scritto:
> Because compatible of mt8195 is changing from "mediatek,mt8195-mmsys"
> to "mediatek,mt8195-vdosys0".
>
> We have to revert the multiple compatible finding function and
> add driver data of mt8195 vdosys0 to mediatek-drm and the sub driver.
>
> Signed-off-by: Jason-JH.Lin <jason-jh.lin@mediatek.com>
> ---
> drivers/gpu/drm/mediatek/mtk_disp_rdma.c | 6 ++
> drivers/gpu/drm/mediatek/mtk_drm_drv.c | 128 +++--------------------
> drivers/gpu/drm/mediatek/mtk_drm_drv.h | 6 --
> 3 files changed, 20 insertions(+), 120 deletions(-)
>
> diff --git a/drivers/gpu/drm/mediatek/mtk_disp_rdma.c b/drivers/gpu/drm/mediatek/mtk_disp_rdma.c
> index 0ec2e4049e07..66cdd0bc1311 100644
> --- a/drivers/gpu/drm/mediatek/mtk_disp_rdma.c
> +++ b/drivers/gpu/drm/mediatek/mtk_disp_rdma.c
> @@ -370,6 +370,10 @@ static const struct mtk_disp_rdma_data mt8183_rdma_driver_data = {
> .fifo_size = 5 * SZ_1K,
> };
>
> +static const struct mtk_disp_rdma_data mt8192_rdma_driver_data = {
> + .fifo_size = 5 * SZ_1K,
> +};
> +
> static const struct mtk_disp_rdma_data mt8195_rdma_driver_data = {
> .fifo_size = 1920,
> };
> @@ -381,6 +385,8 @@ static const struct of_device_id mtk_disp_rdma_driver_dt_match[] = {
> .data = &mt8173_rdma_driver_data},
> { .compatible = "mediatek,mt8183-disp-rdma",
> .data = &mt8183_rdma_driver_data},
> + { .compatible = "mediatek,mt8192-disp-rdma",
> + .data = &mt8192_rdma_driver_data},
> { .compatible = "mediatek,mt8195-disp-rdma",
> .data = &mt8195_rdma_driver_data},
> {},
Can you please drop unrelated changes in mtk_disp_rdma.c and send a v8?
We should aim to get this entire thing (8195 vdosys1) finally upstream.
After dropping mtk_disp_rdma.c changes:
Reviewed-by: AngeloGioacchino Del Regno <angelogioacchino.delregno@collabora.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH v7 1/2] drm/mediatek: change mmsys compatible for mt8195 mediatek-drm
2023-02-22 10:44 ` [PATCH v7 1/2] drm/mediatek: change mmsys compatible for mt8195 mediatek-drm AngeloGioacchino Del Regno
@ 2023-03-06 9:33 ` Jason-JH Lin (林睿祥)
0 siblings, 0 replies; 2+ messages in thread
From: Jason-JH Lin (林睿祥) @ 2023-03-06 9:33 UTC (permalink / raw)
To: angelogioacchino.delregno, chunkuang.hu
Cc: linux-mediatek, Singo Chang (張興國),
linux-kernel, Nancy Lin (林欣螢),
dri-devel, Project_Global_Chrome_Upstream_Group,
Nathan Lu (呂東霖),
linux-arm-kernel, matthias.bgg,
Rex-BC Chen (陳柏辰)
Hi Angelo,
Thanks for the reviews and sorry for missing this mail :'(
I've resent v8 today:
https://patchwork.kernel.org/project/linux-mediatek/patch/20230306080659.15261-2-jason-jh.lin@mediatek.com/
Regards,
Jason-JH.Lin
On Wed, 2023-02-22 at 11:44 +0100, AngeloGioacchino Del Regno wrote:
> Il 27/12/22 08:47, Jason-JH.Lin ha scritto:
> > Because compatible of mt8195 is changing from "mediatek,mt8195-
> > mmsys"
> > to "mediatek,mt8195-vdosys0".
> >
> > We have to revert the multiple compatible finding function and
> > add driver data of mt8195 vdosys0 to mediatek-drm and the sub
> > driver.
> >
> > Signed-off-by: Jason-JH.Lin <jason-jh.lin@mediatek.com>
> > ---
> > drivers/gpu/drm/mediatek/mtk_disp_rdma.c | 6 ++
> > drivers/gpu/drm/mediatek/mtk_drm_drv.c | 128 +++---------------
> > -----
> > drivers/gpu/drm/mediatek/mtk_drm_drv.h | 6 --
> > 3 files changed, 20 insertions(+), 120 deletions(-)
> >
> > diff --git a/drivers/gpu/drm/mediatek/mtk_disp_rdma.c
> > b/drivers/gpu/drm/mediatek/mtk_disp_rdma.c
> > index 0ec2e4049e07..66cdd0bc1311 100644
> > --- a/drivers/gpu/drm/mediatek/mtk_disp_rdma.c
> > +++ b/drivers/gpu/drm/mediatek/mtk_disp_rdma.c
> > @@ -370,6 +370,10 @@ static const struct mtk_disp_rdma_data
> > mt8183_rdma_driver_data = {
> > .fifo_size = 5 * SZ_1K,
> > };
> >
> > +static const struct mtk_disp_rdma_data mt8192_rdma_driver_data = {
> > + .fifo_size = 5 * SZ_1K,
> > +};
> > +
> > static const struct mtk_disp_rdma_data mt8195_rdma_driver_data =
> > {
> > .fifo_size = 1920,
> > };
> > @@ -381,6 +385,8 @@ static const struct of_device_id
> > mtk_disp_rdma_driver_dt_match[] = {
> > .data = &mt8173_rdma_driver_data},
> > { .compatible = "mediatek,mt8183-disp-rdma",
> > .data = &mt8183_rdma_driver_data},
> > + { .compatible = "mediatek,mt8192-disp-rdma",
> > + .data = &mt8192_rdma_driver_data},
> > { .compatible = "mediatek,mt8195-disp-rdma",
> > .data = &mt8195_rdma_driver_data},
> > {},
>
> Can you please drop unrelated changes in mtk_disp_rdma.c and send a
> v8?
> We should aim to get this entire thing (8195 vdosys1) finally
> upstream.
>
>
> After dropping mtk_disp_rdma.c changes:
>
> Reviewed-by: AngeloGioacchino Del Regno <
> angelogioacchino.delregno@collabora.com>
>
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2023-03-06 9:33 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
[not found] <20221227074759.5216-1-jason-jh.lin@mediatek.com>
[not found] ` <20221227074759.5216-2-jason-jh.lin@mediatek.com>
2023-02-22 10:44 ` [PATCH v7 1/2] drm/mediatek: change mmsys compatible for mt8195 mediatek-drm AngeloGioacchino Del Regno
2023-03-06 9:33 ` Jason-JH Lin (林睿祥)
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®