* [PATCH linux-next v2 5/6] dt-bindings: clock: add clock id for renesas adg clocks
@ 2018-12-03 11:24 jiada_wang
2018-12-03 12:16 ` Vladimir Zapolskiy
0 siblings, 1 reply; 2+ messages in thread
From: jiada_wang @ 2018-12-03 11:24 UTC (permalink / raw)
To: broonie, perex, tiwai, kuninori.morimoto.gx, vladimir_zapolskiy
Cc: alsa-devel, linux-kernel, jiada_wang
From: Jiada Wang <jiada_wang@mentor.com>
This patch adds clock ID for renesas adg clocks
Signed-off-by: Jiada Wang <jiada_wang@mentor.com>
---
include/dt-bindings/clock/renesas-adg.h | 11 +++++++++++
1 file changed, 11 insertions(+)
create mode 100644 include/dt-bindings/clock/renesas-adg.h
diff --git a/include/dt-bindings/clock/renesas-adg.h b/include/dt-bindings/clock/renesas-adg.h
new file mode 100644
index 000000000000..fe30c186cef7
--- /dev/null
+++ b/include/dt-bindings/clock/renesas-adg.h
@@ -0,0 +1,11 @@
+/* SPDX-License-Identifier: GPL-2.0 */
+/*
+ * Copyright (C) 2018 Mentor Graphics inc.
+ */
+#ifndef __DT_BINDINGS_RENESAS_ADG_H__
+#define __DT_BINDINGS_RENESAS_ADG_H__
+
+#define ADG_FIX 0
+#define ADG_AVB 1
+
+#endif /* __DT_BINDINGS_RENESAS_ADG_H__ */
--
2.17.0
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH linux-next v2 5/6] dt-bindings: clock: add clock id for renesas adg clocks
2018-12-03 11:24 [PATCH linux-next v2 5/6] dt-bindings: clock: add clock id for renesas adg clocks jiada_wang
@ 2018-12-03 12:16 ` Vladimir Zapolskiy
0 siblings, 0 replies; 2+ messages in thread
From: Vladimir Zapolskiy @ 2018-12-03 12:16 UTC (permalink / raw)
To: jiada_wang, broonie, perex, tiwai, kuninori.morimoto.gx
Cc: alsa-devel, linux-kernel
Hi Jiada,
On 12/03/2018 01:24 PM, jiada_wang@mentor.com wrote:
> From: Jiada Wang <jiada_wang@mentor.com>
>
> This patch adds clock ID for renesas adg clocks
>
> Signed-off-by: Jiada Wang <jiada_wang@mentor.com>
> ---
> include/dt-bindings/clock/renesas-adg.h | 11 +++++++++++
> 1 file changed, 11 insertions(+)
> create mode 100644 include/dt-bindings/clock/renesas-adg.h
>
> diff --git a/include/dt-bindings/clock/renesas-adg.h b/include/dt-bindings/clock/renesas-adg.h
> new file mode 100644
> index 000000000000..fe30c186cef7
> --- /dev/null
> +++ b/include/dt-bindings/clock/renesas-adg.h
> @@ -0,0 +1,11 @@
> +/* SPDX-License-Identifier: GPL-2.0 */
> +/*
> + * Copyright (C) 2018 Mentor Graphics inc.
> + */
> +#ifndef __DT_BINDINGS_RENESAS_ADG_H__
> +#define __DT_BINDINGS_RENESAS_ADG_H__
> +
> +#define ADG_FIX 0
> +#define ADG_AVB 1
> +
> +#endif /* __DT_BINDINGS_RENESAS_ADG_H__ */
>
instead of adding these trivial definitions in a new header file with no
potential for further extension, I would like to ask you to write a proper
device tree bindings documentation section and describe the clock ids as
a list of acceptable values for a cell.
--
Best wishes,
Vladimir
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-12-03 12:16 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-12-03 11:24 [PATCH linux-next v2 5/6] dt-bindings: clock: add clock id for renesas adg clocks jiada_wang
2018-12-03 12:16 ` Vladimir Zapolskiy
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®