From: Edward Cree <ecree.xilinx@gmail.com>
To: Hemanth Selam <hemanth.selam@gmail.com>,
"David S . Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Andrew Lunn <andrew@lunn.ch>,
Sudarsana Kalluru <skalluru@marvell.com>,
Manish Chopra <manishc@marvell.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
Simon Horman <horms@kernel.org>, Shuah Khan <shuah@kernel.org>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-net-drivers@amd.com, linux-kselftest@vger.kernel.org,
linux-usb@vger.kernel.org
Subject: Re: [PATCH v2 1/6] net: fix typos in comments
Date: Mon, 7 Sep 2026 16:37:12 +0100 [thread overview]
Message-ID: <2520c402-e54a-4451-ae2e-9ab9816c11ed@gmail.com> (raw)
In-Reply-To: <20260907044635.7141-2-hemanth.selam@gmail.com>
On 07/09/2026 05:46, Hemanth Selam wrote:
> Fix typos in comments, reported by scripts/checkpatch.pl using the
> misspelling list in scripts/spelling.txt. Only touches comments, no code
> changes.
>
> Assisted-by: Cursor:claude-opus-5
> Signed-off-by: Hemanth Selam <hemanth.selam@gmail.com>
...
> diff --git a/drivers/net/ethernet/sfc/mcdi_pcol.h b/drivers/net/ethernet/sfc/mcdi_pcol.h
mcdi_pcol.h (and the Siena version) are generated from firmware definitions,
so any changes you make would be overwritten next time they are regenerated.
I have forwarded these changes internally, so they should reach the firmware
team.
> index b9866e389e6d..b00e7c100566 100644
> --- a/drivers/net/ethernet/sfc/mcdi_pcol.h
> +++ b/drivers/net/ethernet/sfc/mcdi_pcol.h
> @@ -5736,7 +5736,7 @@
> /* Enum values, see field(s): */
> /* MC_CMD_ETH_TECH/TECH */
> /* Pause abilities to advertise during auto-negotiation. Valid when auto-
> - * negotation is enabled and MC_CMD_SET_MAC_IN/FCTL is set to
> + * negotiation is enabled and MC_CMD_SET_MAC_IN/FCTL is set to
> * MC_CMD_FCNTL_AUTO. If auto-negotiation is disabled the driver must
> * explicitly configure pause mode with MC_CMD_SET_MAC.
> */
> @@ -10173,7 +10173,7 @@
> * configuration.
> */
> #define MC_CMD_GET_FIXED_PORT_PROPERTIES_IN_LEN 4
> -/* Handle to the port to from which to retreive properties */
> +/* Handle to the port to from which to retrieve properties */
> #define MC_CMD_GET_FIXED_PORT_PROPERTIES_IN_PORT_HANDLE_OFST 0
> #define MC_CMD_GET_FIXED_PORT_PROPERTIES_IN_PORT_HANDLE_LEN 4
>
> @@ -13547,7 +13547,7 @@
> * an ancestor of the current user (see MC_CMD_SET_VI_USER). Note that LL
> * queues require this to be called after allocation but before initialisation
> * of the queue. TLP options of a queue are fixed after queue is initialised,
> - * with the values set to current global value or they can be overriden using
> + * with the values set to current global value or they can be overridden using
> * this command. At LL queue allocation, all overrides are cleared.
> */
> #define MC_CMD_SET_VI_TLP_PROCESSING 0xb1
> @@ -21387,7 +21387,7 @@
> #define MC_CMD_PRIVILEGE_MASK_IN_GRP_ALL_MULTICAST 0x200 /* enum */
> #define MC_CMD_PRIVILEGE_MASK_IN_GRP_PROMISCUOUS 0x400 /* enum */
> /* enum: Allows to set the TX packets' source MAC address to any arbitrary MAC
> - * adress.
> + * address.
> */
> #define MC_CMD_PRIVILEGE_MASK_IN_GRP_MAC_SPOOFING_TX 0x800
> /* enum: Privilege that allows a Function to change the MAC address configured
> diff --git a/drivers/net/ethernet/sfc/siena/mcdi_pcol.h b/drivers/net/ethernet/sfc/siena/mcdi_pcol.h
> index b81b0aa460d2..4d1da698c524 100644
> --- a/drivers/net/ethernet/sfc/siena/mcdi_pcol.h
> +++ b/drivers/net/ethernet/sfc/siena/mcdi_pcol.h
> @@ -6861,7 +6861,7 @@
> /***********************************/
> /* MC_CMD_CLP
> * Perform a CLP related operation, see SF-110495-PS for details of CLP
> - * processing. This command has been extended to accomodate the requirements of
> + * processing. This command has been extended to accommodate the requirements of
> * different manufacturers which are to be found in SF-119187-TC, SF-119186-TC,
> * SF-120509-TC and SF-117282-PS.
> */
> @@ -16293,7 +16293,7 @@
>
> /***********************************/
> /* MC_CMD_GET_LICENSED_V3_FEATURE_STATES
> - * Query the state of an one or more licensed features. (Note that the actual
> + * Query the state of a one or more licensed features. (Note that the actual
Neither this nor the original text makes grammatical sense; I think the article
'an' should be deleted entirely rather than replaced with 'a'.
> * state may be invalidated by the MC_CMD_LICENSING_V3 OP_UPDATE_LICENSE
> * operation or a reboot of the MC.) Used for V3 licensing (Medford)
> */
> @@ -16798,7 +16798,7 @@
> #define MC_CMD_PRIVILEGE_MASK_IN_GRP_ALL_MULTICAST 0x200 /* enum */
> #define MC_CMD_PRIVILEGE_MASK_IN_GRP_PROMISCUOUS 0x400 /* enum */
> /* enum: Allows to set the TX packets' source MAC address to any arbitrary MAC
> - * adress.
> + * address.
> */
> #define MC_CMD_PRIVILEGE_MASK_IN_GRP_MAC_SPOOFING_TX 0x800
> /* enum: Privilege that allows a Function to change the MAC address configured
The other sfc changes outside of pcol look fine.
-ed
next prev parent reply other threads:[~2026-09-07 15:37 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-07 4:46 [PATCH v2 0/6] net: fix typos and repeated words " Hemanth Selam
2026-09-07 4:46 ` [PATCH v2 1/6] net: fix typos " Hemanth Selam
2026-09-07 12:49 ` Jijie Shao
2026-09-07 12:52 ` Andrew Lunn
2026-09-07 15:37 ` Edward Cree [this message]
2026-09-07 4:46 ` [PATCH v2 2/6] net: broadcom: fix repeated word 'will' in comment Hemanth Selam
2026-09-07 4:46 ` [PATCH v2 3/6] net: llc: fix repeated word 'all' " Hemanth Selam
2026-09-07 12:46 ` Andrew Lunn
2026-09-07 4:46 ` [PATCH v2 4/6] net: sfc: fix repeated word 'the' " Hemanth Selam
2026-09-07 12:46 ` Andrew Lunn
2026-09-07 15:38 ` Edward Cree
2026-09-07 4:46 ` [PATCH v2 5/6] selftests: net: fix repeated word 'use' " Hemanth Selam
2026-09-07 12:47 ` Andrew Lunn
2026-09-07 4:46 ` [PATCH v2 6/6] net: usb: fix repeated words in log messages Hemanth Selam
2026-09-07 12:49 ` Andrew Lunn
2026-09-08 5:25 ` Hemanth Selam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2520c402-e54a-4451-ae2e-9ab9816c11ed@gmail.com \
--to=ecree.xilinx@gmail.com \
--cc=andrew+netdev@lunn.ch \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hemanth.selam@gmail.com \
--cc=horms@kernel.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-kselftest@vger.kernel.org \
--cc=linux-net-drivers@amd.com \
--cc=linux-usb@vger.kernel.org \
--cc=manishc@marvell.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=shuah@kernel.org \
--cc=skalluru@marvell.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®