From: Alexey Makhalov <alexey.makhalov@broadcom.com>
To: Borislav Petkov <bp@alien8.de>
Cc: linux-kernel@vger.kernel.org,
bcm-kernel-feedback-list@broadcom.com, lkp@intel.com,
zack.rusin@broadcom.com, dri-devel@lists.freedesktop.org,
daniel@ffwll.ch, airlied@gmail.com, tzimmermann@suse.de,
mripard@kernel.org, maarten.lankhorst@linux.intel.com,
linux-iio@vger.kernel.org, jic23@kernel.org, lars@metafoo.de,
nuno.sa@analog.com, dragos.bogdan@analog.com,
anshulusr@gmail.com, andrea.collamati@gmail.com,
oe-kbuild-all@lists.linux.dev, x86@kernel.org
Subject: Re: [PATCH 1/2] drm/vmwgfx: Fix missing HYPERVISOR_GUEST dependency
Date: Mon, 17 Jun 2024 15:48:56 -0700 [thread overview]
Message-ID: <25275668-0441-4015-9a94-aab305865fae@broadcom.com> (raw)
In-Reply-To: <20240617211758.GKZnCoBvT2enGx5p5r@fat_crate.local>
On 6/17/24 2:17 PM, Borislav Petkov wrote:
> On Mon, Jun 17, 2024 at 01:51:23PM -0700, Alexey Makhalov wrote:
>> Not really a gcc related, but the matter of a config file. It is
>> reproducible if CONFIG_HYPERVISOR_GUEST not set, but CONFIG_DRM_VMWGFX=y.
>> And this combination was allowed before the fix.
>
> Using their config:
>
> $ grep -E "(CONFIG_DRM_VMWGFX|CONFIG_HYPERVISOR_GUEST)" .config
> # CONFIG_HYPERVISOR_GUEST is not set
> CONFIG_DRM_VMWGFX=y
> CONFIG_DRM_VMWGFX_MKSSTATS=y
>
> $ make ...
>
> OBJCOPY arch/x86/boot/setup.bin
> BUILD arch/x86/boot/bzImage
> Kernel: arch/x86/boot/bzImage is ready (#2)
> $ gcc --version
> gcc (Debian 13.2.0-25) 13.2.0
> $
>
> So no, I can't reproduce with my compiler.
>
That is interesting! Happy to debug it, but unfortunately I can not
reproduce your "good" compilation without the fix.
I tried
"gcc (Ubuntu 13.2.0-23ubuntu4) 13.2.0" in Ubuntu, and
"gcc (GCC) 12.2.0" in Photon OS.
All of them fail with an "undefined reference to `vmware_hypercall_slow'"
next prev parent reply other threads:[~2024-06-17 22:49 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-15 13:22 [tip:x86/vmware 4/8] vmwgfx_msg.c:undefined reference to `vmware_hypercall_slow' kernel test robot
2024-06-15 14:33 ` Borislav Petkov
2024-06-15 20:41 ` Alexey Makhalov
2024-06-15 21:41 ` Alexey Makhalov
2024-06-16 1:25 ` [PATCH 1/2] drm/vmwgfx: Fix missing HYPERVISOR_GUEST dependency Alexey Makhalov
2024-06-16 1:25 ` [PATCH 2/2] iio: dac: Fix dependencies of AD9739A Alexey Makhalov
2024-06-17 9:04 ` Borislav Petkov
2024-06-17 20:48 ` Alexey Makhalov
2024-06-17 21:02 ` Borislav Petkov
2024-06-17 9:07 ` [PATCH 1/2] drm/vmwgfx: Fix missing HYPERVISOR_GUEST dependency Borislav Petkov
2024-06-17 10:01 ` Borislav Petkov
2024-06-17 13:47 ` Zack Rusin
2024-06-17 20:51 ` Alexey Makhalov
2024-06-17 21:17 ` Borislav Petkov
2024-06-17 22:48 ` Alexey Makhalov [this message]
2024-06-19 9:55 ` [tip: x86/urgent] " tip-bot2 for Alexey Makhalov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=25275668-0441-4015-9a94-aab305865fae@broadcom.com \
--to=alexey.makhalov@broadcom.com \
--cc=airlied@gmail.com \
--cc=andrea.collamati@gmail.com \
--cc=anshulusr@gmail.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=bp@alien8.de \
--cc=daniel@ffwll.ch \
--cc=dragos.bogdan@analog.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=jic23@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=maarten.lankhorst@linux.intel.com \
--cc=mripard@kernel.org \
--cc=nuno.sa@analog.com \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=tzimmermann@suse.de \
--cc=x86@kernel.org \
--cc=zack.rusin@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®