From: Alexey Makhalov <alexey.makhalov@broadcom.com>
To: Borislav Petkov <bp@alien8.de>, kernel test robot <lkp@intel.com>
Cc: oe-kbuild-all@lists.linux.dev, linux-kernel@vger.kernel.org,
x86@kernel.org
Subject: Re: [tip:x86/vmware 4/8] vmwgfx_msg.c:undefined reference to `vmware_hypercall_slow'
Date: Sat, 15 Jun 2024 13:41:14 -0700 [thread overview]
Message-ID: <327b5f58-441a-434e-ac07-615ba9a1e3f2@broadcom.com> (raw)
In-Reply-To: <20240615143344.GDZm2mSB-qyB0Vt28Q@fat_crate.local>
Thanks for the report and provided .config file.
The problem with DRM_VMWGFX=y when HYPERVISOR_GUEST is not set, i.e
arch/x86/kernel/cpu/vmware.c is not built.
It is even a problem today. For VMWARE_HYPERCALL alternative to work,
vmware guest code must set cpu capabilities properly.
The kernel based on the current config file will not work on a SEV-ES
enabled machine.
DRM_VMWGFX must depend on HYPERVISOR_GUEST similarly to VMWARE_BALLOON,
MOUSE_PS2_VMMOUSE and
PTP_1588_CLOCK_VMW.
Borislav, I'm going to send a fix shortly. It has to be applied before
this patchset.
Thanks,
--Alexey
On 6/15/24 7:33 AM, Borislav Petkov wrote:
> On Sat, Jun 15, 2024 at 09:22:00PM +0800, kernel test robot wrote:
>> tree: https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git x86/vmware
>> head: ef08e7dc21307b226b5280d5e8cfea687bfd2866
>> commit: e5ac9008b79c59235c34494e555419665022f5e1 [4/8] drm/vmwgfx: Use VMware hypercall API
>> config: i386-buildonly-randconfig-002-20240615 (https://download.01.org/0day-ci/archive/20240615/202406152104.FxakP1MB-lkp@intel.com/config)
>> compiler: gcc-9 (Ubuntu 9.5.0-4ubuntu2) 9.5.0
>> reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20240615/202406152104.FxakP1MB-lkp@intel.com/reproduce)
>>
>> If you fix the issue in a separate patch/commit (i.e. not just a new version of
>> the same patch/commit), kindly add following tags
>> | Reported-by: kernel test robot <lkp@intel.com>
>> | Closes: https://lore.kernel.org/oe-kbuild-all/202406152104.FxakP1MB-lkp@intel.com/
>>
>> All errors (new ones prefixed by >>):
>>
>> ld: drivers/gpu/drm/vmwgfx/vmwgfx_msg.o: in function `vmw_open_channel.constprop.0':
>>>> vmwgfx_msg.c:(.text+0x203): undefined reference to `vmware_hypercall_slow'
>> ld: drivers/gpu/drm/vmwgfx/vmwgfx_msg.o: in function `vmw_recv_msg':
>> vmwgfx_msg.c:(.text+0x46f): undefined reference to `vmware_hypercall_slow'
>>>> ld: vmwgfx_msg.c:(.text+0x49c): undefined reference to `vmware_hypercall_slow'
>> ld: vmwgfx_msg.c:(.text+0x4c3): undefined reference to `vmware_hypercall_slow'
>> ld: drivers/gpu/drm/vmwgfx/vmwgfx_msg.o: in function `vmw_close_channel':
>> vmwgfx_msg.c:(.text+0x580): undefined reference to `vmware_hypercall_slow'
>> ld: drivers/gpu/drm/vmwgfx/vmwgfx_msg.o:vmwgfx_msg.c:(.text+0x729): more undefined references to `vmware_hypercall_slow' follow
>> ld: drivers/base/regmap/regmap-spi.o: in function `regmap_spi_read':
>> regmap-spi.c:(.text+0xf): undefined reference to `spi_write_then_read'
>> ld: drivers/base/regmap/regmap-spi.o: in function `regmap_spi_gather_write':
>> regmap-spi.c:(.text+0x2b4): undefined reference to `spi_sync'
>> ld: drivers/base/regmap/regmap-spi.o: in function `spi_sync_transfer.constprop.0':
>> regmap-spi.c:(.text+0x337): undefined reference to `spi_sync'
>> ld: drivers/base/regmap/regmap-spi.o: in function `regmap_spi_async_write':
>> regmap-spi.c:(.text+0x445): undefined reference to `spi_async'
>> ld: drivers/iio/dac/ad9739a.o: in function `ad9739a_driver_init':
>> ad9739a.c:(.init.text+0x10): undefined reference to `__spi_register_driver'
>>
>> Kconfig warnings: (for reference only)
>> WARNING: unmet direct dependencies detected for REGMAP_SPI
>> Depends on [n]: SPI [=n]
>> Selected by [y]:
>> - AD9739A [=y] && IIO [=y] && (SPI [=n] || COMPILE_TEST [=y])
>>
>> --
>
> Zapping tip:x86/vmware from the tip/master lineup for the time being, until this
> is fixed.
>
> Thx 0day guys for reporting.
>
next prev parent reply other threads:[~2024-06-15 20:41 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-06-15 13:22 kernel test robot
2024-06-15 14:33 ` Borislav Petkov
2024-06-15 20:41 ` Alexey Makhalov [this message]
2024-06-15 21:41 ` Alexey Makhalov
2024-06-16 1:25 ` [PATCH 1/2] drm/vmwgfx: Fix missing HYPERVISOR_GUEST dependency Alexey Makhalov
2024-06-16 1:25 ` [PATCH 2/2] iio: dac: Fix dependencies of AD9739A Alexey Makhalov
2024-06-17 9:04 ` Borislav Petkov
2024-06-17 20:48 ` Alexey Makhalov
2024-06-17 21:02 ` Borislav Petkov
2024-06-17 9:07 ` [PATCH 1/2] drm/vmwgfx: Fix missing HYPERVISOR_GUEST dependency Borislav Petkov
2024-06-17 10:01 ` Borislav Petkov
2024-06-17 13:47 ` Zack Rusin
2024-06-17 20:51 ` Alexey Makhalov
2024-06-17 21:17 ` Borislav Petkov
2024-06-17 22:48 ` Alexey Makhalov
2024-06-19 9:55 ` [tip: x86/urgent] " tip-bot2 for Alexey Makhalov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=327b5f58-441a-434e-ac07-615ba9a1e3f2@broadcom.com \
--to=alexey.makhalov@broadcom.com \
--cc=bp@alien8.de \
--cc=linux-kernel@vger.kernel.org \
--cc=lkp@intel.com \
--cc=oe-kbuild-all@lists.linux.dev \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®