mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Thomas Zimmermann <tzimmermann@suse.de>
To: 2564278112@qq.com, Lyude Paul <lyude@redhat.com>,
	Danilo Krummrich <dakr@kernel.org>,
	Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
	Maxime Ripard <mripard@kernel.org>,
	David Airlie <airlied@gmail.com>, Simona Vetter <simona@ffwll.ch>
Cc: dri-devel@lists.freedesktop.org, nouveau@lists.freedesktop.org,
	linux-kernel@vger.kernel.org, jiangwang@kylinos.cn
Subject: Re: [PATCH] drm/nouveau: Resolve the issue of VGA not detecting disconnection
Date: Mon, 1 Dec 2025 08:36:22 +0100	[thread overview]
Message-ID: <252b8c75-ed9b-42c9-bcfe-0ceae14f664f@suse.de> (raw)
In-Reply-To: <tencent_7431C42BA1F206D1FAF305FB068550884605@qq.com>

Hi

Am 01.12.25 um 02:41 schrieb 2564278112@qq.com:
> From: Wang Jiang <jiangwang@kylinos.cn>
>
> When using the GT730, I found that the VGA could recognize when it was plugged in,
> but could not detect when it was disconnected.
> The reason is that the polled flag for the connector is missing DRM_CONNECTOR_POLL_DISCONNECT.
>
> Signed-off-by: Wang Jiang <jiangwang@kylinos.cn>
> Reviewed-by: Thomas Zimmermann <tzimmermann@suse.de>

I'm surprised that there is a new patch and I already reviewed it. Has 
this change been posted elsewhere already?

Best regards
Thomas

> ---
>   drivers/gpu/drm/nouveau/nouveau_connector.c | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/nouveau/nouveau_connector.c b/drivers/gpu/drm/nouveau/nouveau_connector.c
> index 63621b1510f6..dfff01edf65a 100644
> --- a/drivers/gpu/drm/nouveau/nouveau_connector.c
> +++ b/drivers/gpu/drm/nouveau/nouveau_connector.c
> @@ -1421,7 +1421,7 @@ nouveau_connector_create(struct drm_device *dev, int index)
>   	connector->doublescan_allowed = false;
>   
>   	drm_connector_helper_add(connector, &nouveau_connector_helper_funcs);
> -	connector->polled = DRM_CONNECTOR_POLL_CONNECT;
> +	connector->polled = DRM_CONNECTOR_POLL_CONNECT | DRM_CONNECTOR_POLL_DISCONNECT;
>   
>   	if (nvif_object_constructed(&nv_connector->conn.object)) {
>   		ret = nvif_conn_event_ctor(&nv_connector->conn, "kmsHotplug",

-- 
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Frankenstr. 146, 90461 Nürnberg, Germany, www.suse.com
GF: Jochen Jaser, Andrew McDonald, Werner Knoblich, (HRB 36809, AG Nürnberg)



  reply	other threads:[~2025-12-01  7:36 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-12-01  1:41 2564278112
2025-12-01  7:36 ` Thomas Zimmermann [this message]
  -- strict thread matches above, loose matches on Subject: below --
2025-10-27  3:16 2564278112
2025-10-27  7:24 ` Thomas Zimmermann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=252b8c75-ed9b-42c9-bcfe-0ceae14f664f@suse.de \
    --to=tzimmermann@suse.de \
    --cc=2564278112@qq.com \
    --cc=airlied@gmail.com \
    --cc=dakr@kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=jiangwang@kylinos.cn \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lyude@redhat.com \
    --cc=maarten.lankhorst@linux.intel.com \
    --cc=mripard@kernel.org \
    --cc=nouveau@lists.freedesktop.org \
    --cc=simona@ffwll.ch \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®