* [PATCH] drm/nouveau: Resolve the issue of VGA not detecting disconnection
@ 2025-12-01 1:41 2564278112
2025-12-01 7:36 ` Thomas Zimmermann
0 siblings, 1 reply; 4+ messages in thread
From: 2564278112 @ 2025-12-01 1:41 UTC (permalink / raw)
To: Lyude Paul, Danilo Krummrich, Maarten Lankhorst, Maxime Ripard,
Thomas Zimmermann, David Airlie, Simona Vetter
Cc: dri-devel, nouveau, linux-kernel, jiangwang
From: Wang Jiang <jiangwang@kylinos.cn>
When using the GT730, I found that the VGA could recognize when it was plugged in,
but could not detect when it was disconnected.
The reason is that the polled flag for the connector is missing DRM_CONNECTOR_POLL_DISCONNECT.
Signed-off-by: Wang Jiang <jiangwang@kylinos.cn>
Reviewed-by: Thomas Zimmermann <tzimmermann@suse.de>
---
drivers/gpu/drm/nouveau/nouveau_connector.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/nouveau/nouveau_connector.c b/drivers/gpu/drm/nouveau/nouveau_connector.c
index 63621b1510f6..dfff01edf65a 100644
--- a/drivers/gpu/drm/nouveau/nouveau_connector.c
+++ b/drivers/gpu/drm/nouveau/nouveau_connector.c
@@ -1421,7 +1421,7 @@ nouveau_connector_create(struct drm_device *dev, int index)
connector->doublescan_allowed = false;
drm_connector_helper_add(connector, &nouveau_connector_helper_funcs);
- connector->polled = DRM_CONNECTOR_POLL_CONNECT;
+ connector->polled = DRM_CONNECTOR_POLL_CONNECT | DRM_CONNECTOR_POLL_DISCONNECT;
if (nvif_object_constructed(&nv_connector->conn.object)) {
ret = nvif_conn_event_ctor(&nv_connector->conn, "kmsHotplug",
--
2.25.1
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] drm/nouveau: Resolve the issue of VGA not detecting disconnection
2025-12-01 1:41 [PATCH] drm/nouveau: Resolve the issue of VGA not detecting disconnection 2564278112
@ 2025-12-01 7:36 ` Thomas Zimmermann
0 siblings, 0 replies; 4+ messages in thread
From: Thomas Zimmermann @ 2025-12-01 7:36 UTC (permalink / raw)
To: 2564278112, Lyude Paul, Danilo Krummrich, Maarten Lankhorst,
Maxime Ripard, David Airlie, Simona Vetter
Cc: dri-devel, nouveau, linux-kernel, jiangwang
Hi
Am 01.12.25 um 02:41 schrieb 2564278112@qq.com:
> From: Wang Jiang <jiangwang@kylinos.cn>
>
> When using the GT730, I found that the VGA could recognize when it was plugged in,
> but could not detect when it was disconnected.
> The reason is that the polled flag for the connector is missing DRM_CONNECTOR_POLL_DISCONNECT.
>
> Signed-off-by: Wang Jiang <jiangwang@kylinos.cn>
> Reviewed-by: Thomas Zimmermann <tzimmermann@suse.de>
I'm surprised that there is a new patch and I already reviewed it. Has
this change been posted elsewhere already?
Best regards
Thomas
> ---
> drivers/gpu/drm/nouveau/nouveau_connector.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/nouveau/nouveau_connector.c b/drivers/gpu/drm/nouveau/nouveau_connector.c
> index 63621b1510f6..dfff01edf65a 100644
> --- a/drivers/gpu/drm/nouveau/nouveau_connector.c
> +++ b/drivers/gpu/drm/nouveau/nouveau_connector.c
> @@ -1421,7 +1421,7 @@ nouveau_connector_create(struct drm_device *dev, int index)
> connector->doublescan_allowed = false;
>
> drm_connector_helper_add(connector, &nouveau_connector_helper_funcs);
> - connector->polled = DRM_CONNECTOR_POLL_CONNECT;
> + connector->polled = DRM_CONNECTOR_POLL_CONNECT | DRM_CONNECTOR_POLL_DISCONNECT;
>
> if (nvif_object_constructed(&nv_connector->conn.object)) {
> ret = nvif_conn_event_ctor(&nv_connector->conn, "kmsHotplug",
--
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Frankenstr. 146, 90461 Nürnberg, Germany, www.suse.com
GF: Jochen Jaser, Andrew McDonald, Werner Knoblich, (HRB 36809, AG Nürnberg)
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] drm/nouveau: Resolve the issue of VGA not detecting disconnection
2025-10-27 3:16 2564278112
@ 2025-10-27 7:24 ` Thomas Zimmermann
0 siblings, 0 replies; 4+ messages in thread
From: Thomas Zimmermann @ 2025-10-27 7:24 UTC (permalink / raw)
To: 2564278112, lyude, dakr, maarten.lankhorst, mripard, airlie,
simona, dri-devel, nouveau, linux-kernel, jiangwang
Am 27.10.25 um 04:16 schrieb 2564278112@qq.com:
> From: Wang Jiang <jiangwang@kylinos.cn>
>
> When using the GT730, I found that the VGA could recognize when it was plugged in,
> but could not detect when it was disconnected.
> The reason is that the polled flag for the connector is missing DRM_CONNECTOR_POLL_DISCONNECT.
>
> Signed-off-by: Wang Jiang <jiangwang@kylinos.cn>
Reviewed-by: Thomas Zimmermann <tzimmermann@suse.de>
> ---
> drivers/gpu/drm/nouveau/nouveau_connector.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/nouveau/nouveau_connector.c b/drivers/gpu/drm/nouveau/nouveau_connector.c
> index 63621b1510f6..dfff01edf65a 100644
> --- a/drivers/gpu/drm/nouveau/nouveau_connector.c
> +++ b/drivers/gpu/drm/nouveau/nouveau_connector.c
> @@ -1421,7 +1421,7 @@ nouveau_connector_create(struct drm_device *dev, int index)
> connector->doublescan_allowed = false;
>
> drm_connector_helper_add(connector, &nouveau_connector_helper_funcs);
> - connector->polled = DRM_CONNECTOR_POLL_CONNECT;
> + connector->polled = DRM_CONNECTOR_POLL_CONNECT | DRM_CONNECTOR_POLL_DISCONNECT;
>
> if (nvif_object_constructed(&nv_connector->conn.object)) {
> ret = nvif_conn_event_ctor(&nv_connector->conn, "kmsHotplug",
--
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Frankenstrasse 146, 90461 Nuernberg, Germany
GF: Ivo Totev, Andrew Myers, Andrew McDonald, Boudien Moerman
HRB 36809 (AG Nuernberg)
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] drm/nouveau: Resolve the issue of VGA not detecting disconnection
@ 2025-10-27 3:16 2564278112
2025-10-27 7:24 ` Thomas Zimmermann
0 siblings, 1 reply; 4+ messages in thread
From: 2564278112 @ 2025-10-27 3:16 UTC (permalink / raw)
To: lyude, dakr, maarten.lankhorst, mripard, tzimmermann, airlie,
simona, dri-devel, nouveau, linux-kernel, jiangwang
From: Wang Jiang <jiangwang@kylinos.cn>
When using the GT730, I found that the VGA could recognize when it was plugged in,
but could not detect when it was disconnected.
The reason is that the polled flag for the connector is missing DRM_CONNECTOR_POLL_DISCONNECT.
Signed-off-by: Wang Jiang <jiangwang@kylinos.cn>
---
drivers/gpu/drm/nouveau/nouveau_connector.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/nouveau/nouveau_connector.c b/drivers/gpu/drm/nouveau/nouveau_connector.c
index 63621b1510f6..dfff01edf65a 100644
--- a/drivers/gpu/drm/nouveau/nouveau_connector.c
+++ b/drivers/gpu/drm/nouveau/nouveau_connector.c
@@ -1421,7 +1421,7 @@ nouveau_connector_create(struct drm_device *dev, int index)
connector->doublescan_allowed = false;
drm_connector_helper_add(connector, &nouveau_connector_helper_funcs);
- connector->polled = DRM_CONNECTOR_POLL_CONNECT;
+ connector->polled = DRM_CONNECTOR_POLL_CONNECT | DRM_CONNECTOR_POLL_DISCONNECT;
if (nvif_object_constructed(&nv_connector->conn.object)) {
ret = nvif_conn_event_ctor(&nv_connector->conn, "kmsHotplug",
--
2.25.1
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2025-12-01 7:36 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-12-01 1:41 [PATCH] drm/nouveau: Resolve the issue of VGA not detecting disconnection 2564278112
2025-12-01 7:36 ` Thomas Zimmermann
-- strict thread matches above, loose matches on Subject: below --
2025-10-27 3:16 2564278112
2025-10-27 7:24 ` Thomas Zimmermann
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®