From: David Laight <David.Laight@ACULAB.COM>
To: 'Yangyu Chen' <cyy@cyyself.name>,
"evan@rivosinc.com" <evan@rivosinc.com>
Cc: "ajones@ventanamicro.com" <ajones@ventanamicro.com>,
"alexghiti@rivosinc.com" <alexghiti@rivosinc.com>,
"andy.chiu@sifive.com" <andy.chiu@sifive.com>,
"aou@eecs.berkeley.edu" <aou@eecs.berkeley.edu>,
"apatel@ventanamicro.com" <apatel@ventanamicro.com>,
"conor.dooley@microchip.com" <conor.dooley@microchip.com>,
"corbet@lwn.net" <corbet@lwn.net>,
"greentime.hu@sifive.com" <greentime.hu@sifive.com>,
"guoren@kernel.org" <guoren@kernel.org>,
"heiko.stuebner@vrull.eu" <heiko.stuebner@vrull.eu>,
"heiko@sntech.de" <heiko@sntech.de>,
"jeeheng.sia@starfivetech.com" <jeeheng.sia@starfivetech.com>,
"jszhang@kernel.org" <jszhang@kernel.org>,
"leyfoon.tan@starfivetech.com" <leyfoon.tan@starfivetech.com>,
"linux-doc@vger.kernel.org" <linux-doc@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-riscv@lists.infradead.org"
<linux-riscv@lists.infradead.org>,
"lizhengyu3@huawei.com" <lizhengyu3@huawei.com>,
"masahiroy@kernel.org" <masahiroy@kernel.org>,
"palmer@dabbelt.com" <palmer@dabbelt.com>,
"palmer@rivosinc.com" <palmer@rivosinc.com>,
"paul.walmsley@sifive.com" <paul.walmsley@sifive.com>,
"rdunlap@infradead.org" <rdunlap@infradead.org>,
"samuel@sholland.org" <samuel@sholland.org>,
"shosie@rivosinc.com" <shosie@rivosinc.com>,
"sunilvl@ventanamicro.com" <sunilvl@ventanamicro.com>,
"xianting.tian@linux.alibaba.com"
<xianting.tian@linux.alibaba.com>
Subject: RE: [PATCH 0/2] RISC-V: Probe for misaligned access speed
Date: Mon, 26 Jun 2023 09:24:36 +0000 [thread overview]
Message-ID: <253bad9e83cd4890b29dd89a3d5a1937@AcuMS.aculab.com> (raw)
In-Reply-To: <tencent_817CE182DEDA938E03B848314821098D4408@qq.com>
From: Yangyu Chen
> Sent: 24 June 2023 11:22
>
> Hi,
>
> Thanks for doing this.
>
> On 6/24/23 6:20 AM, Evan Green wrote:
> > I don't have a machine where misaligned accesses are slow, but I'd be
> > interested to see the results of booting this series if someone did.
>
> I have tested your patches on a 100MHz BigCore rocket-chip with opensbi running on FPGA with
> 72bit(64bit+ECC) DDR3 1600MHz memory. As the rocket-chip did not support misaligned memory access,
> every misaligned memory access will trap and emulated by SBI.
>
> Here is the result:
...
> ~ # dmesg | grep Unaligned
> [ 0.210140] cpu1: Unaligned word copy 0 MB/s, byte copy 38 MB/s, misaligned accesses are slow
> [ 0.410715] cpu0: Unaligned word copy 0 MB/s, byte copy 35 MB/s, misaligned accesses are slow
How many misaligned cycles are in the test loop?
If emulated ones are that slow you pretty much only need to test one.
Also it is pretty clear that you really don't want to be emulating them.
If the emulation is hidden from the kernel that really doesn't help at all.
David
-
Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK
Registration No: 1397386 (Wales)
next prev parent reply other threads:[~2023-06-26 9:27 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-06-23 22:20 Evan Green
2023-06-23 22:20 ` [PATCH 1/2] RISC-V: Probe for unaligned " Evan Green
2023-06-25 21:42 ` David Laight
2023-06-26 14:14 ` Conor Dooley
2023-06-27 19:11 ` Evan Green
2023-06-29 14:03 ` Conor Dooley
2023-06-29 23:10 ` Evan Green
2023-06-26 21:42 ` Jessica Clarke
2023-06-27 19:11 ` Evan Green
2023-06-29 12:05 ` David Laight
2023-06-29 23:09 ` Evan Green
2023-06-30 8:29 ` David Laight
2023-06-23 22:20 ` [PATCH 2/2] RISC-V: alternative: Remove feature_probe_func Evan Green
2023-06-26 13:07 ` Conor Dooley
2023-06-30 21:57 ` Evan Green
2023-06-24 10:08 ` [PATCH 0/2] RISC-V: Probe for misaligned access speed Conor Dooley
2023-06-26 19:48 ` Evan Green
2023-06-24 10:22 ` Yangyu Chen
2023-06-26 9:24 ` David Laight [this message]
2023-06-26 19:49 ` Evan Green
2023-06-26 19:48 ` Evan Green
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=253bad9e83cd4890b29dd89a3d5a1937@AcuMS.aculab.com \
--to=david.laight@aculab.com \
--cc=ajones@ventanamicro.com \
--cc=alexghiti@rivosinc.com \
--cc=andy.chiu@sifive.com \
--cc=aou@eecs.berkeley.edu \
--cc=apatel@ventanamicro.com \
--cc=conor.dooley@microchip.com \
--cc=corbet@lwn.net \
--cc=cyy@cyyself.name \
--cc=evan@rivosinc.com \
--cc=greentime.hu@sifive.com \
--cc=guoren@kernel.org \
--cc=heiko.stuebner@vrull.eu \
--cc=heiko@sntech.de \
--cc=jeeheng.sia@starfivetech.com \
--cc=jszhang@kernel.org \
--cc=leyfoon.tan@starfivetech.com \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=lizhengyu3@huawei.com \
--cc=masahiroy@kernel.org \
--cc=palmer@dabbelt.com \
--cc=palmer@rivosinc.com \
--cc=paul.walmsley@sifive.com \
--cc=rdunlap@infradead.org \
--cc=samuel@sholland.org \
--cc=shosie@rivosinc.com \
--cc=sunilvl@ventanamicro.com \
--cc=xianting.tian@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®