* [PATCH] PM / wakeup: Drop redundant check from device_set_wakeup_enable()
@ 2017-12-26 0:50 Rafael J. Wysocki
2018-01-02 13:44 ` Ulf Hansson
0 siblings, 1 reply; 2+ messages in thread
From: Rafael J. Wysocki @ 2017-12-26 0:50 UTC (permalink / raw)
To: Linux PM; +Cc: LKML
From: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Since both device_wakeup_enable() and device_wakeup_disable() check
if dev is not NULL and whether or not power.can_wakeup is set for it,
device_set_wakeup_enable() doesn't have to do that, so drop that
check from it.
No intentional changes in functionality.
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
---
drivers/base/power/wakeup.c | 3 ---
1 file changed, 3 deletions(-)
Index: linux-pm/drivers/base/power/wakeup.c
===================================================================
--- linux-pm.orig/drivers/base/power/wakeup.c
+++ linux-pm/drivers/base/power/wakeup.c
@@ -464,9 +464,6 @@ EXPORT_SYMBOL_GPL(device_init_wakeup);
*/
int device_set_wakeup_enable(struct device *dev, bool enable)
{
- if (!dev || !dev->power.can_wakeup)
- return -EINVAL;
-
return enable ? device_wakeup_enable(dev) : device_wakeup_disable(dev);
}
EXPORT_SYMBOL_GPL(device_set_wakeup_enable);
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] PM / wakeup: Drop redundant check from device_set_wakeup_enable()
2017-12-26 0:50 [PATCH] PM / wakeup: Drop redundant check from device_set_wakeup_enable() Rafael J. Wysocki
@ 2018-01-02 13:44 ` Ulf Hansson
0 siblings, 0 replies; 2+ messages in thread
From: Ulf Hansson @ 2018-01-02 13:44 UTC (permalink / raw)
To: Rafael J. Wysocki; +Cc: Linux PM, LKML
On 26 December 2017 at 01:50, Rafael J. Wysocki <rjw@rjwysocki.net> wrote:
> From: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
>
> Since both device_wakeup_enable() and device_wakeup_disable() check
> if dev is not NULL and whether or not power.can_wakeup is set for it,
> device_set_wakeup_enable() doesn't have to do that, so drop that
> check from it.
>
> No intentional changes in functionality.
>
> Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Reviewed-by: Ulf Hansson <ulf.hansson@linaro.org>
Kind regards
Uffe
> ---
> drivers/base/power/wakeup.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> Index: linux-pm/drivers/base/power/wakeup.c
> ===================================================================
> --- linux-pm.orig/drivers/base/power/wakeup.c
> +++ linux-pm/drivers/base/power/wakeup.c
> @@ -464,9 +464,6 @@ EXPORT_SYMBOL_GPL(device_init_wakeup);
> */
> int device_set_wakeup_enable(struct device *dev, bool enable)
> {
> - if (!dev || !dev->power.can_wakeup)
> - return -EINVAL;
> -
> return enable ? device_wakeup_enable(dev) : device_wakeup_disable(dev);
> }
> EXPORT_SYMBOL_GPL(device_set_wakeup_enable);
>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-01-02 13:44 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-12-26 0:50 [PATCH] PM / wakeup: Drop redundant check from device_set_wakeup_enable() Rafael J. Wysocki
2018-01-02 13:44 ` Ulf Hansson
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®