From: Javier Martinez Canillas <javierm@redhat.com>
To: Tom Fitzhenry <tom@tom-fitzhenry.me.uk>,
Lee Jones <lee@kernel.org>,
Neil Armstrong <neil.armstrong@linaro.org>
Cc: Ondrej Jirman <megi@xff.cz>, Martijn Braam <martijn@brixit.nl>,
linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mfd: rk808: re-add rk808-clkout to RK818
Date: Thu, 29 Dec 2022 19:27:20 +0100 [thread overview]
Message-ID: <257b19f7-89ce-39cd-a403-b5a03d92c7bf@redhat.com> (raw)
In-Reply-To: <20221228140708.26431-1-tom@tom-fitzhenry.me.uk>
Hello Tom,
On 12/28/22 15:07, Tom Fitzhenry wrote:
> Fixes RK818 (e.g. on Pinephone Pro) to register its clock, without which
> dependent devices (e.g. wifi/BT, via sdio-wifi-pwrseq) fail to probe.
>
> This line was removed in commit 3633daacea2e
> ("mfd: rk808: Permit having multiple PMIC instances"), but only from RK818.
>
Maybe add a Fixes: 3633daacea2e ("mfd: rk808: Permit having multiple PMIC instances") ?
> Signed-off-by: Tom Fitzhenry <tom@tom-fitzhenry.me.uk>
> ---
The patch looks good to me.
Reviewed-by: Javier Martinez Canillas <javierm@redhat.com>
--
Best regards,
Javier Martinez Canillas
Core Platforms
Red Hat
next prev parent reply other threads:[~2022-12-29 18:30 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-28 14:07 Tom Fitzhenry
2022-12-29 18:27 ` Javier Martinez Canillas [this message]
2023-01-02 11:15 ` Tom Fitzhenry
2023-01-02 10:06 ` Neil Armstrong
2023-01-02 11:13 ` Tom Fitzhenry
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=257b19f7-89ce-39cd-a403-b5a03d92c7bf@redhat.com \
--to=javierm@redhat.com \
--cc=lee@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=martijn@brixit.nl \
--cc=megi@xff.cz \
--cc=neil.armstrong@linaro.org \
--cc=tom@tom-fitzhenry.me.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®