mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Neil Armstrong <neil.armstrong@linaro.org>
To: Tom Fitzhenry <tom@tom-fitzhenry.me.uk>, Lee Jones <lee@kernel.org>
Cc: Ondrej Jirman <megi@xff.cz>,
	Javier Martinez Canillas <javierm@redhat.com>,
	Martijn Braam <martijn@brixit.nl>,
	linux-rockchip@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mfd: rk808: re-add rk808-clkout to RK818
Date: Mon, 2 Jan 2023 11:06:12 +0100	[thread overview]
Message-ID: <3f40e58a-dcd2-7c9a-1a9d-cae36719352f@linaro.org> (raw)
In-Reply-To: <20221228140708.26431-1-tom@tom-fitzhenry.me.uk>

On 28/12/2022 15:07, Tom Fitzhenry wrote:
> Fixes RK818 (e.g. on Pinephone Pro) to register its clock, without which
> dependent devices (e.g. wifi/BT, via sdio-wifi-pwrseq) fail to probe.
> 
> This line was removed in commit 3633daacea2e
> ("mfd: rk808: Permit having multiple PMIC instances"), but only from RK818.
> 
> Signed-off-by: Tom Fitzhenry <tom@tom-fitzhenry.me.uk>
> ---
>   drivers/mfd/rk808.c | 1 +
>   1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/mfd/rk808.c b/drivers/mfd/rk808.c
> index f44fc3f080a8..0f22ef61e817 100644
> --- a/drivers/mfd/rk808.c
> +++ b/drivers/mfd/rk808.c
> @@ -189,6 +189,7 @@ static const struct mfd_cell rk817s[] = {
>   };
>   
>   static const struct mfd_cell rk818s[] = {
> +	{ .name = "rk808-clkout", .id = PLATFORM_DEVID_NONE, },
>   	{ .name = "rk808-regulator", .id = PLATFORM_DEVID_NONE, },
>   	{
>   		.name = "rk808-rtc",
> 
> base-commit: c76083fac3bae1a87ae3d005b5cb1cbc761e31d5

Sorry, my bad...


Acked-by: Neil Armstrong <neil.armstrong@linaro.org>

Thanks,
Neil

  parent reply	other threads:[~2023-01-02 10:07 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-12-28 14:07 Tom Fitzhenry
2022-12-29 18:27 ` Javier Martinez Canillas
2023-01-02 11:15   ` Tom Fitzhenry
2023-01-02 10:06 ` Neil Armstrong [this message]
2023-01-02 11:13   ` Tom Fitzhenry

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3f40e58a-dcd2-7c9a-1a9d-cae36719352f@linaro.org \
    --to=neil.armstrong@linaro.org \
    --cc=javierm@redhat.com \
    --cc=lee@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rockchip@lists.infradead.org \
    --cc=martijn@brixit.nl \
    --cc=megi@xff.cz \
    --cc=tom@tom-fitzhenry.me.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®