mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jose Abreu <Jose.Abreu@synopsys.com>
To: Sylwester Nawrocki <snawrocki@kernel.org>,
	Jose Abreu <Jose.Abreu@synopsys.com>
Cc: <linux-media@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
	"Carlos Palminha" <CARLOS.PALMINHA@synopsys.com>,
	Rob Herring <robh+dt@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	Mauro Carvalho Chehab <mchehab@kernel.org>,
	Hans Verkuil <hans.verkuil@cisco.com>,
	<devicetree@vger.kernel.org>
Subject: Re: [PATCH v6 4/4] dt-bindings: media: Document Synopsys Designware HDMI RX
Date: Fri, 7 Jul 2017 10:31:00 +0100	[thread overview]
Message-ID: <258a880c-8b4d-8201-b90a-44ed4d351daa@synopsys.com> (raw)
In-Reply-To: <b0ba8226-972e-a997-e456-c342603b2ffd@kernel.org>

On 06-07-2017 21:30, Sylwester Nawrocki wrote:
> On 07/06/2017 12:24 PM, Jose Abreu wrote:
>>>> +- edid-phandle: phandle to the EDID handler block.
>>> Could you make this property optional and when it is missing assume that device
>>> corresponding to the parent node of this node handles EDID? This way we could
>>> avoid having property pointing to the parent node.
>> Hmm, this is for the CEC notifier. Do you mean I should grab the
>> parent device for the notifier? This property is already optional
>> if cec is not enabled though.
>  
> Yes, device associated with the parent node. Something like:
>
>  - edid-phandle - phandle to the EDID handler block; if this property is
>   not specified it is assumed that EDID is handled by device described 
>   by parent node of the HDMI RX node
>
> Not sure if it is any better than always requiring edid-phandle property,
> even when it is pointing to the parent node. We would need a DT maintainer's
> opinion on that.

I will change and resend. I also have to fix a kbuild error when
cec is not enabled.

Best regards,
Jose Miguel Abreu

>
> --
> Thanks,
> Sylwester

      reply	other threads:[~2017-07-07  9:31 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-04 14:11 [PATCH v6 0/4] Synopsys Designware HDMI Video Capture Controller + PHY Jose Abreu
2017-07-04 14:11 ` [PATCH v6 1/4] [media] platform: Add Synopsys Designware HDMI RX PHY e405 Driver Jose Abreu
2017-07-04 14:11 ` [PATCH v6 2/4] [media] platform: Add Synopsys Designware HDMI RX Controller Driver Jose Abreu
2017-07-06 20:52   ` kbuild test robot
2017-07-07  9:34     ` Jose Abreu
2017-07-07  9:52       ` Hans Verkuil
2017-07-04 14:11 ` [PATCH v6 3/4] MAINTAINERS: Add entry for Synopsys Designware HDMI drivers Jose Abreu
2017-07-04 14:11 ` [PATCH v6 4/4] dt-bindings: media: Document Synopsys Designware HDMI RX Jose Abreu
2017-07-05 20:52   ` Sylwester Nawrocki
2017-07-06 10:24     ` Jose Abreu
2017-07-06 20:30       ` Sylwester Nawrocki
2017-07-07  9:31         ` Jose Abreu [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=258a880c-8b4d-8201-b90a-44ed4d351daa@synopsys.com \
    --to=jose.abreu@synopsys.com \
    --cc=CARLOS.PALMINHA@synopsys.com \
    --cc=devicetree@vger.kernel.org \
    --cc=hans.verkuil@cisco.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=mark.rutland@arm.com \
    --cc=mchehab@kernel.org \
    --cc=robh+dt@kernel.org \
    --cc=snawrocki@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®