mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Jose Abreu <Jose.Abreu@synopsys.com>
To: kbuild test robot <lkp@intel.com>, Jose Abreu <Jose.Abreu@synopsys.com>
Cc: <kbuild-all@01.org>, <linux-media@vger.kernel.org>,
	<linux-kernel@vger.kernel.org>,
	Carlos Palminha <CARLOS.PALMINHA@synopsys.com>,
	Mauro Carvalho Chehab <mchehab@kernel.org>,
	Hans Verkuil <hans.verkuil@cisco.com>,
	Sylwester Nawrocki <snawrocki@kernel.org>
Subject: Re: [PATCH v6 2/4] [media] platform: Add Synopsys Designware HDMI RX Controller Driver
Date: Fri, 7 Jul 2017 10:34:04 +0100	[thread overview]
Message-ID: <30db25dd-3ef1-ea85-ed41-97ee315bd5c7@synopsys.com> (raw)
In-Reply-To: <201707070407.vA4LTBMK%fengguang.wu@intel.com>

On 06-07-2017 21:52, kbuild test robot wrote:
>    drivers/media//platform/dwc/dw-hdmi-rx.c: In function 'dw_hdmi_registered':
>>> drivers/media//platform/dwc/dw-hdmi-rx.c:1452:9: error: implicit declaration of function 'v4l2_async_subnotifier_register' [-Werror=implicit-function-declaration]
>      return v4l2_async_subnotifier_register(&dw_dev->sd,
>             ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>    drivers/media//platform/dwc/dw-hdmi-rx.c: In function 'dw_hdmi_unregistered':
>>> drivers/media//platform/dwc/dw-hdmi-rx.c:1462:2: error: implicit declaration of function 'v4l2_async_subnotifier_unregister' [-Werror=implicit-function-declaration]
>      v4l2_async_subnotifier_unregister(&dw_dev->v4l2_notifier);

This one is expected. Required patch was not merged yet.

>      ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
>    drivers/media//platform/dwc/dw-hdmi-rx.c: In function 'dw_hdmi_parse_dt':
>    drivers/media//platform/dwc/dw-hdmi-rx.c:1555:22: warning: unused variable 'notifier' [-Wunused-variable]
>      struct device_node *notifier, *phy_node, *np = dw_dev->of_node;
>                          ^~~~~~~~
>    drivers/media//platform/dwc/dw-hdmi-rx.c: In function 'dw_hdmi_rx_probe':
>    drivers/media//platform/dwc/dw-hdmi-rx.c:1765:1: warning: label 'err_phy' defined but not used [-Wunused-label]
>     err_phy:
>     ^~~~~~~
>    cc1: some warnings being treated as errors
>
>

These two is due to cec not being enabled. I hate to wrap this
around a #ifdef but is either this or extract cec to a separate
file, which I don't think is the best solution because the cec
code is quite small.

Best regards,
Jose Miguel Abreu

  reply	other threads:[~2017-07-07  9:34 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-07-04 14:11 [PATCH v6 0/4] Synopsys Designware HDMI Video Capture Controller + PHY Jose Abreu
2017-07-04 14:11 ` [PATCH v6 1/4] [media] platform: Add Synopsys Designware HDMI RX PHY e405 Driver Jose Abreu
2017-07-04 14:11 ` [PATCH v6 2/4] [media] platform: Add Synopsys Designware HDMI RX Controller Driver Jose Abreu
2017-07-06 20:52   ` kbuild test robot
2017-07-07  9:34     ` Jose Abreu [this message]
2017-07-07  9:52       ` Hans Verkuil
2017-07-04 14:11 ` [PATCH v6 3/4] MAINTAINERS: Add entry for Synopsys Designware HDMI drivers Jose Abreu
2017-07-04 14:11 ` [PATCH v6 4/4] dt-bindings: media: Document Synopsys Designware HDMI RX Jose Abreu
2017-07-05 20:52   ` Sylwester Nawrocki
2017-07-06 10:24     ` Jose Abreu
2017-07-06 20:30       ` Sylwester Nawrocki
2017-07-07  9:31         ` Jose Abreu

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=30db25dd-3ef1-ea85-ed41-97ee315bd5c7@synopsys.com \
    --to=jose.abreu@synopsys.com \
    --cc=CARLOS.PALMINHA@synopsys.com \
    --cc=hans.verkuil@cisco.com \
    --cc=kbuild-all@01.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-media@vger.kernel.org \
    --cc=lkp@intel.com \
    --cc=mchehab@kernel.org \
    --cc=snawrocki@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome