Re: [PATCH 2/7] drivers:staging: Kconfig, Makefile for TI's ST ldisc

Re: [PATCH 2/7] drivers:staging: Kconfig, Makefile for TI's ST ldisc

[Pavan Savoy]

--- On Wed, 24/3/10, Greg KH <gregkh@suse.de> wrote:

> From: Greg KH <gregkh@suse.de>
> Subject: Re: [PATCH 2/7] drivers:staging: Kconfig, Makefile for TI's ST ldisc
> To: pavan_savoy@ti.com
> Cc: alan@lxorguk.ukuu.org.uk, linux-kernel@vger.kernel.org, pavan_savoy@yahoo.co.in
> Date: Wednesday, 24 March, 2010, 8:00 AM
> On Tue, Mar 23, 2010 at 03:41:10PM
> -0500, pavan_savoy@ti.com
> wrote:
> > From: Pavan Savoy <pavan_savoy@ti.com>
> > 
> > This change adds the Kconfig and Make file for TI's
> > ST line discipline driver and the BlueZ driver for BT
> > core of the TI BT/FM/GPS combo chip.
> > 
> > Signed-off-by: Pavan Savoy <pavan_savoy@ti.com>
> > ---
> >  drivers/staging/Kconfig     
>   |    2 ++
> >  drivers/staging/Makefile   
>    |    1 +
> 
> To add a new staging driver, I need a TODO file that lists
> what needs to
> be done to the code in order to get it merged into the main
> portion of
> the kernel, and who is responsible for it.  Look at
> the other
> drivers/staging/*/TODO files for examples of what to do.

Oh - BTW, I've added patches on tree 
http://github.com/PavanSavoy/testGit/tree/patch_branch

also, got by git clone git clone git://github.com/PavanSavoy/testGit.git
and checking out --track -b patch_branch origin/patch_branch
have fixed the ordering of patches and TODO/ABI moved into staging.

Just in case, you decide to put this in staging/ i can re-mail them too.

> thanks,
> 
> greg k-h
> --
> To unsubscribe from this list: send the line "unsubscribe
> linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at  http://www.tux.org/lkml/
>




      Your Mail works best with the New Yahoo Optimized IE8. Get it NOW! http://downloads.yahoo.com/in/internetexplorer/

Re: [PATCH 2/7] drivers:staging: Kconfig, Makefile for TI's ST ldisc

[Greg KH]

On Tue, Mar 23, 2010 at 03:41:10PM -0500, pavan_savoy@ti.com wrote:
> From: Pavan Savoy <pavan_savoy@ti.com>
> 
> This change adds the Kconfig and Make file for TI's
> ST line discipline driver and the BlueZ driver for BT
> core of the TI BT/FM/GPS combo chip.
> 
> Signed-off-by: Pavan Savoy <pavan_savoy@ti.com>
> ---
>  drivers/staging/Kconfig        |    2 ++
>  drivers/staging/Makefile       |    1 +

To add a new staging driver, I need a TODO file that lists what needs to
be done to the code in order to get it merged into the main portion of
the kernel, and who is responsible for it.  Look at the other
drivers/staging/*/TODO files for examples of what to do.

thanks,

greg k-h

Re: [PATCH 2/7] drivers:staging: Kconfig, Makefile for TI's ST ldisc

[Greg KH]

On Tue, Mar 23, 2010 at 03:41:10PM -0500, pavan_savoy@ti.com wrote:
> From: Pavan Savoy <pavan_savoy@ti.com>
> 
> This change adds the Kconfig and Make file for TI's
> ST line discipline driver and the BlueZ driver for BT
> core of the TI BT/FM/GPS combo chip.
> 
> Signed-off-by: Pavan Savoy <pavan_savoy@ti.com>
> ---
>  drivers/staging/Kconfig        |    2 ++
>  drivers/staging/Makefile       |    1 +
>  drivers/staging/ti-st/Kconfig  |   24 ++++++++++++++++++++++++
>  drivers/staging/ti-st/Makefile |    7 +++++++

Again, you just broke the build.

Please fix the ordering of your patches.

thanks,

greg k-h

[PATCH 2/7] drivers:staging: Kconfig, Makefile for TI's ST ldisc

[pavan_savoy]

From: Pavan Savoy <pavan_savoy@ti.com>

This change adds the Kconfig and Make file for TI's
ST line discipline driver and the BlueZ driver for BT
core of the TI BT/FM/GPS combo chip.

Signed-off-by: Pavan Savoy <pavan_savoy@ti.com>
---
 drivers/staging/Kconfig        |    2 ++
 drivers/staging/Makefile       |    1 +
 drivers/staging/ti-st/Kconfig  |   24 ++++++++++++++++++++++++
 drivers/staging/ti-st/Makefile |    7 +++++++
 4 files changed, 34 insertions(+), 0 deletions(-)
 create mode 100644 drivers/staging/ti-st/Kconfig
 create mode 100644 drivers/staging/ti-st/Makefile

diff --git a/drivers/staging/Kconfig b/drivers/staging/Kconfig
index 5589616..209fe00 100644
--- a/drivers/staging/Kconfig
+++ b/drivers/staging/Kconfig
@@ -141,5 +141,7 @@ source "drivers/staging/dt3155/Kconfig"
 
 source "drivers/staging/crystalhd/Kconfig"
 
+source "drivers/staging/ti-st/Kconfig"
+
 endif # !STAGING_EXCLUDE_BUILD
 endif # STAGING
diff --git a/drivers/staging/Makefile b/drivers/staging/Makefile
index ec45d4b..b41aa1a 100644
--- a/drivers/staging/Makefile
+++ b/drivers/staging/Makefile
@@ -52,3 +52,4 @@ obj-$(CONFIG_PCMCIA_NETWAVE)	+= netwave/
 obj-$(CONFIG_FB_SM7XX)		+= sm7xx/
 obj-$(CONFIG_DT3155)		+= dt3155/
 obj-$(CONFIG_CRYSTALHD)		+= crystalhd/
+obj-$(CONFIG_TI_ST)		+= ti-st/
diff --git a/drivers/staging/ti-st/Kconfig b/drivers/staging/ti-st/Kconfig
new file mode 100644
index 0000000..120e8db
--- /dev/null
+++ b/drivers/staging/ti-st/Kconfig
@@ -0,0 +1,24 @@
+#
+# TI's shared transport line discipline and the protocol
+# drivers (BT, FM and GPS)
+#
+menu "Texas Instruments shared transport line discipline"
+config TI_ST
+	tristate "shared transport core driver"
+	select FW_LOADER
+	help
+	  This enables the shared transport core driver for TI
+	  BT / FM and GPS combo chips. This enables protocol drivers
+	  to register themselves with core and send data, the responses
+	  are returned to relevant protocol drivers based on their
+	  packet types.
+
+config ST_BT
+	tristate "BlueZ bluetooth driver for ST"
+	depends on BT
+	select TI_ST
+	help
+	  This enables the Bluetooth driver for TI BT/FM/GPS combo devices.
+	  This makes use of shared transport line discipline core driver to
+	  communicate with the BT core of the combo chip.
+endmenu
diff --git a/drivers/staging/ti-st/Makefile b/drivers/staging/ti-st/Makefile
new file mode 100644
index 0000000..0167d1d
--- /dev/null
+++ b/drivers/staging/ti-st/Makefile
@@ -0,0 +1,7 @@
+#
+# Makefile for TI's shared transport line discipline
+# and its protocol drivers (BT, FM, GPS)
+#
+obj-$(CONFIG_TI_ST) 		+= st_drv.o
+st_drv-objs			:= st_core.o st_kim.o st_ll.o
+obj-$(CONFIG_ST_BT) 		+= bt_drv.o
-- 
1.5.4.3