* [PATCH] drm/client: Fix error code in drm_client_buffer_vmap_local()
@ 2024-07-24 16:09 Dan Carpenter
2024-07-27 15:20 ` Dmitry Osipenko
2024-07-29 6:48 ` Thomas Zimmermann
0 siblings, 2 replies; 3+ messages in thread
From: Dan Carpenter @ 2024-07-24 16:09 UTC (permalink / raw)
To: Thomas Zimmermann
Cc: Maarten Lankhorst, Maxime Ripard, David Airlie, Daniel Vetter,
Zack Rusin, Christian König, Dmitry Osipenko, dri-devel,
linux-kernel, kernel-janitors
This function accidentally returns zero/success on the failure path.
It leads to locking issues and an uninitialized *map_copy in the
caller.
Fixes: b4b0193e83cb ("drm/fbdev-generic: Fix locking with drm_client_buffer_vmap_local()")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
---
drivers/gpu/drm/drm_client.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/drm_client.c b/drivers/gpu/drm/drm_client.c
index 2803ac111bbd..bfedcbf516db 100644
--- a/drivers/gpu/drm/drm_client.c
+++ b/drivers/gpu/drm/drm_client.c
@@ -355,7 +355,7 @@ int drm_client_buffer_vmap_local(struct drm_client_buffer *buffer,
err_drm_gem_vmap_unlocked:
drm_gem_unlock(gem);
- return 0;
+ return ret;
}
EXPORT_SYMBOL(drm_client_buffer_vmap_local);
--
2.43.0
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] drm/client: Fix error code in drm_client_buffer_vmap_local()
2024-07-24 16:09 [PATCH] drm/client: Fix error code in drm_client_buffer_vmap_local() Dan Carpenter
@ 2024-07-27 15:20 ` Dmitry Osipenko
2024-07-29 6:48 ` Thomas Zimmermann
1 sibling, 0 replies; 3+ messages in thread
From: Dmitry Osipenko @ 2024-07-27 15:20 UTC (permalink / raw)
To: Dan Carpenter, Thomas Zimmermann
Cc: Maarten Lankhorst, Maxime Ripard, David Airlie, Daniel Vetter,
Zack Rusin, Christian König, dri-devel, linux-kernel,
kernel-janitors
On 7/24/24 19:09, Dan Carpenter wrote:
> This function accidentally returns zero/success on the failure path.
> It leads to locking issues and an uninitialized *map_copy in the
> caller.
>
> Fixes: b4b0193e83cb ("drm/fbdev-generic: Fix locking with drm_client_buffer_vmap_local()")
> Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
> ---
> drivers/gpu/drm/drm_client.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/drm_client.c b/drivers/gpu/drm/drm_client.c
> index 2803ac111bbd..bfedcbf516db 100644
> --- a/drivers/gpu/drm/drm_client.c
> +++ b/drivers/gpu/drm/drm_client.c
> @@ -355,7 +355,7 @@ int drm_client_buffer_vmap_local(struct drm_client_buffer *buffer,
>
> err_drm_gem_vmap_unlocked:
> drm_gem_unlock(gem);
> - return 0;
> + return ret;
> }
> EXPORT_SYMBOL(drm_client_buffer_vmap_local);
>
Reviewed-by: Dmitry Osipenko <dmitry.osipenko@collabora.com>
--
Best regards,
Dmitry
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] drm/client: Fix error code in drm_client_buffer_vmap_local()
2024-07-24 16:09 [PATCH] drm/client: Fix error code in drm_client_buffer_vmap_local() Dan Carpenter
2024-07-27 15:20 ` Dmitry Osipenko
@ 2024-07-29 6:48 ` Thomas Zimmermann
1 sibling, 0 replies; 3+ messages in thread
From: Thomas Zimmermann @ 2024-07-29 6:48 UTC (permalink / raw)
To: Dan Carpenter
Cc: Maarten Lankhorst, Maxime Ripard, David Airlie, Daniel Vetter,
Zack Rusin, Christian König, Dmitry Osipenko, dri-devel,
linux-kernel, kernel-janitors
Am 24.07.24 um 18:09 schrieb Dan Carpenter:
> This function accidentally returns zero/success on the failure path.
> It leads to locking issues and an uninitialized *map_copy in the
> caller.
>
> Fixes: b4b0193e83cb ("drm/fbdev-generic: Fix locking with drm_client_buffer_vmap_local()")
> Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Reviewed-by: Thomas Zimmermann <tzimmermann@suse.de>
> ---
> drivers/gpu/drm/drm_client.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/drm_client.c b/drivers/gpu/drm/drm_client.c
> index 2803ac111bbd..bfedcbf516db 100644
> --- a/drivers/gpu/drm/drm_client.c
> +++ b/drivers/gpu/drm/drm_client.c
> @@ -355,7 +355,7 @@ int drm_client_buffer_vmap_local(struct drm_client_buffer *buffer,
>
> err_drm_gem_vmap_unlocked:
> drm_gem_unlock(gem);
> - return 0;
> + return ret;
> }
> EXPORT_SYMBOL(drm_client_buffer_vmap_local);
>
--
--
Thomas Zimmermann
Graphics Driver Developer
SUSE Software Solutions Germany GmbH
Frankenstrasse 146, 90461 Nuernberg, Germany
GF: Ivo Totev, Andrew Myers, Andrew McDonald, Boudien Moerman
HRB 36809 (AG Nuernberg)
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2024-07-29 6:48 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-07-24 16:09 [PATCH] drm/client: Fix error code in drm_client_buffer_vmap_local() Dan Carpenter
2024-07-27 15:20 ` Dmitry Osipenko
2024-07-29 6:48 ` Thomas Zimmermann
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®