mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Anand Jahagirdar" <anandjigar@gmail.com>
To: linux-kernel@vger.kernel.org, security@kernel.org,
	"Andrew Morton" <akpm@linux-foundation.org>,
	akpm@digeo.com, "Daniel Hazelton" <dhazelton@enter.net>,
	"Jens Axboe" <jens.axboe@oracle.com>,
	"Jiri Kosina" <jikos@jikos.cz>
Subject: Patch related with Fork Bobmbing Attack
Date: Tue, 12 Jun 2007 22:19:49 +0530	[thread overview]
Message-ID: <25ae38200706120949vaeb8e0ascd182ef2f709d0fc@mail.gmail.com> (raw)

[-- Attachment #1: Type: text/plain, Size: 1057 bytes --]

Hello All
              As per the discussion in the thread with subject as
Patch Related with Fork Bombing Attack on LKML, I request you for the
inclusion of my attached patch named "fork.patch".

Summery of the Patch:

This patch warns the administrator about the fork bombing attack
(whenever any user is crossing its process limit). I have used
printk_ratelimit function in this patch. This function helps to
prevent flooding of syslog and prints message as per the values set by
root user in following files:-

1) /proc/sys/kernel/printk_ratelimit:- This file contains value for,
how many times message should be printed in syslog.

2) /proc/sys/kernel/printk_ratelimit_burst: - This file contains value
for, after how much time message should be repeated.

This patch is really helpful for administrator/root user from security
point of view. They can take action against attacker by looking at
syslog messages related with fork bombing attack.

Added comments will definitely help developers.


Signed-Off-by: Anand Jahagirdar <anandjigar@gmail.com>

[-- Attachment #2: fork.patch --]
[-- Type: text/plain, Size: 1032 bytes --]

Index: root/Desktop/a1/linux-2.6.17.tar.bz2_FILES/linux-2.6.17/kernel/fork.c
===================================================================
--- root.orig/Desktop/a1/linux-2.6.17.tar.bz2_FILES/linux-2.6.17/kernel/fork.c	2007-06-05 19:16:28.000000000 +0530
+++ root/Desktop/a1/linux-2.6.17.tar.bz2_FILES/linux-2.6.17/kernel/fork.c	2007-06-05 19:18:07.000000000 +0530
@@ -958,11 +958,18 @@
 	retval = -EAGAIN;
 	
 
+	/*
+         * following code does not allow Non Root User to cross its process
+         * limit. it alerts administrator about fork bombing attack and prevents
+         * it.
+         */
 	if (atomic_read(&p->user->processes) >= p->signal->rlim[RLIMIT_NPROC].rlim_cur) 
 		if (!capable(CAP_SYS_ADMIN) && !capable(CAP_SYS_RESOURCE) &&
-				p->user != &root_user) 
-	
+				p->user != &root_user) {
+			if (printk_ratelimit())
+                                printk(KERN_CRIT"User with uid %d is crossing its process limit\n",p->user->uid);
 			goto bad_fork_free;
+		}
 				
 
 	atomic_inc(&p->user->__count);

             reply	other threads:[~2007-06-12 16:49 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-06-12 16:49 Anand Jahagirdar [this message]
2007-06-12 17:04 ` Roland Dreier
2007-06-12 17:32   ` Jan Engelhardt
2007-06-13 11:34     ` Simon Arlott
2007-06-13 14:44       ` Daniel Hazelton
2007-06-13 20:25         ` Krzysztof Halasa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=25ae38200706120949vaeb8e0ascd182ef2f709d0fc@mail.gmail.com \
    --to=anandjigar@gmail.com \
    --cc=akpm@digeo.com \
    --cc=akpm@linux-foundation.org \
    --cc=dhazelton@enter.net \
    --cc=jens.axboe@oracle.com \
    --cc=jikos@jikos.cz \
    --cc=linux-kernel@vger.kernel.org \
    --cc=security@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®