Re: Patch related with Fork Bobmbing Attack

["Simon Arlott" <simon@fire.lp0.eu>]

On Tue, June 12, 2007 18:32, Jan Engelhardt wrote:
> On Jun 12 2007 10:04, Roland Dreier wrote:
>> > +	/*
>> > +         * following code does not allow Non Root User to cross its process
>> > +         * limit. it alerts administrator about fork bombing attack and prevents
>> > +         * it.
>> > +         */
>> >  	if (atomic_read(&p->user->processes) >= p->signal->rlim[RLIMIT_NPROC].rlim_cur)
>> >  		if (!capable(CAP_SYS_ADMIN) && !capable(CAP_SYS_RESOURCE) &&
>> > -				p->user != &root_user)
>> > -
>> > +				p->user != &root_user) {
>> > +			if (printk_ratelimit())
>> > +                                printk(KERN_CRIT"User with uid %d is crossing its process
>> limit\n",p->user->uid);
>> >  			goto bad_fork_free;
>> > +		}

Why does this need to be KERN_CRIT? You can't assume that every time a process limit is reached that it's a
fork bomb.

-- 
Simon Arlott