From: Andrzej Pietrasiewicz <andrzej.p@samsung.com>
To: Thierry Escande <thierry.escande@collabora.com>
Cc: Jacek Anaszewski <jacek.anaszewski@gmail.com>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
linux-media@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 5/6] [media] s5p-jpeg: Add support for resolution change event
Date: Tue, 20 Jun 2017 12:51:55 +0200 [thread overview]
Message-ID: <25bfed86-d208-4f70-5b55-d3eb56ba9ed5@samsung.com> (raw)
In-Reply-To: <d214a1d2-bce4-ea46-866c-6e35d16f26c9@collabora.com>
Hi Thierry,
W dniu 19.06.2017 o 15:50, Thierry Escande pisze:
> Hi Andrzej,
>
> On 16/06/2017 17:38, Andrzej Pietrasiewicz wrote:
>> Hi Thierry,
>>
>> Thank you for the patch.
>>
>> Can you give a use case for resolution change event?
> Unfortunately, the original commit does not mention any clear use case.
> I've asked to the patch author for more information.
Can you please share what you learn about it if the author gets back to you?
Now that we don't know why to apply a patch I guess we should not do it.
>
<snip>
>>> @@ -2510,43 +2567,18 @@ static void s5p_jpeg_buf_queue(struct
>>> vb2_buffer *vb)
>>> return;
>>> }
>>> - q_data = &ctx->out_q;
>>> - q_data->w = tmp.w;
>>> - q_data->h = tmp.h;
>>> - q_data->sos = tmp.sos;
>>> - memcpy(q_data->dht.marker, tmp.dht.marker,
>>> - sizeof(tmp.dht.marker));
>>> - memcpy(q_data->dht.len, tmp.dht.len, sizeof(tmp.dht.len));
>>> - q_data->dht.n = tmp.dht.n;
>>> - memcpy(q_data->dqt.marker, tmp.dqt.marker,
>>> - sizeof(tmp.dqt.marker));
>>> - memcpy(q_data->dqt.len, tmp.dqt.len, sizeof(tmp.dqt.len));
>>> - q_data->dqt.n = tmp.dqt.n;
>>> - q_data->sof = tmp.sof;
>>> - q_data->sof_len = tmp.sof_len;
>>> -
>>> - q_data = &ctx->cap_q;
>>> - q_data->w = tmp.w;
>>> - q_data->h = tmp.h;
>>
>>
>> Why is this part removed?
> This has not been removed.
> The &tmp s5p_jpeg_q_data struct was passed to s5p_jpeg_parse_hdr() and
> then copied field-by-field into ctx->out_q (through q_data pointer).
> With this change ctx->out_q is passed to s5p_jpeg_parse_hdr() and this
> avoids the copy.
It seems that changing field-by-field copying to passing a pointer
directly to s5p_jpeg_parse_hdr() is an unrelated change and as such
should be in a separate patch.
Andrzej
next prev parent reply other threads:[~2017-06-20 10:52 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-06-12 17:13 [PATCH v2 0/6] [media] s5p-jpeg: Various fixes and improvements Thierry Escande
2017-06-12 17:13 ` [PATCH v2 1/6] [media] s5p-jpeg: Reset the Codec before doing a soft reset Thierry Escande
2017-06-21 8:00 ` Andrzej Pietrasiewicz
2017-06-12 17:13 ` [PATCH v2 2/6] [media] s5p-jpeg: Call jpeg_bound_align_image after qbuf Thierry Escande
2017-06-12 17:13 ` [PATCH v2 3/6] [media] s5p-jpeg: Correct WARN_ON statement for checking subsampling Thierry Escande
2017-06-12 17:13 ` [PATCH v2 4/6] [media] s5p-jpeg: Decode 4:1:1 chroma subsampling format Thierry Escande
2017-06-20 11:57 ` Andrzej Pietrasiewicz
2017-06-12 17:13 ` [PATCH v2 5/6] [media] s5p-jpeg: Add support for resolution change event Thierry Escande
2017-06-16 15:38 ` Andrzej Pietrasiewicz
2017-06-19 13:50 ` Thierry Escande
2017-06-20 10:51 ` Andrzej Pietrasiewicz [this message]
2017-06-20 14:08 ` Thierry Escande
2017-06-12 17:13 ` [PATCH v2 6/6] [media] s5p-jpeg: Add stream error handling for Exynos5420 Thierry Escande
2017-06-16 15:30 ` Andrzej Pietrasiewicz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=25bfed86-d208-4f70-5b55-d3eb56ba9ed5@samsung.com \
--to=andrzej.p@samsung.com \
--cc=jacek.anaszewski@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=thierry.escande@collabora.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®