From: Jyri Sarha <jsarha@ti.com>
To: Baoyou Xie <baoyou.xie@linaro.org>, <tomi.valkeinen@ti.com>,
<airlied@linux.ie>
Cc: <dri-devel@lists.freedesktop.org>, <linux-kernel@vger.kernel.org>,
<arnd@arndb.de>, <xie.baoyou@zte.com.cn>, <han.fei@zte.com.cn>,
<tang.qiang007@zte.com.cn>
Subject: Re: [PATCH 1/2] drm/tilcdc: add missing header dependencies
Date: Sun, 25 Sep 2016 14:20:31 +0300 [thread overview]
Message-ID: <25c86220-42ef-9233-69a7-2dc99b3113ea@ti.com> (raw)
In-Reply-To: <1474787805-18154-1-git-send-email-baoyou.xie@linaro.org>
On 09/25/16 10:16, Baoyou Xie wrote:
> We get 4 warnings when building kernel with W=1:
> drivers/gpu/drm/tilcdc/tilcdc_tfp410.c:397:12: warning: no previous prototype for 'tilcdc_tfp410_init' [-Wmissing-prototypes]
> drivers/gpu/drm/tilcdc/tilcdc_tfp410.c:402:13: warning: no previous prototype for 'tilcdc_tfp410_fini' [-Wmissing-prototypes]
> drivers/gpu/drm/tilcdc/tilcdc_panel.c:448:12: warning: no previous prototype for 'tilcdc_panel_init' [-Wmissing-prototypes]
> drivers/gpu/drm/tilcdc/tilcdc_panel.c:453:13: warning: no previous prototype for 'tilcdc_panel_fini' [-Wmissing-prototypes]
>
> In fact, these functions are declared in
> drivers/gpu/drm/tilcdc/tilcdc_tfp410.h,
> drivers/gpu/drm/tilcdc/tilcdc_panel.h,
> so this patch adds missing header dependencies.
>
This is at least the third time you send this same patch to me even when
I replied to the first that I will pick that up:
https://lkml.org/lkml/2016/9/8/429
So please stop spamming the same patch after you have got a reply from
me. There is a few steps that take before the patches actually make
their way to linux-next, but they will get there, don't worry.
Best regards,
Jyri
> Signed-off-by: Baoyou Xie <baoyou.xie@linaro.org>
> ---
> drivers/gpu/drm/tilcdc/tilcdc_panel.c | 1 +
> drivers/gpu/drm/tilcdc/tilcdc_tfp410.c | 1 +
> 2 files changed, 2 insertions(+)
>
> diff --git a/drivers/gpu/drm/tilcdc/tilcdc_panel.c b/drivers/gpu/drm/tilcdc/tilcdc_panel.c
> index 7b36509..2134bb20 100644
> --- a/drivers/gpu/drm/tilcdc/tilcdc_panel.c
> +++ b/drivers/gpu/drm/tilcdc/tilcdc_panel.c
> @@ -25,6 +25,7 @@
> #include <drm/drm_atomic_helper.h>
>
> #include "tilcdc_drv.h"
> +#include "tilcdc_panel.h"
>
> struct panel_module {
> struct tilcdc_module base;
> diff --git a/drivers/gpu/drm/tilcdc/tilcdc_tfp410.c b/drivers/gpu/drm/tilcdc/tilcdc_tfp410.c
> index c6a70da..458043a 100644
> --- a/drivers/gpu/drm/tilcdc/tilcdc_tfp410.c
> +++ b/drivers/gpu/drm/tilcdc/tilcdc_tfp410.c
> @@ -23,6 +23,7 @@
> #include <drm/drm_atomic_helper.h>
>
> #include "tilcdc_drv.h"
> +#include "tilcdc_tfp410.h"
>
> struct tfp410_module {
> struct tilcdc_module base;
>
prev parent reply other threads:[~2016-09-25 11:20 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-25 7:16 Baoyou Xie
2016-09-25 7:16 ` [PATCH 2/2] drm/tilcdc: mark symbols static where possible Baoyou Xie
2016-09-25 11:22 ` Jyri Sarha
2016-09-25 11:20 ` Jyri Sarha [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=25c86220-42ef-9233-69a7-2dc99b3113ea@ti.com \
--to=jsarha@ti.com \
--cc=airlied@linux.ie \
--cc=arnd@arndb.de \
--cc=baoyou.xie@linaro.org \
--cc=dri-devel@lists.freedesktop.org \
--cc=han.fei@zte.com.cn \
--cc=linux-kernel@vger.kernel.org \
--cc=tang.qiang007@zte.com.cn \
--cc=tomi.valkeinen@ti.com \
--cc=xie.baoyou@zte.com.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®