From: lyude@redhat.com
To: Danilo Krummrich <dakr@kernel.org>
Cc: linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
rust-for-linux@vger.kernel.org, Miguel Ojeda <ojeda@kernel.org>,
Simona Vetter <simona@ffwll.ch>,
Alice Ryhl <aliceryhl@google.com>,
Shankari Anand <shankari.ak0208@gmail.com>,
David Airlie <airlied@gmail.com>,
Asahi Lina <lina+kernel@asahilina.net>,
Atharv Dubey <atharvd440@gmail.com>,
Daniel Almeida <daniel.almeida@collabora.com>
Subject: Re: [PATCH] rust/drm: Fixup import styles
Date: Thu, 22 Jan 2026 16:34:32 -0500 [thread overview]
Message-ID: <25d3c403781a88019340a47567ff85959b0c03bd.camel@redhat.com> (raw)
In-Reply-To: <DFVEI4KHCNFS.2IT595IZJBGGT@kernel.org>
On Thu, 2026-01-22 at 21:30 +0100, Danilo Krummrich wrote:
> On Thu Jan 22, 2026 at 9:28 PM CET, Lyude Paul wrote:
> > This is to match
> > https://docs.kernel.org/rust/coding-guidelines.html#imports
> >
> > There should be no functional changes in this patch.
>
> Thanks! While at it, can you please drop imports that are in prelude
> and use
> prelude instead?
Just a random musing - it would actually be quite nice if we could have
some sort of automated style check for this. I have to assume the linux
kernel probably isn't the only project out there with its own prelude…
next prev parent reply other threads:[~2026-01-22 21:34 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-22 20:28 Lyude Paul
2026-01-22 20:30 ` Danilo Krummrich
2026-01-22 21:34 ` lyude [this message]
2026-01-22 21:52 ` Miguel Ojeda
2026-01-22 23:01 ` Gary Guo
2026-01-23 9:37 ` Miguel Ojeda
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=25d3c403781a88019340a47567ff85959b0c03bd.camel@redhat.com \
--to=lyude@redhat.com \
--cc=airlied@gmail.com \
--cc=aliceryhl@google.com \
--cc=atharvd440@gmail.com \
--cc=dakr@kernel.org \
--cc=daniel.almeida@collabora.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=lina+kernel@asahilina.net \
--cc=linux-kernel@vger.kernel.org \
--cc=ojeda@kernel.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=shankari.ak0208@gmail.com \
--cc=simona@ffwll.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®