From: Kenny Levinsen <kl@kl.wtf>
To: "Łukasz Majczak" <lma@chromium.org>
Cc: Johan Hovold <johan@kernel.org>,
benjamin.tissoires@redhat.com, dianders@chromium.org,
dtor@chromium.org, hdegoede@redhat.com, jikos@kernel.org,
johan+linaro@kernel.org, kai.heng.feng@canonical.com,
linux-input@vger.kernel.org, linux-kernel@vger.kernel.org,
mripard@kernel.org, rad@chromium.org
Subject: Re: [PATCH v2] HID: i2c-hid: wait for i2c touchpad deep-sleep to power-up transition
Date: Tue, 23 Apr 2024 15:01:50 +0200 [thread overview]
Message-ID: <25f3ac4f-0c0d-4183-93f1-e7069579420b@kl.wtf> (raw)
In-Reply-To: <CAE5UKNqPA4SnnXyaB7Hwk0kcKMMQ_DUuxogDphnnvSGP8g1nAQ@mail.gmail.com>
On 4/23/24 1:32 PM, Łukasz Majczak wrote:
> Unfortunately, your fix doesn't help in our case as there is no sleep
> before the second call to
> i2c_hid_fetch_hid_descriptor().
Yeah, I checked with a logic analyzer and only see ~50µs delay from the
I2C timeout, and 50 is according to my quick math less than the 400 you
mention is the requirement. That means that the current resume path also
lacked a sleep, as it tried power commands in immediate succession.
I have made a v2 with your sleeps added, and added you as Co-developed-by.
Link: https://lore.kernel.org/all/20240423122518.34811-1-kl@kl.wtf/
> Saying more, this STM exposes two i2c addresses (connected physically
> to the same bus)
> one is the HID interface and the other one gives an access to the base
> firmware and is
> served by cros_ec_i2c driver and actually thanks to this driver,
> touchpad is woken up because
> In the resume path cros_ec_i2c "starts talking" through the i2c bus
> thus generating a wakeup
> interrupt.
Ah, that explains why you did not find an issue with the resume path. In
the patch-series I sent, the boot (hid descriptor fetch) and resume
(power on) wake-up paths are fully aligned so neither have to rely on
such "adjacent drivers" waking up the i2c-hid device.
prev parent reply other threads:[~2024-04-23 13:01 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-05 10:24 Lukasz Majczak
2024-04-08 3:18 ` Doug Anderson
2024-04-08 7:27 ` Johan Hovold
2024-04-09 10:53 ` Łukasz Majczak
2024-04-09 15:46 ` Johan Hovold
2024-04-11 14:23 ` Łukasz Majczak
2024-04-12 6:28 ` Kai-Heng Feng
2024-04-15 9:08 ` Johan Hovold
2024-04-15 12:26 ` Radoslaw Biernacki
2024-04-15 13:37 ` Johan Hovold
2024-04-15 10:28 ` Kenny Levinsen
2024-04-15 12:10 ` Radoslaw Biernacki
2024-04-15 12:13 ` Radoslaw Biernacki
2024-04-15 13:22 ` Johan Hovold
2024-04-15 17:14 ` Kenny Levinsen
2024-04-23 11:32 ` Łukasz Majczak
2024-04-23 13:01 ` Kenny Levinsen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=25f3ac4f-0c0d-4183-93f1-e7069579420b@kl.wtf \
--to=kl@kl.wtf \
--cc=benjamin.tissoires@redhat.com \
--cc=dianders@chromium.org \
--cc=dtor@chromium.org \
--cc=hdegoede@redhat.com \
--cc=jikos@kernel.org \
--cc=johan+linaro@kernel.org \
--cc=johan@kernel.org \
--cc=kai.heng.feng@canonical.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lma@chromium.org \
--cc=mripard@kernel.org \
--cc=rad@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®