From: Johan Hovold <johan@kernel.org>
To: Kenny Levinsen <kl@kl.wtf>
Cc: lma@chromium.org, benjamin.tissoires@redhat.com,
dianders@chromium.org, dtor@chromium.org, hdegoede@redhat.com,
jikos@kernel.org, johan+linaro@kernel.org,
kai.heng.feng@canonical.com, linux-input@vger.kernel.org,
linux-kernel@vger.kernel.org, mripard@kernel.org,
rad@chromium.org
Subject: Re: [PATCH v2] HID: i2c-hid: wait for i2c touchpad deep-sleep to power-up transition
Date: Mon, 15 Apr 2024 15:22:49 +0200 [thread overview]
Message-ID: <Zh0qKeI-YPDE-NVT@hovoldconsulting.com> (raw)
In-Reply-To: <81e1b870-37f9-4ef2-9a3d-87015f32546b@kl.wtf>
On Mon, Apr 15, 2024 at 12:28:28PM +0200, Kenny Levinsen wrote:
> > The problem is that the probe function calling i2c_smbus_read_byte()
> > is not aware that
> > uC on the other end is in a deep sleep state so the first read will
> > fail and so the whole probe.
> Well, the probe was just added to "avoid scary messages", so we could
> just do away with it and fix the "scary messages" instead.
We also use it for devices that may not be populated (e.g. an optional
touchscreen) and in that case we should not print anything.
Johan
next prev parent reply other threads:[~2024-04-15 13:22 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-04-05 10:24 Lukasz Majczak
2024-04-08 3:18 ` Doug Anderson
2024-04-08 7:27 ` Johan Hovold
2024-04-09 10:53 ` Łukasz Majczak
2024-04-09 15:46 ` Johan Hovold
2024-04-11 14:23 ` Łukasz Majczak
2024-04-12 6:28 ` Kai-Heng Feng
2024-04-15 9:08 ` Johan Hovold
2024-04-15 12:26 ` Radoslaw Biernacki
2024-04-15 13:37 ` Johan Hovold
2024-04-15 10:28 ` Kenny Levinsen
2024-04-15 12:10 ` Radoslaw Biernacki
2024-04-15 12:13 ` Radoslaw Biernacki
2024-04-15 13:22 ` Johan Hovold [this message]
2024-04-15 17:14 ` Kenny Levinsen
2024-04-23 11:32 ` Łukasz Majczak
2024-04-23 13:01 ` Kenny Levinsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=Zh0qKeI-YPDE-NVT@hovoldconsulting.com \
--to=johan@kernel.org \
--cc=benjamin.tissoires@redhat.com \
--cc=dianders@chromium.org \
--cc=dtor@chromium.org \
--cc=hdegoede@redhat.com \
--cc=jikos@kernel.org \
--cc=johan+linaro@kernel.org \
--cc=kai.heng.feng@canonical.com \
--cc=kl@kl.wtf \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lma@chromium.org \
--cc=mripard@kernel.org \
--cc=rad@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®