* [PATCH] [v2] media: platform: cros-ec: Add Moxie to the match table
@ 2025-03-27 6:59 Ken Lin
2025-03-27 14:42 ` Krzysztof Kozlowski
0 siblings, 1 reply; 4+ messages in thread
From: Ken Lin @ 2025-03-27 6:59 UTC (permalink / raw)
To: LKML
Cc: groeck, Benson Leung, Hans Verkuil, Krzysztof Kozlowski,
Mauro Carvalho Chehab, Tzung-Bi Shih, Uwe Kleine-König,
chrome-platform, linux-media
The Google Moxie device uses the same approach as the Google Brask
which enables the HDMI CEC via the cros-ec-cec driver.
Hans Verkuil <hverkuil-cisco@xs4all.nl>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Reka Norman <rekanorman@chromium.org>,
Stefan Adolfsson <sadolfsson@chromium.org>,
Signed-off-by: Ken Lin <kenlin5@quanta.corp-partner.google.com>
---
Change in v2:
- modify commit messages
---
drivers/media/cec/platform/cros-ec/cros-ec-cec.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/media/cec/platform/cros-ec/cros-ec-cec.c b/drivers/media/cec/platform/cros-ec/cros-ec-cec.c
index 12b73ea0f31d..1de5799a0579 100644
--- a/drivers/media/cec/platform/cros-ec/cros-ec-cec.c
+++ b/drivers/media/cec/platform/cros-ec/cros-ec-cec.c
@@ -329,6 +329,8 @@ static const struct cec_dmi_match cec_dmi_match_table[] = {
{ "Google", "Dexi", "0000:00:02.0", port_db_conns },
/* Google Dita */
{ "Google", "Dita", "0000:00:02.0", port_db_conns },
+ /* Google Moxie */
+ { "Google", "Moxie", "0000:00:02.0", port_b_conns },
};
static struct device *cros_ec_cec_find_hdmi_dev(struct device *dev,
--
2.25.1
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] [v2] media: platform: cros-ec: Add Moxie to the match table
2025-03-27 6:59 [PATCH] [v2] media: platform: cros-ec: Add Moxie to the match table Ken Lin
@ 2025-03-27 14:42 ` Krzysztof Kozlowski
0 siblings, 0 replies; 4+ messages in thread
From: Krzysztof Kozlowski @ 2025-03-27 14:42 UTC (permalink / raw)
To: Ken Lin, LKML
Cc: groeck, Benson Leung, Hans Verkuil, Mauro Carvalho Chehab,
Tzung-Bi Shih, Uwe Kleine-König, chrome-platform,
linux-media
On 27/03/2025 07:59, Ken Lin wrote:
> The Google Moxie device uses the same approach as the Google Brask
> which enables the HDMI CEC via the cros-ec-cec driver.
>
> Hans Verkuil <hverkuil-cisco@xs4all.nl>,
> Mauro Carvalho Chehab <mchehab@kernel.org>,
> Reka Norman <rekanorman@chromium.org>,
> Stefan Adolfsson <sadolfsson@chromium.org>,
>
<form letter>
This is a friendly reminder during the review process.
It seems my or other reviewer's previous comments were not fully
addressed. Maybe the feedback got lost between the quotes, maybe you
just forgot to apply it. Please go back to the previous discussion and
either implement all requested changes or keep discussing them.
Thank you.
</form letter>
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] UPSTREAM: media: platform: cros-ec: Add Moxie to the match table
@ 2025-03-27 2:39 Ken Lin
2025-03-28 3:09 ` [PATCH] [v2] " Ken Lin
0 siblings, 1 reply; 4+ messages in thread
From: Ken Lin @ 2025-03-27 2:39 UTC (permalink / raw)
To: LKML
Cc: Benson Leung, groeck, Hans Verkuil, Krzysztof Kozlowski,
Mauro Carvalho Chehab, Tzung-Bi Shih, Uwe Kleine-König,
chrome-platform, linux-media
The Google Moxie device uses the same approach as the Google Brask
which enables the HDMI CEC via the cros-ec-cec driver.
Hans Verkuil <hverkuil-cisco@xs4all.nl>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Reka Norman <rekanorman@chromium.org>,
Stefan Adolfsson <sadolfsson@chromium.org>,
Signed-off-by: Ken Lin <kenlin5@quanta.corp-partner.google.com>
---
drivers/media/cec/platform/cros-ec/cros-ec-cec.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/media/cec/platform/cros-ec/cros-ec-cec.c b/drivers/media/cec/platform/cros-ec/cros-ec-cec.c
index 12b73ea0f31d..1de5799a0579 100644
--- a/drivers/media/cec/platform/cros-ec/cros-ec-cec.c
+++ b/drivers/media/cec/platform/cros-ec/cros-ec-cec.c
@@ -329,6 +329,8 @@ static const struct cec_dmi_match cec_dmi_match_table[] = {
{ "Google", "Dexi", "0000:00:02.0", port_db_conns },
/* Google Dita */
{ "Google", "Dita", "0000:00:02.0", port_db_conns },
+ /* Google Moxie */
+ { "Google", "Moxie", "0000:00:02.0", port_b_conns },
};
static struct device *cros_ec_cec_find_hdmi_dev(struct device *dev,
--
2.25.1
^ permalink raw reply [flat|nested] 4+ messages in thread* [PATCH] [v2] media: platform: cros-ec: Add Moxie to the match table
2025-03-27 2:39 [PATCH] UPSTREAM: " Ken Lin
@ 2025-03-28 3:09 ` Ken Lin
2025-03-28 7:55 ` Krzysztof Kozlowski
0 siblings, 1 reply; 4+ messages in thread
From: Ken Lin @ 2025-03-28 3:09 UTC (permalink / raw)
To: kenlin5
Cc: bleung, chrome-platform, groeck, hverkuil, krzysztof.kozlowski,
linux-kernel, linux-media, mchehab, tzungbi, u.kleine-koenig
The Google Moxie device uses the same approach as the Google Brask
which enables the HDMI CEC via the cros-ec-cec driver.
Hans Verkuil <hverkuil-cisco@xs4all.nl>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Reka Norman <rekanorman@chromium.org>,
Stefan Adolfsson <sadolfsson@chromium.org>,
Signed-off-by: Ken Lin <kenlin5@quanta.corp-partner.google.com>
---
Change in v2:
- modify commit messages
---
drivers/media/cec/platform/cros-ec/cros-ec-cec.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/media/cec/platform/cros-ec/cros-ec-cec.c b/drivers/media/cec/platform/cros-ec/cros-ec-cec.c
index 12b73ea0f31d..1de5799a0579 100644
--- a/drivers/media/cec/platform/cros-ec/cros-ec-cec.c
+++ b/drivers/media/cec/platform/cros-ec/cros-ec-cec.c
@@ -329,6 +329,8 @@ static const struct cec_dmi_match cec_dmi_match_table[] = {
{ "Google", "Dexi", "0000:00:02.0", port_db_conns },
/* Google Dita */
{ "Google", "Dita", "0000:00:02.0", port_db_conns },
+ /* Google Moxie */
+ { "Google", "Moxie", "0000:00:02.0", port_b_conns },
};
static struct device *cros_ec_cec_find_hdmi_dev(struct device *dev,
--
2.25.1
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] [v2] media: platform: cros-ec: Add Moxie to the match table
2025-03-28 3:09 ` [PATCH] [v2] " Ken Lin
@ 2025-03-28 7:55 ` Krzysztof Kozlowski
0 siblings, 0 replies; 4+ messages in thread
From: Krzysztof Kozlowski @ 2025-03-28 7:55 UTC (permalink / raw)
To: Ken Lin
Cc: bleung, chrome-platform, groeck, hverkuil, linux-kernel,
linux-media, mchehab, tzungbi, u.kleine-koenig
On 28/03/2025 04:09, Ken Lin wrote:
> The Google Moxie device uses the same approach as the Google Brask
> which enables the HDMI CEC via the cros-ec-cec driver.
>
> Hans Verkuil <hverkuil-cisco@xs4all.nl>,
> Mauro Carvalho Chehab <mchehab@kernel.org>,
> Reka Norman <rekanorman@chromium.org>,
> Stefan Adolfsson <sadolfsson@chromium.org>,
>
Third email, no improvements.
Can you please slow down and read the comments, respond to them or
implement them?
Best regards,
Krzysztof
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2025-03-28 7:55 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2025-03-27 6:59 [PATCH] [v2] media: platform: cros-ec: Add Moxie to the match table Ken Lin
2025-03-27 14:42 ` Krzysztof Kozlowski
-- strict thread matches above, loose matches on Subject: below --
2025-03-27 2:39 [PATCH] UPSTREAM: " Ken Lin
2025-03-28 3:09 ` [PATCH] [v2] " Ken Lin
2025-03-28 7:55 ` Krzysztof Kozlowski
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®