From: liulongfang <liulongfang@huawei.com>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: <linux-crypto@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 2/5] crypto: hisilicon/sec - add new type of sqe for Kunpeng930
Date: Mon, 7 Dec 2020 09:10:38 +0800 [thread overview]
Message-ID: <26023bba-78cf-4d91-3510-b6d69fa4768e@huawei.com> (raw)
In-Reply-To: <20201204070359.GA26438@gondor.apana.org.au>
On 2020/12/4 15:03, Herbert Xu Wrote:
> On Thu, Nov 26, 2020 at 10:18:03AM +0800, Longfang Liu wrote:
>>
>> diff --git a/drivers/crypto/hisilicon/sec2/sec_crypto.h b/drivers/crypto/hisilicon/sec2/sec_crypto.h
>> index 0e933e7..712176b 100644
>> --- a/drivers/crypto/hisilicon/sec2/sec_crypto.h
>> +++ b/drivers/crypto/hisilicon/sec2/sec_crypto.h
>> @@ -211,6 +219,167 @@ struct sec_sqe {
>> struct sec_sqe_type2 type2;
>> };
>>
>> +#pragma pack(4)
>
> Please don't use pragma pack. Instead add the attributes as
> needed to each struct or member.
>
> Cheers,
>
OK, I will modify it in next patchset
thanks.
Longfang
next prev parent reply other threads:[~2020-12-07 1:11 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-26 2:18 [PATCH 0/5] crypto: hisilicon - add some new algorithms Longfang Liu
2020-11-26 2:18 ` [PATCH 1/5] crypto: hisilicon/hpre - add version adapt to " Longfang Liu
2020-11-26 2:18 ` [PATCH 2/5] crypto: hisilicon/sec - add new type of sqe for Kunpeng930 Longfang Liu
2020-12-04 7:03 ` Herbert Xu
2020-12-07 1:10 ` liulongfang [this message]
2020-12-07 3:43 ` liulongfang
2020-12-07 3:45 ` Herbert Xu
2020-12-07 7:46 ` liulongfang
2020-12-07 7:47 ` Herbert Xu
2020-12-07 8:48 ` liulongfang
2020-11-26 2:18 ` [PATCH 3/5] crypto: hisilicon/sec - add new skcipher mode for SEC Longfang Liu
2020-11-26 2:18 ` [PATCH 4/5] crypto: hisilicon/sec - add new AEAD " Longfang Liu
2020-11-26 2:18 ` [PATCH 5/5] crypto: hisilicon/sec - fixes some coding style Longfang Liu
2020-12-04 7:05 ` [PATCH 0/5] crypto: hisilicon - add some new algorithms Herbert Xu
2020-12-07 1:20 ` liulongfang
2020-12-07 1:33 ` Herbert Xu
2020-12-07 3:17 ` liulongfang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=26023bba-78cf-4d91-3510-b6d69fa4768e@huawei.com \
--to=liulongfang@huawei.com \
--cc=herbert@gondor.apana.org.au \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®