mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Garg, Shivank" <shivankg@amd.com>
To: "peterz@infradead.org" <peterz@infradead.org>,
	"ljs@kernel.org" <ljs@kernel.org>
Cc: "Rao, Bharata Bhasker" <bharata@amd.com>,
	"rppt@kernel.org" <rppt@kernel.org>,
	"ankur.a.arora@oracle.com" <ankur.a.arora@oracle.com>,
	"vbabka@kernel.org" <vbabka@kernel.org>,
	"david@kernel.org" <david@kernel.org>,
	"akpm@linux-foundation.org" <akpm@linux-foundation.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"surenb@google.com" <surenb@google.com>,
	"linux-mm@kvack.org" <linux-mm@kvack.org>,
	"Salunke, Hrushikesh" <Hrushikesh.Salunke@amd.com>,
	"liam@infradead.org" <liam@infradead.org>,
	"mhocko@suse.com" <mhocko@suse.com>,
	"bp@alien8.de" <bp@alien8.de>,
	"Nayak, K Prateek" <KPrateek.Nayak@amd.com>,
	"pfalcato@suse.de" <pfalcato@suse.de>,
	"x86@kernel.org" <x86@kernel.org>
Subject: Re: [PATCH v3] mm/memory: drop PROCESS_PAGES_NON_PREEMPT_BATCH
Date: Wed, 11 Nov 2026 19:07:01 +0000	[thread overview]
Message-ID: <261ef956af0843f414b4def58b13dae003c933ac.camel@amd.com> (raw)
In-Reply-To: <20261111132105.GJ2668564@noisy.programming.kicks-ass.net>

On Wed, 2026-11-11 at 14:21 +0100, Peter Zijlstra wrote:
> On Wed, Nov 11, 2026 at 01:12:06PM +0000, Lorenzo Stoakes (ARM) wrote:
> > On Wed, Nov 11, 2026 at 01:40:06PM +0100, Peter Zijlstra wrote:
> > > FWIW one could do:
> > > 
> > > 	for (int i = 0; i < nr_pages; i++) {
> > > 
> > > and forgo the earlier variable declaration.
> > 
> > I guess we all got used to the existing patterns and I for one only
> > recently found out (doh) that this was legal in kernel style (because I saw
> > it used in KVM)...
> 
> Right; which is why I keep reminding people this is now 'legal' :-)


Thank you, Peter.
Good to know this and I'll keep in mind for next time.

btw the patch is already in mm/core.git. I don't have a strong
opinion on this, but I'm happy to send a V4 if you'd prefer.

Thanks,
Shivank

      reply	other threads:[~2026-11-11 19:07 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-09 19:15 Shivank Garg
2026-11-09 22:00 ` David Hildenbrand (Arm)
2026-11-10  4:16   ` Garg, Shivank
2026-11-10 15:06 ` Lorenzo Stoakes (ARM)
2026-11-11  9:30 ` David Hildenbrand
2026-11-11 12:40 ` Peter Zijlstra
2026-11-11 13:12   ` Lorenzo Stoakes (ARM)
2026-11-11 13:21     ` Peter Zijlstra
2026-11-11 19:07       ` Garg, Shivank [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=261ef956af0843f414b4def58b13dae003c933ac.camel@amd.com \
    --to=shivankg@amd.com \
    --cc=Hrushikesh.Salunke@amd.com \
    --cc=KPrateek.Nayak@amd.com \
    --cc=akpm@linux-foundation.org \
    --cc=ankur.a.arora@oracle.com \
    --cc=bharata@amd.com \
    --cc=bp@alien8.de \
    --cc=david@kernel.org \
    --cc=liam@infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=ljs@kernel.org \
    --cc=mhocko@suse.com \
    --cc=peterz@infradead.org \
    --cc=pfalcato@suse.de \
    --cc=rppt@kernel.org \
    --cc=surenb@google.com \
    --cc=vbabka@kernel.org \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®