mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH v2] add quirks for 0x4d9:0xa096 hid device
@ 2014-07-13  8:04 microcai
  2014-07-13  8:04 ` [PATCH] add quirks for 0x04d9:0xa096 hid keyborad device microcai
  0 siblings, 1 reply; 4+ messages in thread
From: microcai @ 2014-07-13  8:04 UTC (permalink / raw)
  To: linux-usb; +Cc: jkosina, linux-kernel



Resend the patch, because I miss spell the keyborad as mouse

^ permalink raw reply	[flat|nested] 4+ messages in thread

* [PATCH] add quirks for 0x04d9:0xa096 hid keyborad device
  2014-07-13  8:04 [PATCH v2] add quirks for 0x4d9:0xa096 hid device microcai
@ 2014-07-13  8:04 ` microcai
  2014-07-13 17:49   ` Henrique de Moraes Holschuh
  0 siblings, 1 reply; 4+ messages in thread
From: microcai @ 2014-07-13  8:04 UTC (permalink / raw)
  To: linux-usb; +Cc: jkosina, linux-kernel, microcai

From: microcai <microcaicai@gmail.com>

I am using a USB keyborad that give me
"usb_submit_urb(ctrl) failed: -1" error when I plugin it.
and I need to wait for 10s for this device to be ready.

by adding this quirks, the usb keyborad is usable right after plugin
---
 drivers/hid/hid-ids.h           | 1 +
 drivers/hid/usbhid/hid-quirks.c | 1 +
 2 files changed, 2 insertions(+)

diff --git a/drivers/hid/hid-ids.h b/drivers/hid/hid-ids.h
index 34bb220..a896532 100644
--- a/drivers/hid/hid-ids.h
+++ b/drivers/hid/hid-ids.h
@@ -477,6 +477,7 @@
 #define USB_DEVICE_ID_HOLTEK_ALT_MOUSE_A070	0xa070
 #define USB_DEVICE_ID_HOLTEK_ALT_MOUSE_A072	0xa072
 #define USB_DEVICE_ID_HOLTEK_ALT_MOUSE_A081	0xa081
+#define USB_DEVICE_ID_HOLTEK_ALT_KEYBORAD_A096	0xa096
 
 #define USB_VENDOR_ID_IMATION		0x0718
 #define USB_DEVICE_ID_DISC_STAKKA	0xd000
diff --git a/drivers/hid/usbhid/hid-quirks.c b/drivers/hid/usbhid/hid-quirks.c
index 8e4ddb3..6a9bdfe 100644
--- a/drivers/hid/usbhid/hid-quirks.c
+++ b/drivers/hid/usbhid/hid-quirks.c
@@ -120,6 +120,7 @@ static const struct hid_blacklist {
 	{ USB_VENDOR_ID_SYNAPTICS, USB_DEVICE_ID_SYNAPTICS_HD, HID_QUIRK_NO_INIT_REPORTS },
 	{ USB_VENDOR_ID_SYNAPTICS, USB_DEVICE_ID_SYNAPTICS_QUAD_HD, HID_QUIRK_NO_INIT_REPORTS },
 	{ USB_VENDOR_ID_SYNAPTICS, USB_DEVICE_ID_SYNAPTICS_TP_V103, HID_QUIRK_NO_INIT_REPORTS },
+	{ USB_VENDOR_ID_HOLTEK_ALT, USB_DEVICE_ID_HOLTEK_ALT_KEYBORAD_A096, HID_QUIRK_NO_INIT_REPORTS },
 
 	{ 0, 0 }
 };
-- 
2.0.0


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] add quirks for 0x04d9:0xa096 hid keyborad device
  2014-07-13  8:04 ` [PATCH] add quirks for 0x04d9:0xa096 hid keyborad device microcai
@ 2014-07-13 17:49   ` Henrique de Moraes Holschuh
  2014-07-14  0:50     ` [PATCH v3] " microcai
  0 siblings, 1 reply; 4+ messages in thread
From: Henrique de Moraes Holschuh @ 2014-07-13 17:49 UTC (permalink / raw)
  To: microcai; +Cc: linux-usb, jkosina, linux-kernel, microcai

On Sun, 13 Jul 2014, microcai@fedoraproject.org wrote:
> From: microcai <microcaicai@gmail.com>

Real name, please.

Also, you need to add a signed-off-by line, refer to:
Documentation/SubmittingPatches
in the kernel source.

> by adding this quirks, the usb keyborad is usable right after plugin

It is spelled keyboard.  Please also fix this on the patch itself:

> +++ b/drivers/hid/hid-ids.h
> @@ -477,6 +477,7 @@
>  #define USB_DEVICE_ID_HOLTEK_ALT_MOUSE_A070	0xa070
>  #define USB_DEVICE_ID_HOLTEK_ALT_MOUSE_A072	0xa072
>  #define USB_DEVICE_ID_HOLTEK_ALT_MOUSE_A081	0xa081
> +#define USB_DEVICE_ID_HOLTEK_ALT_KEYBORAD_A096	0xa096

KEYBOARD

>  #define USB_DEVICE_ID_DISC_STAKKA	0xd000
> diff --git a/drivers/hid/usbhid/hid-quirks.c b/drivers/hid/usbhid/hid-quirks.c
> index 8e4ddb3..6a9bdfe 100644
> --- a/drivers/hid/usbhid/hid-quirks.c
> +++ b/drivers/hid/usbhid/hid-quirks.c
> @@ -120,6 +120,7 @@ static const struct hid_blacklist {
>  	{ USB_VENDOR_ID_SYNAPTICS, USB_DEVICE_ID_SYNAPTICS_HD, HID_QUIRK_NO_INIT_REPORTS },
>  	{ USB_VENDOR_ID_SYNAPTICS, USB_DEVICE_ID_SYNAPTICS_QUAD_HD, HID_QUIRK_NO_INIT_REPORTS },
>  	{ USB_VENDOR_ID_SYNAPTICS, USB_DEVICE_ID_SYNAPTICS_TP_V103, HID_QUIRK_NO_INIT_REPORTS },
> +	{ USB_VENDOR_ID_HOLTEK_ALT, USB_DEVICE_ID_HOLTEK_ALT_KEYBORAD_A096, HID_QUIRK_NO_INIT_REPORTS },

Also here, KEYBOARD

-- 
  "One disk to rule them all, One disk to find them. One disk to bring
  them all and in the darkness grind them. In the Land of Redmond
  where the shadows lie." -- The Silicon Valley Tarot
  Henrique Holschuh

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH v3] add quirks for 0x04d9:0xa096 hid keyborad device
  2014-07-13 17:49   ` Henrique de Moraes Holschuh
@ 2014-07-14  0:50     ` microcai
  0 siblings, 0 replies; 4+ messages in thread
From: microcai @ 2014-07-14  0:50 UTC (permalink / raw)
  To: Henrique de Moraes Holschuh; +Cc: linux-usb, jkosina, linux-kernel

I am using a USB keyboard that give me
"usb_submit_urb(ctrl) failed: -1" error when I plugin it.
and I need to wait for 10s for this device to be ready.

by adding this quirks, the usb keyboard is usable right after plugin
---
 drivers/hid/hid-ids.h           | 1 +
 drivers/hid/usbhid/hid-quirks.c | 1 +
 2 files changed, 2 insertions(+)

diff --git a/drivers/hid/hid-ids.h b/drivers/hid/hid-ids.h
index 34bb220..bda276b 100644
--- a/drivers/hid/hid-ids.h
+++ b/drivers/hid/hid-ids.h
@@ -477,6 +477,7 @@
 #define USB_DEVICE_ID_HOLTEK_ALT_MOUSE_A070    0xa070
 #define USB_DEVICE_ID_HOLTEK_ALT_MOUSE_A072    0xa072
 #define USB_DEVICE_ID_HOLTEK_ALT_MOUSE_A081    0xa081
+#define USB_DEVICE_ID_HOLTEK_ALT_KEYBOARD_A096 0xa096
 
 #define USB_VENDOR_ID_IMATION          0x0718
 #define USB_DEVICE_ID_DISC_STAKKA      0xd000
diff --git a/drivers/hid/usbhid/hid-quirks.c b/drivers/hid/usbhid/hid-quirks.c
index 8e4ddb3..da22a5e 100644
--- a/drivers/hid/usbhid/hid-quirks.c
+++ b/drivers/hid/usbhid/hid-quirks.c
@@ -120,6 +120,7 @@ static const struct hid_blacklist {
        { USB_VENDOR_ID_SYNAPTICS, USB_DEVICE_ID_SYNAPTICS_HD, 
HID_QUIRK_NO_INIT_REPORTS },
        { USB_VENDOR_ID_SYNAPTICS, USB_DEVICE_ID_SYNAPTICS_QUAD_HD, 
HID_QUIRK_NO_INIT_REPORTS },
        { USB_VENDOR_ID_SYNAPTICS, USB_DEVICE_ID_SYNAPTICS_TP_V103, 
HID_QUIRK_NO_INIT_REPORTS },
+       { USB_VENDOR_ID_HOLTEK_ALT, USB_DEVICE_ID_HOLTEK_ALT_KEYBOARD_A096, 
HID_QUIRK_NO_INIT_INPUT_REPORTS },
 
        { 0, 0 }
 };
-- 
2.0.0


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2014-07-14  0:49 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2014-07-13  8:04 [PATCH v2] add quirks for 0x4d9:0xa096 hid device microcai
2014-07-13  8:04 ` [PATCH] add quirks for 0x04d9:0xa096 hid keyborad device microcai
2014-07-13 17:49   ` Henrique de Moraes Holschuh
2014-07-14  0:50     ` [PATCH v3] " microcai

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®