mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Arnd Bergmann <arnd@arndb.de>
To: Philipp Zabel <p.zabel@pengutronix.de>
Cc: Lee Jones <lee.jones@linaro.org>,
	Alexander Shiyan <shc_work@mail.ru>,
	Pankaj Dubey <pankaj.dubey@samsung.com>,
	Pawel Moll <pawel.moll@arm.com>, Wolfram Sang <wsa@the-dreams.de>,
	Peter Seiderer <ps.report@gmx.net>,
	Tushar Behera <tushar.behera@linaro.org>,
	linux-kernel@vger.kernel.org, kernel@pengutronix.de
Subject: Re: [PATCH v2] mfd: syscon: allow to register syscon with a device
Date: Wed, 24 Feb 2016 17:26:46 +0100	[thread overview]
Message-ID: <2637460.3ZCmmf9MXm@wuerfel> (raw)
In-Reply-To: <1456326148.3396.43.camel@pengutronix.de>

On Wednesday 24 February 2016 16:02:28 Philipp Zabel wrote:
> > > @@ -473,6 +474,12 @@ static const struct of_device_id imx6q_pinctrl_of_match[] = {
> > >  
> > >  static int imx6q_pinctrl_probe(struct platform_device *pdev)
> > >  {
> > > +       struct device_node *syscon_np;
> > > +
> > > +       syscon_np = of_find_compatible_node(NULL, NULL, "fsl,imx6q-iomuxc-gpr");
> > > +       if (syscon_np)
> > > +               syscon_register(&pdev->dev, syscon_np);
> > > +
> > >         return imx_pinctrl_probe(pdev, &imx6q_pinctrl_info);
> > >  }
> > >  
> > > The pinctrl driver is probed at arch_initcall time.
> > 
> > I still don't see it where you are getting with this. Is this just for
> > the debugfs interface or is there something else this does on top of
> > that?
> 
> Sorry, yes, this is about the missing debugfs functionality.

Ok, so maybe there is a different way of doing this: If I understood
it correctly, we now lost the debugfs handling on all syscon nodes?

Should we try to come up with a way to bring it back for all of them
then, rather than having to do it per device?

I can see two possible ways of doing that:

a) change the regmap code to provide a debugfs interface for all
   regmaps, including those without a device
b) change the syscon driver to explicitly register the debugfs
   interface at a later point in boot when the devices become
   available

	Arnd

  reply	other threads:[~2016-02-24 16:27 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-02-24 11:19 Philipp Zabel
2016-02-24 12:18 ` Arnd Bergmann
2016-02-24 12:44   ` Philipp Zabel
2016-02-24 15:00     ` Arnd Bergmann
2016-02-24 15:02       ` Philipp Zabel
2016-02-24 16:26         ` Arnd Bergmann [this message]
2016-02-25 17:27           ` Philipp Zabel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2637460.3ZCmmf9MXm@wuerfel \
    --to=arnd@arndb.de \
    --cc=kernel@pengutronix.de \
    --cc=lee.jones@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=p.zabel@pengutronix.de \
    --cc=pankaj.dubey@samsung.com \
    --cc=pawel.moll@arm.com \
    --cc=ps.report@gmx.net \
    --cc=shc_work@mail.ru \
    --cc=tushar.behera@linaro.org \
    --cc=wsa@the-dreams.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®