From: Evgeniy Polyakov <zbr@ioremap.net>
To: "chen.lin5@zte.com.cn" <chen.lin5@zte.com.cn>
Cc: "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"jiang.biao2@zte.com.cn" <jiang.biao2@zte.com.cn>
Subject: Re: [PATCH v2] w1:fix byteorder of W1_READ_ROM id under big-endian cpu
Date: Tue, 05 Sep 2017 16:39:21 +0300 [thread overview]
Message-ID: <265491504618761@web52g.yandex.ru> (raw)
In-Reply-To: <201708281725129358346@zte.com.cn>
Hi
28.08.2017, 12:25, "chen.lin5@zte.com.cn" <chen.lin5@zte.com.cn>:
> Hi
>
> Q:
>
> But w1_reg_num has a different layout for be/le systems, isn't it enough?
>
> A:
>
> sure, it's right only under the assumption that 'rn' is a correct layout id.
>
> Here's my example in be system which I encounter before.
>
> buf[0] return from w1_read_8(dev) in code section2 will always be 'family:8', buf[0] store at the first byte of rn, then it will be transport to cb(dev, rn) in code section1,
>
> but it will be parsed to 'crc:8' of the struct w1_reg_num in be system, then there comes the wrong.
Sorry, I do not understand. Do you mean that there is a difference between 2 ways to read ID content in w1_read_block() ?
If it is the case, is it possible, that there is a bug in particular master implementation?
There is a fair number of be devices in the tree already, and no one yet reported that there is an endian issue.
next parent reply other threads:[~2017-09-05 13:47 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <201708281725129358346@zte.com.cn>
2017-09-05 13:39 ` Evgeniy Polyakov [this message]
2017-07-19 8:08 Chen Lin
2017-08-27 7:36 ` Evgeniy Polyakov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=265491504618761@web52g.yandex.ru \
--to=zbr@ioremap.net \
--cc=chen.lin5@zte.com.cn \
--cc=jiang.biao2@zte.com.cn \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®