From: Chen Lin <chen.lin5@zte.com.cn>
To: linux-kernel@vger.kernel.org
Cc: zbr@ioremap.net, jiang.biao2@zte.com.cn, chen.lin5@zte.com.cn
Subject: [PATCH v2] w1:fix byteorder of W1_READ_ROM id under big-endian cpu
Date: Wed, 19 Jul 2017 16:08:00 +0800 [thread overview]
Message-ID: <1500451680-17885-1-git-send-email-chen.lin5@zte.com.cn> (raw)
The byteorder of para rn(W1_READ_ROM id) pass to w1_slave_found must
be the same with the byterorder defined in struct w1_reg_num.
The rn read from 'rv = w1_read_block(dev, (u8 *)&rn, 8)' is a byte
serial and not cpu endian relative, it need to change to cpu endian
before passed to w1_slave_found.
Signed-off-by: Chen Lin <chen.lin5@zte.com.cn>
Reviewed-by: Jiang Biao <jiang.biao2@zte.com.cn>
---
Forgot the description in v1.
---
drivers/w1/w1.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/w1/w1.c b/drivers/w1/w1.c
index 95ea7e6..c531545 100644
--- a/drivers/w1/w1.c
+++ b/drivers/w1/w1.c
@@ -979,7 +979,7 @@ void w1_search(struct w1_master *dev, u8 search_type, w1_slave_found_callback cb
mutex_unlock(&dev->bus_mutex);
if (rv == 8 && rn)
- cb(dev, rn);
+ cb(dev, le64_to_cpu(rn));
break;
}
--
1.8.3.1
next reply other threads:[~2017-07-19 7:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-19 8:08 Chen Lin [this message]
2017-08-27 7:36 ` Evgeniy Polyakov
[not found] <201708281725129358346@zte.com.cn>
2017-09-05 13:39 ` Evgeniy Polyakov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1500451680-17885-1-git-send-email-chen.lin5@zte.com.cn \
--to=chen.lin5@zte.com.cn \
--cc=jiang.biao2@zte.com.cn \
--cc=linux-kernel@vger.kernel.org \
--cc=zbr@ioremap.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®