mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Zhang Heng <zhangheng@kylinos.cn>
To: Jeremy Bryan Smith <helamonster@gmail.com>, linux-sound@vger.kernel.org
Cc: tiwai@suse.de, perex@perex.cz, linux-kernel@vger.kernel.org,
	regressions@lists.linux.dev
Subject: Re: [PATCH v2] ALSA: hda/realtek: Rename Line Out control to Headphone on ThinkPad X1 Carbon 6th
Date: Thu, 19 Nov 2026 15:44:47 +0800	[thread overview]
Message-ID: <266dcc7e-19ec-434e-95b6-9a7356cb620e@kylinos.cn> (raw)
In-Reply-To: <CAAk_qkgY_To5dwBgua8NBpUv7YWB6g1w5b2g6+BzQ5=mqgq6dA@mail.gmail.com>

Hi Jeremy,

Thank you for the report and for the precise diagnosis. You are right,
and I'm sorry for the regression -- I introduced it with commit
108704eecab9.

The cause was my oversight of the vendor-level fallback. In
alc269_fixup_vendor_tbl[] there is a catch-all entry:

     SND_PCI_QUIRK_VENDOR(0x17aa, "Lenovo XPAD",
                          ALC269_FIXUP_LENOVO_XPAD_ACPI)

It chains to ALC269_FIXUP_THINKPAD_ACPI, which at
HDA_FIXUP_ACT_PRE_PROBE calls snd_hda_gen_add_mute_led_cdev() and
snd_hda_gen_add_micmute_led_cdev(). Before my commit, 17aa:225c had no
specific entry in alc269_fixup_tbl[], so it fell through to this fallback
and the LEDs were registered. Adding the specific quirk made
snd_hda_pick_fixup() return early with fixup_id already set, so the
vendor fallback was never consulted. ALC285_LENOVO_DAC_RENAME had no
chain, and the LED registration was silently dropped.

Your proposed fix is correct. In sound/hda/codecs/realtek/alc269.c, add
two fields to the ALC285_LENOVO_DAC_RENAME fixup definition:

     .chained = true,
     .chain_id = ALC269_FIXUP_THINKPAD_ACPI,

Keep the rename in alc285_lenovo_dac_rename() at HDA_FIXUP_ACT_BUILD.
The two actions run in different fixup phases, and THINKPAD_ACPI chains
to ALC269_FIXUP_SKU_IGNORE with no cycle.

Since you already found the root cause and have a machine to verify on,
would you like to submit the patch yourself?

If you'd rather not, just say so and I'll submit the fix myself -- no
need to explain. Either way, please include a Fixes: tag pointing to
108704eecab9. If you send it, use your own Signed-off-by and I'll add my
Reviewed-by on the list.

Thanks again for the excellent report.

Regards,
Zhang Heng

  reply	other threads:[~2026-11-19  7:45 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-19  3:00 Jeremy Bryan Smith
2026-11-19  7:44 ` Zhang Heng [this message]
  -- strict thread matches above, loose matches on Subject: below --
2026-08-11  6:12 [PATCH 1/4] " Takashi Iwai
2026-08-11  6:27 ` [PATCH v2] " Zhang Heng
2026-08-11  6:45   ` Takashi Iwai

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=266dcc7e-19ec-434e-95b6-9a7356cb620e@kylinos.cn \
    --to=zhangheng@kylinos.cn \
    --cc=helamonster@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sound@vger.kernel.org \
    --cc=perex@perex.cz \
    --cc=regressions@lists.linux.dev \
    --cc=tiwai@suse.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®