* Re: [PATCH v2] ALSA: hda/realtek: Rename Line Out control to Headphone on ThinkPad X1 Carbon 6th
@ 2026-11-19 3:00 Jeremy Bryan Smith
2026-11-19 7:44 ` Zhang Heng
0 siblings, 1 reply; 4+ messages in thread
From: Jeremy Bryan Smith @ 2026-11-19 3:00 UTC (permalink / raw)
To: linux-sound; +Cc: tiwai, perex, zhangheng, linux-kernel, regressions
[REGRESSION]
Hi,
On a Lenovo ThinkPad X1 Carbon 6th (20KH002RUS, PCI SSID 17aa:225c,
ALC285), the speaker and mic-mute LEDs stopped tracking mute state after
upgrading to Ubuntu 26.10 kernel 7.3.0-10-generic. The mute keys and ALSA
switches work, but both /sys/class/sound/ctl-led/speaker/card0/list and
/sys/class/sound/ctl-led/mic/card0/list are empty.
Both LEDs follow the mute state after manual attachment:
printf '%s' 'numid=11' > /sys/class/sound/ctl-led/speaker/card0/attach
printf '%s' 'numid=7' > /sys/class/sound/ctl-led/mic/card0/attach
Commit 108704eecab9 ("ALSA: hda/realtek: Rename Line Out control to
Headphone on ThinkPad X1 Carbon 6th") adds ALC285_LENOVO_DAC_RENAME for
17aa:225c. That fixup is not chained to ALC269_FIXUP_THINKPAD_ACPI, so
snd_hda_gen_add_mute_led_cdev() and snd_hda_gen_add_micmute_led_cdev() are
no longer applied through the old pin fixup.
Chaining ALC285_LENOVO_DAC_RENAME to ALC269_FIXUP_THINKPAD_ACPI, while
keeping the rename at HDA_FIXUP_ACT_BUILD, looks like the likely fix.
Full diagnostics are available at:
https://bugs.launchpad.net/ubuntu/+source/linux/+bug/2174970
Please advise.
Regards,
Jeremy Bryan Smith
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH v2] ALSA: hda/realtek: Rename Line Out control to Headphone on ThinkPad X1 Carbon 6th
2026-11-19 3:00 [PATCH v2] ALSA: hda/realtek: Rename Line Out control to Headphone on ThinkPad X1 Carbon 6th Jeremy Bryan Smith
@ 2026-11-19 7:44 ` Zhang Heng
0 siblings, 0 replies; 4+ messages in thread
From: Zhang Heng @ 2026-11-19 7:44 UTC (permalink / raw)
To: Jeremy Bryan Smith, linux-sound; +Cc: tiwai, perex, linux-kernel, regressions
Hi Jeremy,
Thank you for the report and for the precise diagnosis. You are right,
and I'm sorry for the regression -- I introduced it with commit
108704eecab9.
The cause was my oversight of the vendor-level fallback. In
alc269_fixup_vendor_tbl[] there is a catch-all entry:
SND_PCI_QUIRK_VENDOR(0x17aa, "Lenovo XPAD",
ALC269_FIXUP_LENOVO_XPAD_ACPI)
It chains to ALC269_FIXUP_THINKPAD_ACPI, which at
HDA_FIXUP_ACT_PRE_PROBE calls snd_hda_gen_add_mute_led_cdev() and
snd_hda_gen_add_micmute_led_cdev(). Before my commit, 17aa:225c had no
specific entry in alc269_fixup_tbl[], so it fell through to this fallback
and the LEDs were registered. Adding the specific quirk made
snd_hda_pick_fixup() return early with fixup_id already set, so the
vendor fallback was never consulted. ALC285_LENOVO_DAC_RENAME had no
chain, and the LED registration was silently dropped.
Your proposed fix is correct. In sound/hda/codecs/realtek/alc269.c, add
two fields to the ALC285_LENOVO_DAC_RENAME fixup definition:
.chained = true,
.chain_id = ALC269_FIXUP_THINKPAD_ACPI,
Keep the rename in alc285_lenovo_dac_rename() at HDA_FIXUP_ACT_BUILD.
The two actions run in different fixup phases, and THINKPAD_ACPI chains
to ALC269_FIXUP_SKU_IGNORE with no cycle.
Since you already found the root cause and have a machine to verify on,
would you like to submit the patch yourself?
If you'd rather not, just say so and I'll submit the fix myself -- no
need to explain. Either way, please include a Fixes: tag pointing to
108704eecab9. If you send it, use your own Signed-off-by and I'll add my
Reviewed-by on the list.
Thanks again for the excellent report.
Regards,
Zhang Heng
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 1/4] ALSA: hda/realtek: Rename Line Out control to Headphone on ThinkPad X1 Carbon 6th
@ 2026-08-11 6:12 Takashi Iwai
2026-08-11 6:27 ` [PATCH v2] " Zhang Heng
0 siblings, 1 reply; 4+ messages in thread
From: Takashi Iwai @ 2026-08-11 6:12 UTC (permalink / raw)
To: Zhang Heng; +Cc: tiwai, perex, linux-sound, linux-kernel, Branislav Klocok
On Tue, 11 Aug 2026 04:48:59 +0200,
Zhang Heng wrote:
>
> The ThinkPad X1 Carbon 6th Gen (ALC285, SSID 17aa:225c) has no physical
> Line Out jack. The 3.5mm headphone jack is wired to the headphone DAC,
> but the ALSA HDA driver names the corresponding control as
> "Line Out Playback Volume" (node 0x02).
>
> PipeWire's ALSA Card Profile (ACP) silences "Line Out" when headphones
> are activated, which incorrectly mutes the headphone output.
>
> Add a quirk to rename the control to "Headphone Playback Volume" via
> alc285_lenovo_dac_rename().
>
> Tested on openSUSE Tumbleweed (kernel 7.1.5):
> - Control renamed successfully, no name collision with "Headphone Playback Switch"
> - Headphone output works across multiple PipeWire/WirePlumber restarts
> and port switches
>
> Closes: https://bugzilla.kernel.org/show_bug.cgi?id=221522
> Signed-off-by: Zhang Heng <zhangheng@kylinos.cn>
> Tested-by: Branislav Klocok <branislav.klocok@orava.sk>
> ---
> sound/hda/codecs/realtek/alc269.c | 12 ++++++++++++
> 1 file changed, 12 insertions(+)
>
> diff --git a/sound/hda/codecs/realtek/alc269.c b/sound/hda/codecs/realtek/alc269.c
> index 6b36c730ce78..da9c816b8c4f 100644
> --- a/sound/hda/codecs/realtek/alc269.c
> +++ b/sound/hda/codecs/realtek/alc269.c
> @@ -2572,6 +2572,13 @@ static void alc282_fixup_asus_tx300(struct hda_codec *codec,
> }
> }
>
> +static void alc285_lenovo_dac_rename(struct hda_codec *codec,
> + const struct hda_fixup *fix, int action)
> +{
> + if (action == HDA_FIXUP_ACT_BUILD)
> + rename_ctl(codec, "Line Out Playback Volume",
> + "Headphone Playback Volume");
> +}
> static void alc290_fixup_mono_speakers(struct hda_codec *codec,
> const struct hda_fixup *fix, int action)
> {
> @@ -6998,6 +7005,10 @@ static const struct hda_fixup alc269_fixups[] = {
> .chained = true,
> .chain_id = ALC287_FIXUP_YOGA9_14IAP7_BASS_SPK_PIN,
> },
> + [ALC285_LENOVO_DAC_RENAME] = {
> + .type = HDA_FIXUP_FUNC,
> + .v.func = alc285_lenovo_dac_rename,
> + },
> };
>
> static const struct hda_quirk alc269_fixup_tbl[] = {
> @@ -7956,6 +7967,7 @@ static const struct hda_quirk alc269_fixup_tbl[] = {
> SND_PCI_QUIRK(0x17aa, 0x224b, "Thinkpad", ALC298_FIXUP_TPT470_DOCK),
> SND_PCI_QUIRK(0x17aa, 0x224c, "Thinkpad", ALC298_FIXUP_TPT470_DOCK),
> SND_PCI_QUIRK(0x17aa, 0x224d, "Thinkpad", ALC298_FIXUP_TPT470_DOCK),
> + SND_PCI_QUIRK(0x17aa, 0x225c, "Lenovo ThinkPad X1 Carbon 6th Gen", ALC285_LENOVO_DAC_RENAME),
> SND_PCI_QUIRK(0x17aa, 0x225d, "Thinkpad T480", ALC269_FIXUP_THINKPAD_LIMIT_INT_MIC_BOOST),
> SND_PCI_QUIRK(0x17aa, 0x2288, "Thinkpad X390", ALC285_FIXUP_THINKPAD_NO_BASS_SPK_HEADSET_JACK),
> SND_PCI_QUIRK(0x17aa, 0x2292, "Thinkpad X1 Carbon 7th", ALC285_FIXUP_THINKPAD_HEADSET_JACK),
Hmm, this patch is broken -- missing the definition of enum
ALC285_LENOVO_DAC_RENAME?
thanks,
Takashi
^ permalink raw reply [flat|nested] 4+ messages in thread* [PATCH v2] ALSA: hda/realtek: Rename Line Out control to Headphone on ThinkPad X1 Carbon 6th
2026-08-11 6:12 [PATCH 1/4] " Takashi Iwai
@ 2026-08-11 6:27 ` Zhang Heng
2026-08-11 6:45 ` Takashi Iwai
0 siblings, 1 reply; 4+ messages in thread
From: Zhang Heng @ 2026-08-11 6:27 UTC (permalink / raw)
To: tiwai; +Cc: linux-kernel, linux-sound, perex, Zhang Heng, Branislav Klocok
The ThinkPad X1 Carbon 6th Gen (ALC285, SSID 17aa:225c) has no physical
Line Out jack. The 3.5mm headphone jack is wired to the headphone DAC,
but the ALSA HDA driver names the corresponding control as
"Line Out Playback Volume" (node 0x02).
PipeWire's ALSA Card Profile (ACP) silences "Line Out" when headphones
are activated, which incorrectly mutes the headphone output.
Add a quirk to rename the control to "Headphone Playback Volume" via
alc285_lenovo_dac_rename().
Tested on openSUSE Tumbleweed (kernel 7.1.5):
- Control renamed successfully, no name collision with "Headphone Playback Switch"
- Headphone output works across multiple PipeWire/WirePlumber restarts
and port switches
Closes: https://bugzilla.kernel.org/show_bug.cgi?id=221522
Signed-off-by: Zhang Heng <zhangheng@kylinos.cn>
Tested-by: Branislav Klocok <branislav.klocok@orava.sk>
---
sound/hda/codecs/realtek/alc269.c | 13 +++++++++++++
1 file changed, 13 insertions(+)
diff --git a/sound/hda/codecs/realtek/alc269.c b/sound/hda/codecs/realtek/alc269.c
index 6b36c730ce78..48d887d1324f 100644
--- a/sound/hda/codecs/realtek/alc269.c
+++ b/sound/hda/codecs/realtek/alc269.c
@@ -2572,6 +2572,13 @@ static void alc282_fixup_asus_tx300(struct hda_codec *codec,
}
}
+static void alc285_lenovo_dac_rename(struct hda_codec *codec,
+ const struct hda_fixup *fix, int action)
+{
+ if (action == HDA_FIXUP_ACT_BUILD)
+ rename_ctl(codec, "Line Out Playback Volume",
+ "Headphone Playback Volume");
+}
static void alc290_fixup_mono_speakers(struct hda_codec *codec,
const struct hda_fixup *fix, int action)
{
@@ -4289,6 +4296,7 @@ enum {
ALC287_FIXUP_AW88399_I2C_2,
ALC287_FIXUP_LENOVO_LEGION_AW88399,
ALC287_FIXUP_YOGA9_14IAP7_BASS_SPK_PIN_HEADSET,
+ ALC285_LENOVO_DAC_RENAME,
};
/* A special fixup for Lenovo C940 and Yoga Duet 7;
@@ -6998,6 +7006,10 @@ static const struct hda_fixup alc269_fixups[] = {
.chained = true,
.chain_id = ALC287_FIXUP_YOGA9_14IAP7_BASS_SPK_PIN,
},
+ [ALC285_LENOVO_DAC_RENAME] = {
+ .type = HDA_FIXUP_FUNC,
+ .v.func = alc285_lenovo_dac_rename,
+ },
};
static const struct hda_quirk alc269_fixup_tbl[] = {
@@ -7956,6 +7968,7 @@ static const struct hda_quirk alc269_fixup_tbl[] = {
SND_PCI_QUIRK(0x17aa, 0x224b, "Thinkpad", ALC298_FIXUP_TPT470_DOCK),
SND_PCI_QUIRK(0x17aa, 0x224c, "Thinkpad", ALC298_FIXUP_TPT470_DOCK),
SND_PCI_QUIRK(0x17aa, 0x224d, "Thinkpad", ALC298_FIXUP_TPT470_DOCK),
+ SND_PCI_QUIRK(0x17aa, 0x225c, "Lenovo ThinkPad X1 Carbon 6th Gen", ALC285_LENOVO_DAC_RENAME),
SND_PCI_QUIRK(0x17aa, 0x225d, "Thinkpad T480", ALC269_FIXUP_THINKPAD_LIMIT_INT_MIC_BOOST),
SND_PCI_QUIRK(0x17aa, 0x2288, "Thinkpad X390", ALC285_FIXUP_THINKPAD_NO_BASS_SPK_HEADSET_JACK),
SND_PCI_QUIRK(0x17aa, 0x2292, "Thinkpad X1 Carbon 7th", ALC285_FIXUP_THINKPAD_HEADSET_JACK),
--
2.25.1
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH v2] ALSA: hda/realtek: Rename Line Out control to Headphone on ThinkPad X1 Carbon 6th
2026-08-11 6:27 ` [PATCH v2] " Zhang Heng
@ 2026-08-11 6:45 ` Takashi Iwai
0 siblings, 0 replies; 4+ messages in thread
From: Takashi Iwai @ 2026-08-11 6:45 UTC (permalink / raw)
To: Zhang Heng; +Cc: tiwai, linux-kernel, linux-sound, perex, Branislav Klocok
On Tue, 11 Aug 2026 08:27:34 +0200,
Zhang Heng wrote:
>
> The ThinkPad X1 Carbon 6th Gen (ALC285, SSID 17aa:225c) has no physical
> Line Out jack. The 3.5mm headphone jack is wired to the headphone DAC,
> but the ALSA HDA driver names the corresponding control as
> "Line Out Playback Volume" (node 0x02).
>
> PipeWire's ALSA Card Profile (ACP) silences "Line Out" when headphones
> are activated, which incorrectly mutes the headphone output.
>
> Add a quirk to rename the control to "Headphone Playback Volume" via
> alc285_lenovo_dac_rename().
>
> Tested on openSUSE Tumbleweed (kernel 7.1.5):
> - Control renamed successfully, no name collision with "Headphone Playback Switch"
> - Headphone output works across multiple PipeWire/WirePlumber restarts
> and port switches
>
> Closes: https://bugzilla.kernel.org/show_bug.cgi?id=221522
> Signed-off-by: Zhang Heng <zhangheng@kylinos.cn>
> Tested-by: Branislav Klocok <branislav.klocok@orava.sk>
Applied now to for-next branch. Thanks.
Takashi
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2026-11-19 7:45 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-11-19 3:00 [PATCH v2] ALSA: hda/realtek: Rename Line Out control to Headphone on ThinkPad X1 Carbon 6th Jeremy Bryan Smith
2026-11-19 7:44 ` Zhang Heng
-- strict thread matches above, loose matches on Subject: below --
2026-08-11 6:12 [PATCH 1/4] " Takashi Iwai
2026-08-11 6:27 ` [PATCH v2] " Zhang Heng
2026-08-11 6:45 ` Takashi Iwai
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®