* [BUG] drivers/scsi/dpt_i2o: a possible sleep-in-atomic bug in adpt_i2o_status_get
@ 2017-12-12 2:20 Jia-Ju Bai
0 siblings, 0 replies; only message in thread
From: Jia-Ju Bai @ 2017-12-12 2:20 UTC (permalink / raw)
To: aacraid, jejb, martin.petersen, linux-scsi, Linux Kernel Mailing List
According to drivers/scsi/dpt_i2o.c, the kernel module may sleep under a
spinlock.
The function call paths are:
adpt_reset (acquire the spinlock)
__adpt_reset
adpt_hba_reset
adpt_i2o_activate_hba
adpt_i2o_status_get
dma_alloc_coherent(GFP_KERNEL) --> may sleep
schedule_timeout_uninterruptible --> may sleep
A possible fixing is to replace "schedule_timeout_uninterruptible" with
"mdelay" and replace "GFP_KERNEL" with "GFP_ATOMIC".
If this fixing is correct, I can send a patch.
This possible bug is found by my static analysis tool (DSAC) and checked
by my code review.
Thanks,
Jia-Ju Bai
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2017-12-12 2:20 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-12-12 2:20 [BUG] drivers/scsi/dpt_i2o: a possible sleep-in-atomic bug in adpt_i2o_status_get Jia-Ju Bai
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®