Re: [PATCH RESEND v4 02/10] PM: EM: Expose the ID of a performance domain via debugfs

[Lukasz Luba <lukasz.luba@arm.com>]

On 9/21/25 04:19, Changwoo Min wrote:
> For ease of debugging, let's expose the assigned ID of a performance
> domain through debugfs (e.g., /sys/kernel/debug/energy_model/cpu0/id).
> 
> Signed-off-by: Changwoo Min <changwoo@igalia.com>
> ---
>   kernel/power/energy_model.c | 12 ++++++++++++
>   1 file changed, 12 insertions(+)
> 
> diff --git a/kernel/power/energy_model.c b/kernel/power/energy_model.c
> index 3fe562b6230e..8998a7f4910a 100644
> --- a/kernel/power/energy_model.c
> +++ b/kernel/power/energy_model.c
> @@ -126,6 +126,16 @@ static int em_debug_flags_show(struct seq_file *s, void *unused)
>   }
>   DEFINE_SHOW_ATTRIBUTE(em_debug_flags);
>   
> +static int em_debug_id_show(struct seq_file *s, void *unused)
> +{
> +	struct em_perf_domain *pd = s->private;
> +
> +	seq_printf(s, "%d\n", pd->id);
> +
> +	return 0;
> +}
> +DEFINE_SHOW_ATTRIBUTE(em_debug_id);
> +
>   static void em_debug_create_pd(struct device *dev)
>   {
>   	struct em_dbg_info *em_dbg;
> @@ -142,6 +152,8 @@ static void em_debug_create_pd(struct device *dev)
>   	debugfs_create_file("flags", 0444, d, dev->em_pd,
>   			    &em_debug_flags_fops);
>   
> +	debugfs_create_file("id", 0444, d, dev->em_pd, &em_debug_id_fops);
> +
>   	em_dbg = devm_kcalloc(dev, dev->em_pd->nr_perf_states,
>   			      sizeof(*em_dbg), GFP_KERNEL);
>   	if (!em_dbg)

LGTM,

Reviewed-by: Lukasz Luba <lukasz.luba@arm.com>